Diff
Modified: trunk/LayoutTests/ChangeLog (128603 => 128604)
--- trunk/LayoutTests/ChangeLog 2012-09-14 13:27:18 UTC (rev 128603)
+++ trunk/LayoutTests/ChangeLog 2012-09-14 13:27:57 UTC (rev 128604)
@@ -1,5 +1,19 @@
2012-09-14 Sudarsana Nagineni <[email protected]>
+ WebKitTestRunner needs layoutTestController.setTabKeyCyclesThroughElements
+ https://bugs.webkit.org/show_bug.cgi?id=42687
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ fast/events/keypress-insert-tab.html is passing now on wk2. So, unskip
+ in common skipped files and re-skip it on efl-wk1 until WK82864 is fixed.
+
+ * platform/efl-wk1/TestExpectations:
+ * platform/efl/Skipped:
+ * platform/wk2/Skipped:
+
+2012-09-14 Sudarsana Nagineni <[email protected]>
+
EventSendingController::keyDown does not support non-array modifier arguments
https://bugs.webkit.org/show_bug.cgi?id=96727
Modified: trunk/LayoutTests/platform/efl/Skipped (128603 => 128604)
--- trunk/LayoutTests/platform/efl/Skipped 2012-09-14 13:27:18 UTC (rev 128603)
+++ trunk/LayoutTests/platform/efl/Skipped 2012-09-14 13:27:57 UTC (rev 128604)
@@ -78,9 +78,6 @@
# EFL's LayoutTestController does not implement setScrollbarPolicy
fast/overflow/scrollbar-restored-and-then-locked.html
-# EFL's LayoutTestController does not implement setTabKeyCyclesThroughElements
-fast/events/keypress-insert-tab.html
-
# EFL's LayoutTestController does not implement enableAutoResizeMode
fast/autoresize
Modified: trunk/LayoutTests/platform/efl-wk1/TestExpectations (128603 => 128604)
--- trunk/LayoutTests/platform/efl-wk1/TestExpectations 2012-09-14 13:27:18 UTC (rev 128603)
+++ trunk/LayoutTests/platform/efl-wk1/TestExpectations 2012-09-14 13:27:57 UTC (rev 128604)
@@ -78,3 +78,6 @@
BUGWK96620 : http/tests/loading/pdf-commit-load-callbacks.html = TEXT
BUGWK96620 : http/tests/loading/text-content-type-with-binary-extension.html = TEXT
+// EFL's LayoutTestController does not implement setTabKeyCyclesThroughElements.
+BUGWK82864 : fast/events/keypress-insert-tab.html = TEXT
+
Modified: trunk/LayoutTests/platform/wk2/Skipped (128603 => 128604)
--- trunk/LayoutTests/platform/wk2/Skipped 2012-09-14 13:27:18 UTC (rev 128603)
+++ trunk/LayoutTests/platform/wk2/Skipped 2012-09-14 13:27:57 UTC (rev 128604)
@@ -424,10 +424,6 @@
# <https://bugs.webkit.org/show_bug.cgi?id=42686>
fast/encoding/idn-security.html
-# WebKitTestRunner needs layoutTestController.setTabKeyCyclesThroughElements
-# <https://bugs.webkit.org/show_bug.cgi?id=42687>
-fast/events/keypress-insert-tab.html
-
# WebKitTestRunner needs layoutTestController.abortModal
# <https://bugs.webkit.org/show_bug.cgi?id=69548>
fast/events/show-modal-dialog-onblur-onfocus.html
Modified: trunk/Source/WebKit2/ChangeLog (128603 => 128604)
--- trunk/Source/WebKit2/ChangeLog 2012-09-14 13:27:18 UTC (rev 128603)
+++ trunk/Source/WebKit2/ChangeLog 2012-09-14 13:27:57 UTC (rev 128604)
@@ -1,3 +1,22 @@
+2012-09-14 Sudarsana Nagineni <[email protected]>
+
+ WebKitTestRunner needs layoutTestController.setTabKeyCyclesThroughElements
+ https://bugs.webkit.org/show_bug.cgi?id=42687
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ Implement testRunner.setTabKeyCyclesThroughElements for
+ WebKitTestRunner.
+
+ * WebProcess/InjectedBundle/API/c/WKBundle.cpp:
+ (WKBundleSetTabKeyCyclesThroughElements):
+ * WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
+ * WebProcess/InjectedBundle/InjectedBundle.cpp:
+ (WebKit::InjectedBundle::setTabKeyCyclesThroughElements):
+ (WebKit):
+ * WebProcess/InjectedBundle/InjectedBundle.h:
+ (InjectedBundle):
+
2012-09-14 Keishi Hattori <[email protected]>
Add runtime flag that enables lang attribute for form controls in LayoutTests
Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundle.cpp (128603 => 128604)
--- trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundle.cpp 2012-09-14 13:27:18 UTC (rev 128603)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundle.cpp 2012-09-14 13:27:57 UTC (rev 128604)
@@ -324,3 +324,7 @@
return toImpl(bundleRef)->webNotificationID(context, notification);
}
+void WKBundleSetTabKeyCyclesThroughElements(WKBundleRef bundleRef, WKBundlePageRef pageRef, bool enabled)
+{
+ toImpl(bundleRef)->setTabKeyCyclesThroughElements(toImpl(pageRef), enabled);
+}
Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePrivate.h (128603 => 128604)
--- trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePrivate.h 2012-09-14 13:27:18 UTC (rev 128603)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePrivate.h 2012-09-14 13:27:57 UTC (rev 128604)
@@ -113,6 +113,8 @@
WK_EXPORT size_t WKBundleGetWorkerThreadCount(WKBundleRef bundle);
+WK_EXPORT void WKBundleSetTabKeyCyclesThroughElements(WKBundleRef bundle, WKBundlePageRef page, bool enabled);
+
#ifdef __cplusplus
}
#endif
Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp (128603 => 128604)
--- trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp 2012-09-14 13:27:18 UTC (rev 128603)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp 2012-09-14 13:27:57 UTC (rev 128604)
@@ -646,4 +646,9 @@
#endif
}
+void InjectedBundle::setTabKeyCyclesThroughElements(WebPage* page, bool enabled)
+{
+ page->corePage()->setTabKeyCyclesThroughElements(enabled);
+}
+
} // namespace WebKit
Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.h (128603 => 128604)
--- trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.h 2012-09-14 13:27:18 UTC (rev 128603)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.h 2012-09-14 13:27:57 UTC (rev 128604)
@@ -175,6 +175,8 @@
static size_t workerThreadCount();
+ void setTabKeyCyclesThroughElements(WebPage*, bool enabled);
+
private:
explicit InjectedBundle(const String&);
Modified: trunk/Tools/ChangeLog (128603 => 128604)
--- trunk/Tools/ChangeLog 2012-09-14 13:27:18 UTC (rev 128603)
+++ trunk/Tools/ChangeLog 2012-09-14 13:27:57 UTC (rev 128604)
@@ -1,5 +1,24 @@
2012-09-14 Sudarsana Nagineni <[email protected]>
+ WebKitTestRunner needs layoutTestController.setTabKeyCyclesThroughElements
+ https://bugs.webkit.org/show_bug.cgi?id=42687
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ Implement testRunner.setTabKeyCyclesThroughElements for
+ WebKitTestRunner.
+
+ * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
+ * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
+ (WTR::InjectedBundle::beginTesting):
+ * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
+ (WTR::TestRunner::setTabKeyCyclesThroughElements):
+ (WTR):
+ * WebKitTestRunner/InjectedBundle/TestRunner.h:
+ (TestRunner):
+
+2012-09-14 Sudarsana Nagineni <[email protected]>
+
EventSendingController::keyDown does not support non-array modifier arguments
https://bugs.webkit.org/show_bug.cgi?id=96727
Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl (128603 => 128604)
--- trunk/Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl 2012-09-14 13:27:18 UTC (rev 128603)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl 2012-09-14 13:27:57 UTC (rev 128604)
@@ -71,6 +71,7 @@
void setUserStyleSheetLocation(in DOMString location);
void setMinimumTimerInterval(in double interval); // Interval specified in seconds.
void setSpatialNavigationEnabled(in boolean value);
+ void setTabKeyCyclesThroughElements(in boolean enabled);
// Special DOM functions.
void clearBackForwardList();
Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp (128603 => 128604)
--- trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp 2012-09-14 13:27:18 UTC (rev 128603)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp 2012-09-14 13:27:57 UTC (rev 128604)
@@ -253,6 +253,7 @@
m_testRunner->setXSSAuditorEnabled(false);
m_testRunner->setCloseRemainingWindowsWhenComplete(false);
m_testRunner->setAcceptsEditing(true);
+ m_testRunner->setTabKeyCyclesThroughElements(true);
page()->prepare();
Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp (128603 => 128604)
--- trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp 2012-09-14 13:27:18 UTC (rev 128603)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp 2012-09-14 13:27:57 UTC (rev 128604)
@@ -735,6 +735,11 @@
WKBundleSetSpatialNavigationEnabled(InjectedBundle::shared().bundle(), InjectedBundle::shared().pageGroup(), enabled);
}
+void TestRunner::setTabKeyCyclesThroughElements(bool enabled)
+{
+ WKBundleSetTabKeyCyclesThroughElements(InjectedBundle::shared().bundle(), InjectedBundle::shared().page()->page(), enabled);
+}
+
void TestRunner::grantWebNotificationPermission(JSStringRef origin)
{
WKRetainPtr<WKStringRef> originWK = toWK(origin);
Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.h (128603 => 128604)
--- trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.h 2012-09-14 13:27:18 UTC (rev 128603)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.h 2012-09-14 13:27:57 UTC (rev 128604)
@@ -109,6 +109,7 @@
void setUserStyleSheetLocation(JSStringRef);
void setMinimumTimerInterval(double seconds); // Interval specified in seconds.
void setSpatialNavigationEnabled(bool);
+ void setTabKeyCyclesThroughElements(bool);
// Special DOM functions.
JSValueRef computedStyleIncludingVisitedInfo(JSValueRef element);
