Title: [128756] trunk/Source/WebKit/blackberry
Revision
128756
Author
[email protected]
Date
2012-09-17 08:00:42 -0700 (Mon, 17 Sep 2012)

Log Message

[BlackBerry] To support "Frames View" of "TimeLine" panel in Inspector
https://bugs.webkit.org/show_bug.cgi?id=96077

Patch by Peter Wang <[email protected]> on 2012-09-17
Reviewed by Rob Buis.

Invoke the "instrumentBeginFrame" and "instrumentCancelFrame" at the start and end of processing
render message to record one time of page's update.

* Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::instrumentBeginFrame):
(WebKit):
(BlackBerry::WebKit::BackingStorePrivate::instrumentCancelFrame):
* Api/BackingStore_p.h:
* WebKitSupport/RenderQueue.cpp:
(BlackBerry::WebKit::RenderQueue::render):

Modified Paths

Diff

Modified: trunk/Source/WebKit/blackberry/Api/BackingStore.cpp (128755 => 128756)


--- trunk/Source/WebKit/blackberry/Api/BackingStore.cpp	2012-09-17 14:57:36 UTC (rev 128755)
+++ trunk/Source/WebKit/blackberry/Api/BackingStore.cpp	2012-09-17 15:00:42 UTC (rev 128756)
@@ -28,6 +28,7 @@
 #include "FrameView.h"
 #include "GraphicsContext.h"
 #include "InspectorController.h"
+#include "InspectorInstrumentation.h"
 #include "Page.h"
 #include "SurfacePool.h"
 #include "WebPage.h"
@@ -235,6 +236,16 @@
     pthread_mutex_destroy(&m_mutex);
 }
 
+void BackingStorePrivate::instrumentBeginFrame()
+{
+    WebCore::InspectorInstrumentation::didBeginFrame(WebPagePrivate::core(m_webPage));
+}
+
+void BackingStorePrivate::instrumentCancelFrame()
+{
+    WebCore::InspectorInstrumentation::didCancelFrame(WebPagePrivate::core(m_webPage));
+}
+
 bool BackingStorePrivate::shouldDirectRenderingToWindow() const
 {
     // Direct rendering doesn't work with OpenGL compositing code paths due to

Modified: trunk/Source/WebKit/blackberry/Api/BackingStore_p.h (128755 => 128756)


--- trunk/Source/WebKit/blackberry/Api/BackingStore_p.h	2012-09-17 14:57:36 UTC (rev 128755)
+++ trunk/Source/WebKit/blackberry/Api/BackingStore_p.h	2012-09-17 15:00:42 UTC (rev 128756)
@@ -101,6 +101,9 @@
     enum TileMatrixDirection { Horizontal, Vertical };
     BackingStorePrivate();
 
+    void instrumentBeginFrame();
+    void instrumentCancelFrame();
+
     // Returns whether direct rendering is explicitly turned on or is
     // required because the surface pool is not large enough to meet
     // the minimum number of tiles required to scroll.

Modified: trunk/Source/WebKit/blackberry/ChangeLog (128755 => 128756)


--- trunk/Source/WebKit/blackberry/ChangeLog	2012-09-17 14:57:36 UTC (rev 128755)
+++ trunk/Source/WebKit/blackberry/ChangeLog	2012-09-17 15:00:42 UTC (rev 128756)
@@ -1,3 +1,21 @@
+2012-09-17  Peter Wang  <[email protected]>
+
+        [BlackBerry] To support "Frames View" of "TimeLine" panel in Inspector
+        https://bugs.webkit.org/show_bug.cgi?id=96077
+
+        Reviewed by Rob Buis.
+
+        Invoke the "instrumentBeginFrame" and "instrumentCancelFrame" at the start and end of processing
+        render message to record one time of page's update.
+
+        * Api/BackingStore.cpp:
+        (BlackBerry::WebKit::BackingStorePrivate::instrumentBeginFrame):
+        (WebKit):
+        (BlackBerry::WebKit::BackingStorePrivate::instrumentCancelFrame):
+        * Api/BackingStore_p.h:
+        * WebKitSupport/RenderQueue.cpp:
+        (BlackBerry::WebKit::RenderQueue::render):
+
 2012-09-17  Jakob Petsovits  <[email protected]>
 
         [BlackBerry] Support copying image data in WebOverlay.

Modified: trunk/Source/WebKit/blackberry/WebKitSupport/RenderQueue.cpp (128755 => 128756)


--- trunk/Source/WebKit/blackberry/WebKitSupport/RenderQueue.cpp	2012-09-17 14:57:36 UTC (rev 128755)
+++ trunk/Source/WebKit/blackberry/WebKitSupport/RenderQueue.cpp	2012-09-17 15:00:42 UTC (rev 128756)
@@ -564,6 +564,8 @@
     double time = WTF::currentTime();
 #endif
 
+    m_parent->instrumentBeginFrame();
+
     m_parent->requestLayoutIfNeeded();
 
 #if DEBUG_RENDER_QUEUE
@@ -584,6 +586,8 @@
             renderRegularRenderJob();
     } else if (!m_nonVisibleScrollJobs.empty())
         renderNonVisibleScrollJob();
+
+    m_parent->instrumentCancelFrame();
 }
 
 void RenderQueue::renderAllCurrentRegularRenderJobs()
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to