Title: [128766] trunk/Source/WebKit/blackberry
Revision
128766
Author
[email protected]
Date
2012-09-17 09:05:21 -0700 (Mon, 17 Sep 2012)

Log Message

[BlackBerry] BackingStorePrivate::resumeScreenAndBackingStoreUpdates more atomic
https://bugs.webkit.org/show_bug.cgi?id=96925

[FullScreen] entering/leaving fullscreen results in temporary glitches on the screen (part 2/3)
PR #180866

eviewed by Rob Buis.
Patch by Antonio Gomes <[email protected]>
Internally reviewed by Arvid Nilsson.

Paraphrasing Arvid "resumeBackingStore will be a truly atomic operation.
Well more atomic than it was before, with regards to a mix of accelerated and
non-accelerated compositing content".

I.e. by committing the root layer (if needed) when resuming the Backing
Store, we call blitVisibleContents right way, so we are actually shortcutting when
AC content will get on screen.

* Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::resumeScreenAndBackingStoreUpdates):

Modified Paths

Diff

Modified: trunk/Source/WebKit/blackberry/Api/BackingStore.cpp (128765 => 128766)


--- trunk/Source/WebKit/blackberry/Api/BackingStore.cpp	2012-09-17 15:57:01 UTC (rev 128765)
+++ trunk/Source/WebKit/blackberry/Api/BackingStore.cpp	2012-09-17 16:05:21 UTC (rev 128766)
@@ -360,9 +360,14 @@
     --m_suspendScreenUpdates;
     BlackBerry::Platform::userInterfaceThreadMessageClient()->syncToCurrentMessage();
 
+#if USE(ACCELERATED_COMPOSITING)
+    // This will also blit since we set the OSDS flag above.
+    m_webPage->d->commitRootLayerIfNeeded();
+#else
     // Do some blitting if necessary.
     if ((op == BackingStore::Blit || op == BackingStore::RenderAndBlit) && !shouldDirectRenderingToWindow())
         blitVisibleContents();
+#endif
 }
 
 void BackingStorePrivate::repaint(const Platform::IntRect& windowRect,

Modified: trunk/Source/WebKit/blackberry/ChangeLog (128765 => 128766)


--- trunk/Source/WebKit/blackberry/ChangeLog	2012-09-17 15:57:01 UTC (rev 128765)
+++ trunk/Source/WebKit/blackberry/ChangeLog	2012-09-17 16:05:21 UTC (rev 128766)
@@ -1,3 +1,25 @@
+2012-09-17  Antonio Gomes  <[email protected]>
+
+        [BlackBerry] BackingStorePrivate::resumeScreenAndBackingStoreUpdates more atomic
+        https://bugs.webkit.org/show_bug.cgi?id=96925
+
+        [FullScreen] entering/leaving fullscreen results in temporary glitches on the screen (part 2/3)
+        PR #180866
+
+        Reviewed by Rob Buis.
+        Internally reviewed by Arvid Nilsson.
+
+        Paraphrasing Arvid "resumeBackingStore will be a truly atomic operation.
+        Well more atomic than it was before, with regards to a mix of accelerated and
+        non-accelerated compositing content".
+
+        I.e. by committing the root layer (if needed) when resuming the Backing
+        Store, we call blitVisibleContents right way, so we are actually shortcutting when
+        AC content will get on screen.
+
+        * Api/BackingStore.cpp:
+        (BlackBerry::WebKit::BackingStorePrivate::resumeScreenAndBackingStoreUpdates):
+
 2012-09-17  Peter Wang  <[email protected]>
 
         [BlackBerry] To support "Frames View" of "TimeLine" panel in Inspector
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to