Title: [128842] trunk/Tools
- Revision
- 128842
- Author
- [email protected]
- Date
- 2012-09-17 19:25:35 -0700 (Mon, 17 Sep 2012)
Log Message
nrwt: remove "unexpected EOF" warnings
https://bugs.webkit.org/show_bug.cgi?id=96970
Reviewed by Ojan Vafai.
After debugging this a bit, it looks like there aren't any cases
that I can reproduce where a read() of zero indicates something
actually wrong; either it is a prelude to a crash, or a false
negative. So, I'm removing these warnings and adding a comment.
* Scripts/webkitpy/layout_tests/port/server_process.py:
(ServerProcess._wait_for_data_and_update_buffers_using_select):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (128841 => 128842)
--- trunk/Tools/ChangeLog 2012-09-18 02:17:23 UTC (rev 128841)
+++ trunk/Tools/ChangeLog 2012-09-18 02:25:35 UTC (rev 128842)
@@ -1,5 +1,20 @@
2012-09-17 Dirk Pranke <[email protected]>
+ nrwt: remove "unexpected EOF" warnings
+ https://bugs.webkit.org/show_bug.cgi?id=96970
+
+ Reviewed by Ojan Vafai.
+
+ After debugging this a bit, it looks like there aren't any cases
+ that I can reproduce where a read() of zero indicates something
+ actually wrong; either it is a prelude to a crash, or a false
+ negative. So, I'm removing these warnings and adding a comment.
+
+ * Scripts/webkitpy/layout_tests/port/server_process.py:
+ (ServerProcess._wait_for_data_and_update_buffers_using_select):
+
+2012-09-17 Dirk Pranke <[email protected]>
+
[chromium] ASAN bot is crashing at the end of the run
https://bugs.webkit.org/show_bug.cgi?id=96967
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/server_process.py (128841 => 128842)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/server_process.py 2012-09-18 02:17:23 UTC (rev 128841)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/server_process.py 2012-09-18 02:25:35 UTC (rev 128842)
@@ -228,24 +228,21 @@
raise
try:
+ # Note that we may get no data during read() even though
+ # select says we got something; see the select() man page
+ # on linux. I don't know if this happens on Mac OS and
+ # other Unixen as well, but we don't bother special-casing
+ # Linux because it's relatively harmless either way.
if out_fd in read_fds:
data = ""
- if not data and not stopping:
- if self._treat_no_data_as_crash or self._proc.poll() is not None:
- _log.warning('unexpected EOF of stdout, %s crashed' % self._name)
- self._crashed = True
- else:
- _log.warning('unexpected EOF of stdout, %s is still alive' % self._name)
+ if not data and not stopping and (self._treat_no_data_as_crash or self._proc.poll()):
+ self._crashed = True
self._output += data
if err_fd in read_fds:
data = ""
- if not data and not stopping:
- if self._treat_no_data_as_crash or self._proc.poll() is not None:
- _log.warning('unexpected EOF on stderr, %s crashed' % self._name)
- self._crashed = True
- else:
- _log.warning('unexpected EOF on stderr, %s is still alive' % self._name)
+ if not data and not stopping and (self._treat_no_data_as_crash or self._proc.poll()):
+ self._crashed = True
self._error += data
except IOError, e:
# We can ignore the IOErrors because we will detect if the subporcess crashed
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
