Title: [128850] trunk/Source
- Revision
- 128850
- Author
- [email protected]
- Date
- 2012-09-17 22:08:25 -0700 (Mon, 17 Sep 2012)
Log Message
Export RuntimeEnabledFeatures::isLangAttributeAwareFormControlUIEnabled correctly
https://bugs.webkit.org/show_bug.cgi?id=96855
Reviewed by Hajime Morita.
Source/WebCore:
* bindings/generic/RuntimeEnabledFeatures.h:
(RuntimeEnabledFeatures): Add WEBCORE_TESTING.
* testing/InternalSettings.cpp: Remove a workaround.
(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::setLangAttributeAwareFormControlUIEnabled):
* testing/InternalSettings.h: ditto.
Source/WebKit2:
* win/WebKit2.def: Remove a symbol
* win/WebKit2CFLite.def: ditto.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (128849 => 128850)
--- trunk/Source/WebCore/ChangeLog 2012-09-18 04:50:08 UTC (rev 128849)
+++ trunk/Source/WebCore/ChangeLog 2012-09-18 05:08:25 UTC (rev 128850)
@@ -1,3 +1,18 @@
+2012-09-17 Kent Tamura <[email protected]>
+
+ Export RuntimeEnabledFeatures::isLangAttributeAwareFormControlUIEnabled correctly
+ https://bugs.webkit.org/show_bug.cgi?id=96855
+
+ Reviewed by Hajime Morita.
+
+ * bindings/generic/RuntimeEnabledFeatures.h:
+ (RuntimeEnabledFeatures): Add WEBCORE_TESTING.
+ * testing/InternalSettings.cpp: Remove a workaround.
+ (WebCore::InternalSettings::Backup::Backup):
+ (WebCore::InternalSettings::Backup::restoreTo):
+ (WebCore::InternalSettings::setLangAttributeAwareFormControlUIEnabled):
+ * testing/InternalSettings.h: ditto.
+
2012-09-17 Vivek Galatage <[email protected]>
[Gtk] Remove the unused variable warning in GamepadsGtk.cpp using ASSERT_UNUSED macro
Modified: trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h (128849 => 128850)
--- trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h 2012-09-18 04:50:08 UTC (rev 128849)
+++ trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h 2012-09-18 05:08:25 UTC (rev 128850)
@@ -31,6 +31,8 @@
#ifndef RuntimeEnabledFeatures_h
#define RuntimeEnabledFeatures_h
+#include "PlatformExportMacros.h"
+
namespace WebCore {
// A class that stores static enablers for all experimental features. Note that
@@ -281,7 +283,7 @@
static bool isDeviceOrientationEnabled;
static bool isSpeechInputEnabled;
static bool isCSSExclusionsEnabled;
- static bool isLangAttributeAwareFormControlUIEnabled;
+ WEBCORE_TESTING static bool isLangAttributeAwareFormControlUIEnabled;
#if ENABLE(SCRIPTED_SPEECH)
static bool isScriptedSpeechEnabled;
#endif
Modified: trunk/Source/WebCore/testing/InternalSettings.cpp (128849 => 128850)
--- trunk/Source/WebCore/testing/InternalSettings.cpp 2012-09-18 04:50:08 UTC (rev 128849)
+++ trunk/Source/WebCore/testing/InternalSettings.cpp 2012-09-18 05:08:25 UTC (rev 128850)
@@ -98,10 +98,7 @@
#endif
, m_canStartMedia(page->canStartMedia())
, m_originalMockScrollbarsEnabled(settings->mockScrollbarsEnabled())
-#if ENABLE(INPUT_TYPE_TIME_MULTIPLE_FIELDS)
- // FIXME: This is a workaround for Apple Windows crash.
, m_langAttributeAwareFormControlUIEnabled(RuntimeEnabledFeatures::langAttributeAwareFormControlUIEnabled())
-#endif
, m_imagesEnabled(settings->areImagesEnabled())
{
}
@@ -136,9 +133,7 @@
#endif
page->setCanStartMedia(m_canStartMedia);
settings->setMockScrollbarsEnabled(m_originalMockScrollbarsEnabled);
-#if ENABLE(INPUT_TYPE_TIME_MULTIPLE_FIELDS)
RuntimeEnabledFeatures::setLangAttributeAwareFormControlUIEnabled(m_langAttributeAwareFormControlUIEnabled);
-#endif
settings->setImagesEnabled(m_imagesEnabled);
}
@@ -655,11 +650,7 @@
void InternalSettings::setLangAttributeAwareFormControlUIEnabled(bool enabled)
{
-#if ENABLE(INPUT_TYPE_TIME_MULTIPLE_FIELDS)
RuntimeEnabledFeatures::setLangAttributeAwareFormControlUIEnabled(enabled);
-#else
- UNUSED_PARAM(enabled);
-#endif
}
void InternalSettings::setImagesEnabled(bool enabled, ExceptionCode& ec)
Modified: trunk/Source/WebCore/testing/InternalSettings.h (128849 => 128850)
--- trunk/Source/WebCore/testing/InternalSettings.h 2012-09-18 04:50:08 UTC (rev 128849)
+++ trunk/Source/WebCore/testing/InternalSettings.h 2012-09-18 05:08:25 UTC (rev 128850)
@@ -80,9 +80,7 @@
#endif
bool m_canStartMedia;
bool m_originalMockScrollbarsEnabled;
-#if ENABLE(INPUT_TYPE_TIME_MULTIPLE_FIELDS)
bool m_langAttributeAwareFormControlUIEnabled;
-#endif
bool m_imagesEnabled;
};
Modified: trunk/Source/WebKit2/ChangeLog (128849 => 128850)
--- trunk/Source/WebKit2/ChangeLog 2012-09-18 04:50:08 UTC (rev 128849)
+++ trunk/Source/WebKit2/ChangeLog 2012-09-18 05:08:25 UTC (rev 128850)
@@ -1,3 +1,13 @@
+2012-09-17 Kent Tamura <[email protected]>
+
+ Export RuntimeEnabledFeatures::isLangAttributeAwareFormControlUIEnabled correctly
+ https://bugs.webkit.org/show_bug.cgi?id=96855
+
+ Reviewed by Hajime Morita.
+
+ * win/WebKit2.def: Remove a symbol
+ * win/WebKit2CFLite.def: ditto.
+
2012-09-17 Byungwoo Lee <[email protected]>
[EFL][WK2] Add _javascript_ popup API.
Modified: trunk/Source/WebKit2/win/WebKit2.def (128849 => 128850)
--- trunk/Source/WebKit2/win/WebKit2.def 2012-09-18 04:50:08 UTC (rev 128849)
+++ trunk/Source/WebKit2/win/WebKit2.def 2012-09-18 05:08:25 UTC (rev 128850)
@@ -186,7 +186,6 @@
?instrumentingAgentsForPage@InspectorInstrumentation@WebCore@@CAPAVInstrumentingAgents@2@PAVPage@2@@Z
?isActiveInsertionPoint@WebCore@@YA_NPBVNode@1@@Z
?isCSSExclusionsEnabled@RuntimeEnabledFeatures@WebCore@@0_NA
- ?isLangAttributeAwareFormControlUIEnabled@RuntimeEnabledFeatures@WebCore@@0_NA
?isPreloaded@CachedResourceLoader@WebCore@@QBE_NABVString@WTF@@@Z
?jsArray@WebCore@@YA?AVJSValue@JSC@@PAVExecState@3@PAVJSDOMGlobalObject@1@V?$PassRefPtr@VDOMStringList@WebCore@@@WTF@@@Z
?lastChangeWasUserEdit@HTMLTextFormControlElement@WebCore@@QBE_NXZ
Modified: trunk/Source/WebKit2/win/WebKit2CFLite.def (128849 => 128850)
--- trunk/Source/WebKit2/win/WebKit2CFLite.def 2012-09-18 04:50:08 UTC (rev 128849)
+++ trunk/Source/WebKit2/win/WebKit2CFLite.def 2012-09-18 05:08:25 UTC (rev 128850)
@@ -179,7 +179,6 @@
?instrumentingAgentsForPage@InspectorInstrumentation@WebCore@@CAPAVInstrumentingAgents@2@PAVPage@2@@Z
?isActiveInsertionPoint@WebCore@@YA_NPBVNode@1@@Z
?isCSSExclusionsEnabled@RuntimeEnabledFeatures@WebCore@@0_NA
- ?isLangAttributeAwareFormControlUIEnabled@RuntimeEnabledFeatures@WebCore@@0_NA
?isPreloaded@CachedResourceLoader@WebCore@@QBE_NABVString@WTF@@@Z
?jsArray@WebCore@@YA?AVJSValue@JSC@@PAVExecState@3@PAVJSDOMGlobalObject@1@V?$PassRefPtr@VDOMStringList@WebCore@@@WTF@@@Z
?lastChangeWasUserEdit@HTMLTextFormControlElement@WebCore@@QBE_NXZ
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
