Title: [128854] trunk
- Revision
- 128854
- Author
- [email protected]
- Date
- 2012-09-17 23:56:36 -0700 (Mon, 17 Sep 2012)
Log Message
[GTK] fast/loader/display-image-unset-can-block-image-and-can-reload-in-place.html failing after r128645
https://bugs.webkit.org/show_bug.cgi?id=96899
Reviewed by Martin Robinson.
Tools:
When overriding the 'WebKitDisplayImageKey' preference, use the
'auto-load-images' property of WebKitWebSettings as the property which
should be updated with the corresponding preference value.
* DumpRenderTree/gtk/DumpRenderTree.cpp:
(resetDefaultsToConsistentValues):
* DumpRenderTree/gtk/TestRunnerGtk.cpp:
(TestRunner::overridePreference):
LayoutTests:
Remove failure expectation for the test in title.
* platform/gtk/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (128853 => 128854)
--- trunk/LayoutTests/ChangeLog 2012-09-18 06:45:09 UTC (rev 128853)
+++ trunk/LayoutTests/ChangeLog 2012-09-18 06:56:36 UTC (rev 128854)
@@ -1,3 +1,14 @@
+2012-09-17 Zan Dobersek <[email protected]>
+
+ [GTK] fast/loader/display-image-unset-can-block-image-and-can-reload-in-place.html failing after r128645
+ https://bugs.webkit.org/show_bug.cgi?id=96899
+
+ Reviewed by Martin Robinson.
+
+ Remove failure expectation for the test in title.
+
+ * platform/gtk/TestExpectations:
+
2012-09-17 Shinya Kawanaka <[email protected]>
[Chromium] Unreviewed gardening, mark perf/nested-combined-selectors.html is flaky
Modified: trunk/LayoutTests/platform/gtk/TestExpectations (128853 => 128854)
--- trunk/LayoutTests/platform/gtk/TestExpectations 2012-09-18 06:45:09 UTC (rev 128853)
+++ trunk/LayoutTests/platform/gtk/TestExpectations 2012-09-18 06:56:36 UTC (rev 128854)
@@ -1358,8 +1358,6 @@
BUGWK73003 DEBUG : editing/spelling/spellcheck-paste.html = PASS
BUGWK50740 DEBUG : editing/spelling/spellcheck-queue.html = TEXT
-BUGWK96899 : fast/loader/display-image-unset-can-block-image-and-can-reload-in-place.html = TEXT
-
BUGWK96900 : fast/text/stale-TextLayout-from-first-line.html = IMAGE
//////////////////////////////////////////////////////////////////////////////////////////
Modified: trunk/Tools/ChangeLog (128853 => 128854)
--- trunk/Tools/ChangeLog 2012-09-18 06:45:09 UTC (rev 128853)
+++ trunk/Tools/ChangeLog 2012-09-18 06:56:36 UTC (rev 128854)
@@ -1,3 +1,19 @@
+2012-09-17 Zan Dobersek <[email protected]>
+
+ [GTK] fast/loader/display-image-unset-can-block-image-and-can-reload-in-place.html failing after r128645
+ https://bugs.webkit.org/show_bug.cgi?id=96899
+
+ Reviewed by Martin Robinson.
+
+ When overriding the 'WebKitDisplayImageKey' preference, use the
+ 'auto-load-images' property of WebKitWebSettings as the property which
+ should be updated with the corresponding preference value.
+
+ * DumpRenderTree/gtk/DumpRenderTree.cpp:
+ (resetDefaultsToConsistentValues):
+ * DumpRenderTree/gtk/TestRunnerGtk.cpp:
+ (TestRunner::overridePreference):
+
2012-09-17 Pratik Solanki <[email protected]>
DumpRenderTree and WebKitTestRunner should compile with -Wundef on Mac
Modified: trunk/Tools/DumpRenderTree/gtk/TestRunnerGtk.cpp (128853 => 128854)
--- trunk/Tools/DumpRenderTree/gtk/TestRunnerGtk.cpp 2012-09-18 06:45:09 UTC (rev 128853)
+++ trunk/Tools/DumpRenderTree/gtk/TestRunnerGtk.cpp 2012-09-18 06:56:36 UTC (rev 128854)
@@ -776,6 +776,8 @@
propertyName = "enable-webgl";
else if (g_str_equal(originalName.get(), "WebKitWebAudioEnabled"))
propertyName = "enable-webaudio";
+ else if (g_str_equal(originalName.get(), "WebKitDisplayImagesKey"))
+ propertyName = "auto-load-images";
else if (g_str_equal(originalName.get(), "WebKitTabToLinksPreferenceKey")) {
DumpRenderTreeSupportGtk::setLinksIncludedInFocusChain(booleanFromValue(valueAsString.get()));
return;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
