- Revision
- 128876
- Author
- [email protected]
- Date
- 2012-09-18 05:05:31 -0700 (Tue, 18 Sep 2012)
Log Message
[EFL] Remove background view on EWebLauncher and MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=96905
Patch by Seokju Kwon <[email protected]> on 2012-09-18
Reviewed by Gyuyoung Kim.
The size of webview was changed after adding url bar.
And the background view is not necessary anymore, since it was used for debugging back in the day.
* EWebLauncher/main.c:
(_ELauncher):
(on_ecore_evas_resize):
(browserCreate):
* MiniBrowser/efl/main.c:
(_MiniBrowser):
(on_ecore_evas_resize):
(browserCreate):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (128875 => 128876)
--- trunk/Tools/ChangeLog 2012-09-18 11:41:16 UTC (rev 128875)
+++ trunk/Tools/ChangeLog 2012-09-18 12:05:31 UTC (rev 128876)
@@ -1,3 +1,22 @@
+2012-09-18 Seokju Kwon <[email protected]>
+
+ [EFL] Remove background view on EWebLauncher and MiniBrowser
+ https://bugs.webkit.org/show_bug.cgi?id=96905
+
+ Reviewed by Gyuyoung Kim.
+
+ The size of webview was changed after adding url bar.
+ And the background view is not necessary anymore, since it was used for debugging back in the day.
+
+ * EWebLauncher/main.c:
+ (_ELauncher):
+ (on_ecore_evas_resize):
+ (browserCreate):
+ * MiniBrowser/efl/main.c:
+ (_MiniBrowser):
+ (on_ecore_evas_resize):
+ (browserCreate):
+
2012-09-18 Sergio Villar Senin <[email protected]>
[GTK] run-webkit-tests unable to find TestExpectations for WK2
Modified: trunk/Tools/EWebLauncher/main.c (128875 => 128876)
--- trunk/Tools/EWebLauncher/main.c 2012-09-18 11:41:16 UTC (rev 128875)
+++ trunk/Tools/EWebLauncher/main.c 2012-09-18 12:05:31 UTC (rev 128876)
@@ -155,7 +155,6 @@
typedef struct _ELauncher {
Ecore_Evas *ee;
Evas *evas;
- Evas_Object *bg;
Evas_Object *browser;
Url_Bar *url_bar;
User_Arguments *userArgs;
@@ -242,7 +241,6 @@
{
ELauncher *app;
Evas_Object *webview;
- Evas_Object *bg;
int w, h;
ecore_evas_geometry_get(ee, NULL, NULL, &w, &h);
@@ -251,10 +249,6 @@
app = find_app_from_ee(ee);
url_bar_width_set(app->url_bar, w);
- bg = evas_object_name_find(ecore_evas_get(ee), "bg");
- evas_object_move(bg, 0, 0);
- evas_object_resize(bg, w, h);
-
webview = evas_object_name_find(ecore_evas_get(ee), "browser");
evas_object_move(webview, 0, URL_BAR_HEIGHT);
evas_object_resize(webview, w, h - URL_BAR_HEIGHT);
@@ -691,14 +685,6 @@
if (!app->evas)
return quit(EINA_FALSE, "ERROR: could not get evas from evas-ecore\n");
- app->bg = evas_object_rectangle_add(app->evas);
- evas_object_name_set(app->bg, "bg");
- evas_object_color_set(app->bg, 255, 0, 255, 255);
- evas_object_move(app->bg, 0, 0);
- evas_object_resize(app->bg, geometry.w, geometry.h);
- evas_object_layer_set(app->bg, EVAS_LAYER_MIN);
- evas_object_show(app->bg);
-
if (userArgs->backingStore && !strcasecmp(userArgs->backingStore, "tiled")) {
app->browser = ewk_view_tiled_add(app->evas);
info("backing store: tiled\n");
Modified: trunk/Tools/MiniBrowser/efl/main.c (128875 => 128876)
--- trunk/Tools/MiniBrowser/efl/main.c 2012-09-18 11:41:16 UTC (rev 128875)
+++ trunk/Tools/MiniBrowser/efl/main.c 2012-09-18 12:05:31 UTC (rev 128876)
@@ -41,7 +41,6 @@
typedef struct _MiniBrowser {
Ecore_Evas *ee;
Evas *evas;
- Evas_Object *bg;
Evas_Object *browser;
Url_Bar *url_bar;
} MiniBrowser;
@@ -85,7 +84,6 @@
static void on_ecore_evas_resize(Ecore_Evas *ee)
{
Evas_Object *webview;
- Evas_Object *bg;
int w, h;
ecore_evas_geometry_get(ee, NULL, NULL, &w, &h);
@@ -93,10 +91,6 @@
/* Resize URL bar */
url_bar_width_set(browser->url_bar, w);
- bg = evas_object_name_find(ecore_evas_get(ee), "bg");
- evas_object_move(bg, 0, 0);
- evas_object_resize(bg, w, h);
-
webview = evas_object_name_find(ecore_evas_get(ee), "browser");
evas_object_move(webview, 0, URL_BAR_HEIGHT);
evas_object_resize(webview, w, h - URL_BAR_HEIGHT);
@@ -233,15 +227,6 @@
app->evas = ecore_evas_get(app->ee);
- app->bg = evas_object_rectangle_add(app->evas);
- evas_object_name_set(app->bg, "bg");
- evas_object_size_hint_weight_set(app->bg, EVAS_HINT_EXPAND, EVAS_HINT_EXPAND);
-
- evas_object_move(app->bg, 0, 0);
- evas_object_resize(app->bg, DEFAULT_WIDTH, DEFAULT_HEIGHT);
- evas_object_color_set(app->bg, 255, 150, 150, 255);
- evas_object_show(app->bg);
-
/* Create webview */
app->browser = ewk_view_add(app->evas);
ewk_view_theme_set(app->browser, THEME_DIR"/default.edj");
