Title: [128880] trunk
- Revision
- 128880
- Author
- [email protected]
- Date
- 2012-09-18 05:55:04 -0700 (Tue, 18 Sep 2012)
Log Message
[EFL] min-device-width failures in media tests
https://bugs.webkit.org/show_bug.cgi?id=96920
Patch by Christophe Dumez <[email protected]> on 2012-09-18
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
Return a realistic value (800x600) for screen resolution if
it cannot be detected, instead of returning (0x0).
This allows for some tests to pass on the build bots
where X is not running.
No new tests, already covered by existing tests.
* platform/efl/PlatformScreenEfl.cpp:
(WebCore::screenRect):
LayoutTests:
Unskip several test cases which should pass on the
build bots now that we return a realistic screen
resolution whenever it cannot be detected.
* platform/efl/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (128879 => 128880)
--- trunk/LayoutTests/ChangeLog 2012-09-18 12:51:30 UTC (rev 128879)
+++ trunk/LayoutTests/ChangeLog 2012-09-18 12:55:04 UTC (rev 128880)
@@ -1,5 +1,18 @@
2012-09-18 Christophe Dumez <[email protected]>
+ [EFL] min-device-width failures in media tests
+ https://bugs.webkit.org/show_bug.cgi?id=96920
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ Unskip several test cases which should pass on the
+ build bots now that we return a realistic screen
+ resolution whenever it cannot be detected.
+
+ * platform/efl/TestExpectations:
+
+2012-09-18 Christophe Dumez <[email protected]>
+
[EFL][WK2] Clarify TestExpectations file
https://bugs.webkit.org/show_bug.cgi?id=97003
Modified: trunk/LayoutTests/platform/efl/TestExpectations (128879 => 128880)
--- trunk/LayoutTests/platform/efl/TestExpectations 2012-09-18 12:51:30 UTC (rev 128879)
+++ trunk/LayoutTests/platform/efl/TestExpectations 2012-09-18 12:55:04 UTC (rev 128880)
@@ -1008,18 +1008,6 @@
BUGWK94880 : fast/forms/search-cancel-button-style-sharing.html = MISSING
BUGWK94880 : fast/forms/search-rtl.html = MISSING
-// New windows are created with wrong size
-BUGWK53959 : fast/dom/Window/window-resize.html = TEXT
-BUGWK53959 : fast/dom/Window/window-resize-and-move-arguments.html = TEXT
-
-// min-device-width value is incorrect
-BUGWK96920 : fast/media/invalid-lengths.html = TEXT
-BUGWK96920 : fast/media/matchmedium-query-api.html= TEXT
-BUGWK96920 : fast/media/media-query-list-01.html = TEXT
-
-// video.currentSrc is an empty string
-BUGWK96922 : media/video-source-media.html = TEXT
-
// Asserts in MessagePort::contextDestroyed, but the assert usually gets attributed to later tests.
BUGWK94458 SKIP : fast/events/message-port-constructor-for-deleted-document.html = PASS
Modified: trunk/Source/WebCore/ChangeLog (128879 => 128880)
--- trunk/Source/WebCore/ChangeLog 2012-09-18 12:51:30 UTC (rev 128879)
+++ trunk/Source/WebCore/ChangeLog 2012-09-18 12:55:04 UTC (rev 128880)
@@ -1,3 +1,21 @@
+2012-09-18 Christophe Dumez <[email protected]>
+
+ [EFL] min-device-width failures in media tests
+ https://bugs.webkit.org/show_bug.cgi?id=96920
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ Return a realistic value (800x600) for screen resolution if
+ it cannot be detected, instead of returning (0x0).
+
+ This allows for some tests to pass on the build bots
+ where X is not running.
+
+ No new tests, already covered by existing tests.
+
+ * platform/efl/PlatformScreenEfl.cpp:
+ (WebCore::screenRect):
+
2012-09-18 Simon Hausmann <[email protected]>
Fix compilation with Qt 5 on MeeGo 1.2 Harmattan
Modified: trunk/Source/WebCore/platform/efl/PlatformScreenEfl.cpp (128879 => 128880)
--- trunk/Source/WebCore/platform/efl/PlatformScreenEfl.cpp 2012-09-18 12:51:30 UTC (rev 128879)
+++ trunk/Source/WebCore/platform/efl/PlatformScreenEfl.cpp 2012-09-18 12:55:04 UTC (rev 128880)
@@ -114,7 +114,10 @@
FloatRect screenRect(Widget* widget)
{
#ifdef HAVE_ECORE_X
- int width = 0, height = 0;
+ // Fallback to realistic values if the EcoreX call fails
+ // and we cannot accurately detect the screen size.
+ int width = 800;
+ int height = 600;
CALL_WITH_ECORE_X(ecore_x_screen_size_get(screen, &width, &height));
UNUSED_PARAM(widget);
return FloatRect(0, 0, width, height);
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
