Title: [128928] trunk/Source/_javascript_Core
- Revision
- 128928
- Author
- [email protected]
- Date
- 2012-09-18 14:17:43 -0700 (Tue, 18 Sep 2012)
Log Message
REGRESSION(r128802): It made some JS tests crash
https://bugs.webkit.org/show_bug.cgi?id=97001
Reviewed by Mark Hahnenberg.
IndexingHeaderInlineMethods was incorrectly assuming that if the HasArrayStorage bit is clear, then that means that indexing payload capacity is zero.
* runtime/IndexingHeaderInlineMethods.h:
(JSC::IndexingHeader::preCapacity):
(JSC::IndexingHeader::indexingPayloadSizeInBytes):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (128927 => 128928)
--- trunk/Source/_javascript_Core/ChangeLog 2012-09-18 20:40:56 UTC (rev 128927)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-09-18 21:17:43 UTC (rev 128928)
@@ -1,3 +1,16 @@
+2012-09-18 Filip Pizlo <[email protected]>
+
+ REGRESSION(r128802): It made some JS tests crash
+ https://bugs.webkit.org/show_bug.cgi?id=97001
+
+ Reviewed by Mark Hahnenberg.
+
+ IndexingHeaderInlineMethods was incorrectly assuming that if the HasArrayStorage bit is clear, then that means that indexing payload capacity is zero.
+
+ * runtime/IndexingHeaderInlineMethods.h:
+ (JSC::IndexingHeader::preCapacity):
+ (JSC::IndexingHeader::indexingPayloadSizeInBytes):
+
2012-09-18 Mark Hahnenberg <[email protected]>
Use WTF::HasTrivialDestructor instead of compiler-specific versions in JSC::NeedsDestructor
Modified: trunk/Source/_javascript_Core/runtime/IndexingHeaderInlineMethods.h (128927 => 128928)
--- trunk/Source/_javascript_Core/runtime/IndexingHeaderInlineMethods.h 2012-09-18 20:40:56 UTC (rev 128927)
+++ trunk/Source/_javascript_Core/runtime/IndexingHeaderInlineMethods.h 2012-09-18 21:17:43 UTC (rev 128928)
@@ -34,7 +34,7 @@
inline size_t IndexingHeader::preCapacity(Structure* structure)
{
- if (LIKELY(!(structure->indexingType() & HasArrayStorage)))
+ if (LIKELY(!hasArrayStorage(structure->indexingType())))
return 0;
return arrayStorage()->m_indexBias;
@@ -42,7 +42,7 @@
inline size_t IndexingHeader::indexingPayloadSizeInBytes(Structure* structure)
{
- if (LIKELY(!(structure->indexingType() & HasArrayStorage)))
+ if (LIKELY(!hasArrayStorage(structure->indexingType())))
return 0;
return ArrayStorage::sizeFor(arrayStorage()->vectorLength());
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
