Title: [128996] trunk/Source/WebCore
- Revision
- 128996
- Author
- [email protected]
- Date
- 2012-09-19 07:00:50 -0700 (Wed, 19 Sep 2012)
Log Message
[GTK] REGRESSION(r128907): it broke several WebKit2 API tests
https://bugs.webkit.org/show_bug.cgi?id=97092
Reviewed by Martin Robinson.
Calling resizeLater() from the constructor of
RedirectedXCompositeWindow can cause the callback to be called
later by the main loop after the RedirectedXCompositeWindow object
has been destroyed. Instead of calling resizeLater(), initialize
the usable size to the given initial size.
* platform/gtk/RedirectedXCompositeWindow.cpp:
(WebCore::RedirectedXCompositeWindow::RedirectedXCompositeWindow):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (128995 => 128996)
--- trunk/Source/WebCore/ChangeLog 2012-09-19 13:53:47 UTC (rev 128995)
+++ trunk/Source/WebCore/ChangeLog 2012-09-19 14:00:50 UTC (rev 128996)
@@ -1,3 +1,19 @@
+2012-09-19 Carlos Garcia Campos <[email protected]>
+
+ [GTK] REGRESSION(r128907): it broke several WebKit2 API tests
+ https://bugs.webkit.org/show_bug.cgi?id=97092
+
+ Reviewed by Martin Robinson.
+
+ Calling resizeLater() from the constructor of
+ RedirectedXCompositeWindow can cause the callback to be called
+ later by the main loop after the RedirectedXCompositeWindow object
+ has been destroyed. Instead of calling resizeLater(), initialize
+ the usable size to the given initial size.
+
+ * platform/gtk/RedirectedXCompositeWindow.cpp:
+ (WebCore::RedirectedXCompositeWindow::RedirectedXCompositeWindow):
+
2012-09-19 Vsevolod Vlasov <[email protected]>
Unreviewed follow up Apple Win build fix for r128992.
Modified: trunk/Source/WebCore/platform/gtk/RedirectedXCompositeWindow.cpp (128995 => 128996)
--- trunk/Source/WebCore/platform/gtk/RedirectedXCompositeWindow.cpp 2012-09-19 13:53:47 UTC (rev 128995)
+++ trunk/Source/WebCore/platform/gtk/RedirectedXCompositeWindow.cpp 2012-09-19 14:00:50 UTC (rev 128996)
@@ -44,7 +44,8 @@
}
RedirectedXCompositeWindow::RedirectedXCompositeWindow(const IntSize& size)
- : m_window(0)
+ : m_usableSize(size)
+ , m_window(0)
, m_parentWindow(0)
, m_pixmap(0)
, m_surface(0)
@@ -91,7 +92,6 @@
XCompositeRedirectWindow(display, m_window, CompositeRedirectManual);
resize(size);
- resizeLater(); // Force update of the usable area.
}
RedirectedXCompositeWindow::~RedirectedXCompositeWindow()
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
