Title: [129080] trunk/Tools
- Revision
- 129080
- Author
- [email protected]
- Date
- 2012-09-19 18:13:32 -0700 (Wed, 19 Sep 2012)
Log Message
update flakiness dashboard after cutover to new test expectations syntax
https://bugs.webkit.org/show_bug.cgi?id=97152
Unreviewed, build fix.
Handle (??) the new Bug notations as well. Hopefully we don't
still need the old ones.
* TestResultServer/static-dashboards/flakiness_dashboard.js:
(filterBugs):
(htmlForBugs):
* TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (129079 => 129080)
--- trunk/Tools/ChangeLog 2012-09-20 00:59:24 UTC (rev 129079)
+++ trunk/Tools/ChangeLog 2012-09-20 01:13:32 UTC (rev 129080)
@@ -3,6 +3,21 @@
update flakiness dashboard after cutover to new test expectations syntax
https://bugs.webkit.org/show_bug.cgi?id=97152
+ Unreviewed, build fix.
+
+ Handle (??) the new Bug notations as well. Hopefully we don't
+ still need the old ones.
+
+ * TestResultServer/static-dashboards/flakiness_dashboard.js:
+ (filterBugs):
+ (htmlForBugs):
+ * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
+
+2012-09-19 Dirk Pranke <[email protected]>
+
+ update flakiness dashboard after cutover to new test expectations syntax
+ https://bugs.webkit.org/show_bug.cgi?id=97152
+
Reviewed by Ryosuke Niwa.
This change clones the TestExpectation parsing state machine
Modified: trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.js (129079 => 129080)
--- trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.js 2012-09-20 00:59:24 UTC (rev 129079)
+++ trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.js 2012-09-20 01:13:32 UTC (rev 129080)
@@ -505,7 +505,7 @@
function filterBugs(modifiers)
{
- var bugs = modifiers.match(/\bBUG\S*/g);
+ var bugs = modifiers.match(/\b(Bug|webkit.org|crbug.com|code.google.com)\S*/g);
if (!bugs)
return {bugs: '', modifiers: modifiers};
for (var j = 0; j < bugs.length; j++)
@@ -610,7 +610,7 @@
'Release': 'RELEASE',
'Debug': 'DEBUG',
'Mac': 'MAC',
- 'Win': 'Win',
+ 'Win': 'WIN',
'Linux': 'LINUX',
'SnowLeopard': 'SNOWLEOPARD',
'Lion': 'LION',
@@ -980,12 +980,10 @@
function htmlForBugs(bugs)
{
- bugs = bugs.replace(/BUG(CR)?(\d{4})(\ |$)/g, EXTERNAL_BUG_REPLACE_VALUE);
- bugs = bugs.replace(/BUG(CR)?(\d{5})(\ |$)/g, EXTERNAL_BUG_REPLACE_VALUE);
- bugs = bugs.replace(/BUG(CR)?(1\d{5})(\ |$)/g, EXTERNAL_BUG_REPLACE_VALUE);
- bugs = bugs.replace(/BUG(CR)?([2-9]\d{5})(\ |$)/g, INTERNAL_BUG_REPLACE_VALUE);
- bugs = bugs.replace(/BUG(CR)?(\d{7})(\ |$)/g, INTERNAL_BUG_REPLACE_VALUE);
- bugs = bugs.replace(/BUG(WK)(\d{5}\d*?)(\ |$)/g, WEBKIT_BUG_REPLACE_VALUE);
+ // FIXME: do we still need the INTERNAL_BUG replacements? They're
+ // broken temporarily.
+ bugs = bugs.replace(/crbug.com\/(\d+)(\ |$)/g, EXTERNAL_BUG_REPLACE_VALUE);
+ bugs = bugs.replace(/webkit.org\/b\/(\d{5}\d*?)(\ |$)/g, WEBKIT_BUG_REPLACE_VALUE);
return bugs;
}
Modified: trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard_unittests.js (129079 => 129080)
--- trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard_unittests.js 2012-09-20 00:59:24 UTC (rev 129079)
+++ trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard_unittests.js 2012-09-20 01:13:32 UTC (rev 129080)
@@ -197,12 +197,12 @@
});
test('filterBugs',4, function() {
- var filtered = filterBugs('SKIP BUG123 BUGCR123 BUGWK123 SLOW BUG_TONY DEBUG')
- equal(filtered.modifiers, 'SKIP SLOW DEBUG');
- equal(filtered.bugs, 'BUG123 BUGCR123 BUGWK123 BUG_TONY');
+ var filtered = filterBugs('Skip crbug.com/123 webkit.org/b/123 Slow Bug(Tony) Debug')
+ equal(filtered.modifiers, 'Skip Slow Debug');
+ equal(filtered.bugs, 'crbug.com/123 webkit.org/b/123 Bug(Tony)');
- filtered = filterBugs('SKIP SLOW DEBUG')
- equal(filtered.modifiers, 'SKIP SLOW DEBUG');
+ filtered = filterBugs('Skip Slow Debug')
+ equal(filtered.modifiers, 'Skip Slow Debug');
equal(filtered.bugs, '');
});
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
