Title: [129084] trunk/Source/WebCore
- Revision
- 129084
- Author
- [email protected]
- Date
- 2012-09-19 19:05:05 -0700 (Wed, 19 Sep 2012)
Log Message
[BlackBerry] Get infinite amount of requests after attempting re-authentication basic.
https://bugs.webkit.org/show_bug.cgi?id=96994
Reviewed by Rob Buis.
We should remove the wrong credentials before calling sendRequestWithCredentials again.
#PR 200226
Reviewed internally by Jonathan Dong.
No new tests. It is covered by ManualTests/blackberry/http-auth-challenge.html.
* platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::notifyAuthReceived):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (129083 => 129084)
--- trunk/Source/WebCore/ChangeLog 2012-09-20 01:52:02 UTC (rev 129083)
+++ trunk/Source/WebCore/ChangeLog 2012-09-20 02:05:05 UTC (rev 129084)
@@ -1,3 +1,20 @@
+2012-09-19 Jason Liu <[email protected]>
+
+ [BlackBerry] Get infinite amount of requests after attempting re-authentication basic.
+ https://bugs.webkit.org/show_bug.cgi?id=96994
+
+ Reviewed by Rob Buis.
+
+ We should remove the wrong credentials before calling sendRequestWithCredentials again.
+ #PR 200226
+ Reviewed internally by Jonathan Dong.
+
+ No new tests. It is covered by ManualTests/blackberry/http-auth-challenge.html.
+
+
+ * platform/network/blackberry/NetworkJob.cpp:
+ (WebCore::NetworkJob::notifyAuthReceived):
+
2012-09-19 Adam Barth <[email protected]>
Remove Blob.webkitSlice
Modified: trunk/Source/WebCore/platform/network/blackberry/NetworkJob.cpp (129083 => 129084)
--- trunk/Source/WebCore/platform/network/blackberry/NetworkJob.cpp 2012-09-20 01:52:02 UTC (rev 129083)
+++ trunk/Source/WebCore/platform/network/blackberry/NetworkJob.cpp 2012-09-20 02:05:05 UTC (rev 129084)
@@ -294,9 +294,10 @@
}
storeCredentials();
return;
- } else if (serverType != ProtectionSpaceProxyHTTP)
- // If a wifi proxy auth failed, there is no point of trying anymore because the credentials are wrong.
+ } else {
+ purgeCredentials();
m_newJobWithCredentialsStarted = sendRequestWithCredentials(serverType, scheme, realm, requireCredentials);
+ }
}
void NetworkJob::notifyStringHeaderReceived(const String& key, const String& value)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
