Title: [129110] trunk
- Revision
- 129110
- Author
- [email protected]
- Date
- 2012-09-20 03:16:35 -0700 (Thu, 20 Sep 2012)
Log Message
[EFL][DRT]DumpRenderTree needs to reset focus state when test starts.
https://bugs.webkit.org/show_bug.cgi?id=97087
Patch by Michał Pakuła vel Rutka <[email protected]> on 2012-09-20
Reviewed by Gyuyoung Kim.
Tools:
Add focusing a main frame on settings reset.
After editing/undo/undo-iframe-location-change was executed a frame
was left in unfocused state. This caused flakiness in two tests results.
* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::resetDefaultsToConsistentValues):
LayoutTests:
Remove two flaky tests from TestExpectations as they pass after setting focus
on settings reset.
* platform/efl-wk1/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (129109 => 129110)
--- trunk/LayoutTests/ChangeLog 2012-09-20 08:47:53 UTC (rev 129109)
+++ trunk/LayoutTests/ChangeLog 2012-09-20 10:16:35 UTC (rev 129110)
@@ -1,3 +1,15 @@
+2012-09-20 Michał Pakuła vel Rutka <[email protected]>
+
+ [EFL][DRT]DumpRenderTree needs to reset focus state when test starts.
+ https://bugs.webkit.org/show_bug.cgi?id=97087
+
+ Reviewed by Gyuyoung Kim.
+
+ Remove two flaky tests from TestExpectations as they pass after setting focus
+ on settings reset.
+
+ * platform/efl-wk1/TestExpectations:
+
2012-09-20 Mikhail Pozdnyakov <[email protected]>
[EFL] Rebaseline after r129074
Modified: trunk/LayoutTests/platform/efl-wk1/TestExpectations (129109 => 129110)
--- trunk/LayoutTests/platform/efl-wk1/TestExpectations 2012-09-20 08:47:53 UTC (rev 129109)
+++ trunk/LayoutTests/platform/efl-wk1/TestExpectations 2012-09-20 10:16:35 UTC (rev 129110)
@@ -38,9 +38,6 @@
#////////////////////////////////////////////////////////////////////////////////////////
# Test passes, but editing delegates does not match expected ones
-Bug(EFL) editing/undo/undo-indent.html [ Failure Pass ]
-Bug(EFL) editing/undo/undo-misspellings.html [ Failure Pass ]
-
webkit.org/b/96641 media/video-seek-past-end-playing.html [ Failure Pass ]
webkit.org/b/96642 loader/go-back-to-different-window-size.html [ Failure Pass ]
Modified: trunk/Tools/ChangeLog (129109 => 129110)
--- trunk/Tools/ChangeLog 2012-09-20 08:47:53 UTC (rev 129109)
+++ trunk/Tools/ChangeLog 2012-09-20 10:16:35 UTC (rev 129110)
@@ -1,3 +1,17 @@
+2012-09-20 Michał Pakuła vel Rutka <[email protected]>
+
+ [EFL][DRT]DumpRenderTree needs to reset focus state when test starts.
+ https://bugs.webkit.org/show_bug.cgi?id=97087
+
+ Reviewed by Gyuyoung Kim.
+
+ Add focusing a main frame on settings reset.
+ After editing/undo/undo-iframe-location-change was executed a frame
+ was left in unfocused state. This caused flakiness in two tests results.
+
+ * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
+ (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
+
2012-09-20 Allan Sandfeld Jensen <[email protected]>
[Qt] Add eventSender.gestureTap
Modified: trunk/Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp (129109 => 129110)
--- trunk/Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp 2012-09-20 08:47:53 UTC (rev 129109)
+++ trunk/Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp 2012-09-20 10:16:35 UTC (rev 129110)
@@ -292,6 +292,8 @@
ewk_history_clear(ewk_view_history_get(mainView()));
+ ewk_frame_feed_focus_in(mainFrame());
+
ewk_cookies_clear();
ewk_cookies_policy_set(EWK_COOKIE_JAR_ACCEPT_NO_THIRD_PARTY);
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
