Title: [129112] trunk/Source/WebKit/blackberry
Revision
129112
Author
[email protected]
Date
2012-09-20 03:38:45 -0700 (Thu, 20 Sep 2012)

Log Message

[BlackBerry] To support "Frames View" of "TimeLine" panel  in Inspector
https://bugs.webkit.org/show_bug.cgi?id=96077

Patch by Peter Wang <[email protected]> on 2012-09-20
Reviewed by Pavel Feldman.

A minor modification to make the inspecting results more accurate.
Internally reviewd by Arvid, Robin.C, and Konrad.

* Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::renderJob):
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::rootLayerCommitTimerFired):
* WebKitSupport/RenderQueue.cpp:
(BlackBerry::WebKit::RenderQueue::render):

Modified Paths

Diff

Modified: trunk/Source/WebKit/blackberry/Api/BackingStore.cpp (129111 => 129112)


--- trunk/Source/WebKit/blackberry/Api/BackingStore.cpp	2012-09-20 10:27:23 UTC (rev 129111)
+++ trunk/Source/WebKit/blackberry/Api/BackingStore.cpp	2012-09-20 10:38:45 UTC (rev 129112)
@@ -533,6 +533,8 @@
     if (!shouldPerformRenderJobs())
         return;
 
+    instrumentBeginFrame();
+
 #if DEBUG_BACKINGSTORE
     BlackBerry::Platform::logAlways(BlackBerry::Platform::LogLevelCritical, "BackingStorePrivate::renderJob");
 #endif

Modified: trunk/Source/WebKit/blackberry/Api/WebPage.cpp (129111 => 129112)


--- trunk/Source/WebKit/blackberry/Api/WebPage.cpp	2012-09-20 10:27:23 UTC (rev 129111)
+++ trunk/Source/WebKit/blackberry/Api/WebPage.cpp	2012-09-20 10:38:45 UTC (rev 129112)
@@ -5673,6 +5673,8 @@
     Platform::log(Platform::LogLevelCritical, "%s", WTF_PRETTY_FUNCTION);
 #endif
 
+    m_backingStore->d->instrumentBeginFrame();
+
     // The commit timer may have fired just before the layout timer, or for some
     // other reason we need layout. It's not allowed to commit when a layout is
     // pending, becaues a commit can cause parts of the web page to be rendered

Modified: trunk/Source/WebKit/blackberry/ChangeLog (129111 => 129112)


--- trunk/Source/WebKit/blackberry/ChangeLog	2012-09-20 10:27:23 UTC (rev 129111)
+++ trunk/Source/WebKit/blackberry/ChangeLog	2012-09-20 10:38:45 UTC (rev 129112)
@@ -1,3 +1,20 @@
+2012-09-20  Peter Wang  <[email protected]>
+
+        [BlackBerry] To support "Frames View" of "TimeLine" panel  in Inspector
+        https://bugs.webkit.org/show_bug.cgi?id=96077
+
+        Reviewed by Pavel Feldman.
+
+        A minor modification to make the inspecting results more accurate.
+        Internally reviewd by Arvid, Robin.C, and Konrad.
+
+        * Api/BackingStore.cpp:
+        (BlackBerry::WebKit::BackingStorePrivate::renderJob):
+        * Api/WebPage.cpp:
+        (BlackBerry::WebKit::WebPagePrivate::rootLayerCommitTimerFired):
+        * WebKitSupport/RenderQueue.cpp:
+        (BlackBerry::WebKit::RenderQueue::render):
+
 2012-09-19  Sean Wang  <[email protected]>
 
         [BlackBerry] Basic authentication challenge credentials for stored credentials again after restarting browser

Modified: trunk/Source/WebKit/blackberry/WebKitSupport/RenderQueue.cpp (129111 => 129112)


--- trunk/Source/WebKit/blackberry/WebKitSupport/RenderQueue.cpp	2012-09-20 10:27:23 UTC (rev 129111)
+++ trunk/Source/WebKit/blackberry/WebKitSupport/RenderQueue.cpp	2012-09-20 10:38:45 UTC (rev 129112)
@@ -564,8 +564,6 @@
     double time = WTF::currentTime();
 #endif
 
-    m_parent->instrumentBeginFrame();
-
     m_parent->requestLayoutIfNeeded();
 
 #if DEBUG_RENDER_QUEUE
@@ -586,8 +584,6 @@
             renderRegularRenderJob();
     } else if (!m_nonVisibleScrollJobs.empty())
         renderNonVisibleScrollJob();
-
-    m_parent->instrumentCancelFrame();
 }
 
 void RenderQueue::renderAllCurrentRegularRenderJobs()
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to