Title: [129118] trunk
- Revision
- 129118
- Author
- [email protected]
- Date
- 2012-09-20 04:34:33 -0700 (Thu, 20 Sep 2012)
Log Message
Web Inspector: Cookie info in Network Resources Cookies tab are incorrect
https://bugs.webkit.org/show_bug.cgi?id=95491
Patch by Otto Derek Cheung <[email protected]> on 2012-09-20
Reviewed by Vsevolod Vlasov.
Source/WebCore:
Web Inspector: Cookie info in Network Resources Cookies tab are incorrect
https://bugs.webkit.org/show_bug.cgi?id=95491
Fixing a typo that causes cookies to appear as a "Session"
cookie in the Networking panel because it can never find a properly named
"expired" header.
This bug exposes another bug where the cookie GMT strings are inproperly
parsed, causing an "invalid date" error to show up in the cookies tab in
the Networking panel.
Also changed test expectations in LayoutTests/inspector/cookie-parser-expected.txt
* inspector/front-end/CookieParser.js:
(WebInspector.Cookie.prototype.get session):
LayoutTests:
Changed test expectation. If a cookie has an expired value, session should
return false.
* inspector/cookie-parser-expected.txt:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (129117 => 129118)
--- trunk/LayoutTests/ChangeLog 2012-09-20 11:22:02 UTC (rev 129117)
+++ trunk/LayoutTests/ChangeLog 2012-09-20 11:34:33 UTC (rev 129118)
@@ -1,3 +1,15 @@
+2012-09-20 Otto Derek Cheung <[email protected]>
+
+ Web Inspector: Cookie info in Network Resources Cookies tab are incorrect
+ https://bugs.webkit.org/show_bug.cgi?id=95491
+
+ Reviewed by Vsevolod Vlasov.
+
+ Changed test expectation. If a cookie has an expired value, session should
+ return false.
+
+ * inspector/cookie-parser-expected.txt:
+
2012-09-20 Mikhail Pozdnyakov <[email protected]>
[EFL][WK2] Unskip fast/frames/flattening/iframe-tiny.html
Modified: trunk/LayoutTests/inspector/cookie-parser-expected.txt (129117 => 129118)
--- trunk/LayoutTests/inspector/cookie-parser-expected.txt 2012-09-20 11:22:02 UTC (rev 129117)
+++ trunk/LayoutTests/inspector/cookie-parser-expected.txt 2012-09-20 11:34:33 UTC (rev 129118)
@@ -102,7 +102,7 @@
}
source: cooke1 = value; expires = Mon, Oct 18 2010 17:00 GMT+0000; Domain =.example.com
Cookie2 = value2; Path = /foo; DOMAIN = foo.example.com; HttpOnly; Secure; Discard;
-name: cooke1, value: value, httpOnly: false, secure: false, session: true, path: undefined, domain: .example.com, port: undefined, expires: 1287421200000, size: 82
+name: cooke1, value: value, httpOnly: false, secure: false, session: false, path: undefined, domain: .example.com, port: undefined, expires: 1287421200000, size: 82
{
domain : ".example.com"
expires : "Mon, Oct 18 2010 17:00 GMT+0000"
Modified: trunk/Source/WebCore/ChangeLog (129117 => 129118)
--- trunk/Source/WebCore/ChangeLog 2012-09-20 11:22:02 UTC (rev 129117)
+++ trunk/Source/WebCore/ChangeLog 2012-09-20 11:34:33 UTC (rev 129118)
@@ -1,3 +1,26 @@
+2012-09-20 Otto Derek Cheung <[email protected]>
+
+ Web Inspector: Cookie info in Network Resources Cookies tab are incorrect
+ https://bugs.webkit.org/show_bug.cgi?id=95491
+
+ Reviewed by Vsevolod Vlasov.
+
+ Web Inspector: Cookie info in Network Resources Cookies tab are incorrect
+ https://bugs.webkit.org/show_bug.cgi?id=95491
+
+ Fixing a typo that causes cookies to appear as a "Session"
+ cookie in the Networking panel because it can never find a properly named
+ "expired" header.
+
+ This bug exposes another bug where the cookie GMT strings are inproperly
+ parsed, causing an "invalid date" error to show up in the cookies tab in
+ the Networking panel.
+
+ Also changed test expectations in LayoutTests/inspector/cookie-parser-expected.txt
+
+ * inspector/front-end/CookieParser.js:
+ (WebInspector.Cookie.prototype.get session):
+
2012-09-20 Alexander Pavlov <[email protected]>
Web Inspector: [Elements] Word wrap disablement in the DOM tree broken
Modified: trunk/Source/WebCore/inspector/front-end/CookieParser.js (129117 => 129118)
--- trunk/Source/WebCore/inspector/front-end/CookieParser.js 2012-09-20 11:22:02 UTC (rev 129117)
+++ trunk/Source/WebCore/inspector/front-end/CookieParser.js 2012-09-20 11:34:33 UTC (rev 129118)
@@ -231,7 +231,7 @@
{
// RFC 2965 suggests using Discard attribute to mark session cookies, but this does not seem to be widely used.
// Check for absence of explicity max-age or expiry date instead.
- return !("expries" in this._attributes || "max-age" in this._attributes);
+ return !("expires" in this._attributes || "max-age" in this._attributes);
},
/**
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
