- Revision
- 129120
- Author
- [email protected]
- Date
- 2012-09-20 05:05:56 -0700 (Thu, 20 Sep 2012)
Log Message
[Qt] [WK1] Spaces missing in output of fast/forms/mailto/advanced-{get,put}.html
https://bugs.webkit.org/show_bug.cgi?id=92551
Patch by Marcelo Lira <[email protected]> on 2012-09-20
Reviewed by Adam Barth.
The problem here is that the text input boxes are rendered differently
in chromium and qt/gtk/efl, causing the text dump to also differ.
There are 4 adjacent input boxes in a page 800 pixel wide, the width
of these inputs is unspecified, as it should since this is unrelated
to purpose of the test, and left for the port to decide. Chromium puts
the four in the same line, qt/gtk/efl breaks the line before the fourth
input, causing an extra space to appear in the text dump.
The test was corrected by defining a fixed width for the input
elements, ensuring the text dumps will be identical in all platforms,
eliminating the need for special expected files.
* fast/forms/mailto/advanced-get.html:
* fast/forms/mailto/advanced-put.html:
* platform/efl/fast/forms/mailto/advanced-get-expected.txt: Removed.
* platform/efl/fast/forms/mailto/advanced-put-expected.txt: Removed.
* platform/gtk/fast/forms/mailto/advanced-get-expected.txt: Removed.
* platform/gtk/fast/forms/mailto/advanced-put-expected.txt: Removed.
* platform/qt-5.0-wk1/Skipped:
* platform/qt-5.0-wk2/fast/forms/mailto/advanced-get-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/forms/mailto/advanced-put-expected.txt: Removed.
* platform/qt-mac/Skipped:
Modified Paths
Removed Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (129119 => 129120)
--- trunk/LayoutTests/ChangeLog 2012-09-20 11:58:44 UTC (rev 129119)
+++ trunk/LayoutTests/ChangeLog 2012-09-20 12:05:56 UTC (rev 129120)
@@ -1,3 +1,34 @@
+2012-09-20 Marcelo Lira <[email protected]>
+
+ [Qt] [WK1] Spaces missing in output of fast/forms/mailto/advanced-{get,put}.html
+ https://bugs.webkit.org/show_bug.cgi?id=92551
+
+ Reviewed by Adam Barth.
+
+ The problem here is that the text input boxes are rendered differently
+ in chromium and qt/gtk/efl, causing the text dump to also differ.
+
+ There are 4 adjacent input boxes in a page 800 pixel wide, the width
+ of these inputs is unspecified, as it should since this is unrelated
+ to purpose of the test, and left for the port to decide. Chromium puts
+ the four in the same line, qt/gtk/efl breaks the line before the fourth
+ input, causing an extra space to appear in the text dump.
+
+ The test was corrected by defining a fixed width for the input
+ elements, ensuring the text dumps will be identical in all platforms,
+ eliminating the need for special expected files.
+
+ * fast/forms/mailto/advanced-get.html:
+ * fast/forms/mailto/advanced-put.html:
+ * platform/efl/fast/forms/mailto/advanced-get-expected.txt: Removed.
+ * platform/efl/fast/forms/mailto/advanced-put-expected.txt: Removed.
+ * platform/gtk/fast/forms/mailto/advanced-get-expected.txt: Removed.
+ * platform/gtk/fast/forms/mailto/advanced-put-expected.txt: Removed.
+ * platform/qt-5.0-wk1/Skipped:
+ * platform/qt-5.0-wk2/fast/forms/mailto/advanced-get-expected.txt: Removed.
+ * platform/qt-5.0-wk2/fast/forms/mailto/advanced-put-expected.txt: Removed.
+ * platform/qt-mac/Skipped:
+
2012-09-20 Otto Derek Cheung <[email protected]>
Web Inspector: Cookie info in Network Resources Cookies tab are incorrect
Modified: trunk/LayoutTests/fast/forms/mailto/advanced-get.html (129119 => 129120)
--- trunk/LayoutTests/fast/forms/mailto/advanced-get.html 2012-09-20 11:58:44 UTC (rev 129119)
+++ trunk/LayoutTests/fast/forms/mailto/advanced-get.html 2012-09-20 12:05:56 UTC (rev 129120)
@@ -11,6 +11,7 @@
}
}
</script>
+ <style>input { width: 100px; } </style>
</head>
<body _onload_="test()">
<p>Press Compose button and check that the created e-mail has correct headers and body.</p>
Modified: trunk/LayoutTests/fast/forms/mailto/advanced-put.html (129119 => 129120)
--- trunk/LayoutTests/fast/forms/mailto/advanced-put.html 2012-09-20 11:58:44 UTC (rev 129119)
+++ trunk/LayoutTests/fast/forms/mailto/advanced-put.html 2012-09-20 12:05:56 UTC (rev 129120)
@@ -11,6 +11,7 @@
}
}
</script>
+ <style>input { width: 100px; } </style>
</head>
<body _onload_="test()">
<p>Press Compose button and check that the created e-mail has correct headers and body.</p>
Deleted: trunk/LayoutTests/platform/efl/fast/forms/mailto/advanced-get-expected.txt (129119 => 129120)
--- trunk/LayoutTests/platform/efl/fast/forms/mailto/advanced-get-expected.txt 2012-09-20 11:58:44 UTC (rev 129119)
+++ trunk/LayoutTests/platform/efl/fast/forms/mailto/advanced-get-expected.txt 2012-09-20 12:05:56 UTC (rev 129120)
@@ -1,4 +0,0 @@
-Policy delegate: attempt to load mailto:?to=to1%40site.com%2Cto2%40site.com%2Cto3%40site.com&cc=cc1%40site.com%2Ccc2%40site.com%2Ccc3%40site.com&bcc=bcc1%40site.com%2Cbcc2%40site.com%2Cbcc3%40site.com&subject=m%26m%3B%3F%3D&body=line1%0D%0Aline2%0D%0Aline3%0D%0Aline4 with navigation type 'form submitted'
-Press Compose button and check that the created e-mail has correct headers and body.
-
-
Deleted: trunk/LayoutTests/platform/efl/fast/forms/mailto/advanced-put-expected.txt (129119 => 129120)
--- trunk/LayoutTests/platform/efl/fast/forms/mailto/advanced-put-expected.txt 2012-09-20 11:58:44 UTC (rev 129119)
+++ trunk/LayoutTests/platform/efl/fast/forms/mailto/advanced-put-expected.txt 2012-09-20 12:05:56 UTC (rev 129120)
@@ -1,4 +0,0 @@
-Policy delegate: attempt to load mailto:?to=to1%40site.com%2Cto2%40site.com%2Cto3%40site.com&cc=cc1%40site.com%2Ccc2%40site.com%2Ccc3%40site.com&bcc=bcc1%40site.com%2Cbcc2%40site.com%2Cbcc3%40site.com&subject=m%26m%3B%3F%3D&body=line1%0D%0Aline2%0D%0Aline3%0D%0Aline4 with navigation type 'form submitted'
-Press Compose button and check that the created e-mail has correct headers and body.
-
-
Deleted: trunk/LayoutTests/platform/gtk/fast/forms/mailto/advanced-get-expected.txt (129119 => 129120)
--- trunk/LayoutTests/platform/gtk/fast/forms/mailto/advanced-get-expected.txt 2012-09-20 11:58:44 UTC (rev 129119)
+++ trunk/LayoutTests/platform/gtk/fast/forms/mailto/advanced-get-expected.txt 2012-09-20 12:05:56 UTC (rev 129120)
@@ -1,4 +0,0 @@
-Policy delegate: attempt to load mailto:?to=to1%40site.com%2Cto2%40site.com%2Cto3%40site.com&cc=cc1%40site.com%2Ccc2%40site.com%2Ccc3%40site.com&bcc=bcc1%40site.com%2Cbcc2%40site.com%2Cbcc3%40site.com&subject=m%26m%3B%3F%3D&body=line1%0D%0Aline2%0D%0Aline3%0D%0Aline4 with navigation type 'form submitted'
-Press Compose button and check that the created e-mail has correct headers and body.
-
-
Deleted: trunk/LayoutTests/platform/gtk/fast/forms/mailto/advanced-put-expected.txt (129119 => 129120)
--- trunk/LayoutTests/platform/gtk/fast/forms/mailto/advanced-put-expected.txt 2012-09-20 11:58:44 UTC (rev 129119)
+++ trunk/LayoutTests/platform/gtk/fast/forms/mailto/advanced-put-expected.txt 2012-09-20 12:05:56 UTC (rev 129120)
@@ -1,4 +0,0 @@
-Policy delegate: attempt to load mailto:?to=to1%40site.com%2Cto2%40site.com%2Cto3%40site.com&cc=cc1%40site.com%2Ccc2%40site.com%2Ccc3%40site.com&bcc=bcc1%40site.com%2Cbcc2%40site.com%2Cbcc3%40site.com&subject=m%26m%3B%3F%3D&body=line1%0D%0Aline2%0D%0Aline3%0D%0Aline4 with navigation type 'form submitted'
-Press Compose button and check that the created e-mail has correct headers and body.
-
-
Modified: trunk/LayoutTests/platform/qt-5.0-wk1/Skipped (129119 => 129120)
--- trunk/LayoutTests/platform/qt-5.0-wk1/Skipped 2012-09-20 11:58:44 UTC (rev 129119)
+++ trunk/LayoutTests/platform/qt-5.0-wk1/Skipped 2012-09-20 12:05:56 UTC (rev 129120)
@@ -45,11 +45,6 @@
fast/table/table-row-style-not-updated.html
fast/table/table-style-not-updated.html
-# [Qt] [WK1] Spaces missing in output of fast/forms/mailto/advanced-{get,put}.html
-# https://bugs.webkit.org/show_bug.cgi?id=92551
-fast/forms/mailto/advanced-get.html
-fast/forms/mailto/advanced-put.html
-
# [Qt] Tests still fail after the update to new fonts
# https://bugs.webkit.org/show_bug.cgi?id=91610
css3/calc/table-calcs.html
Deleted: trunk/LayoutTests/platform/qt-5.0-wk2/fast/forms/mailto/advanced-get-expected.txt (129119 => 129120)
--- trunk/LayoutTests/platform/qt-5.0-wk2/fast/forms/mailto/advanced-get-expected.txt 2012-09-20 11:58:44 UTC (rev 129119)
+++ trunk/LayoutTests/platform/qt-5.0-wk2/fast/forms/mailto/advanced-get-expected.txt 2012-09-20 12:05:56 UTC (rev 129120)
@@ -1,4 +0,0 @@
-Policy delegate: attempt to load mailto:?to=to1%40site.com%2Cto2%40site.com%2Cto3%40site.com&cc=cc1%40site.com%2Ccc2%40site.com%2Ccc3%40site.com&bcc=bcc1%40site.com%2Cbcc2%40site.com%2Cbcc3%40site.com&subject=m%26m%3B%3F%3D&body=line1%0D%0Aline2%0D%0Aline3%0D%0Aline4 with navigation type 'form submitted'
-Press Compose button and check that the created e-mail has correct headers and body.
-
-
Deleted: trunk/LayoutTests/platform/qt-5.0-wk2/fast/forms/mailto/advanced-put-expected.txt (129119 => 129120)
--- trunk/LayoutTests/platform/qt-5.0-wk2/fast/forms/mailto/advanced-put-expected.txt 2012-09-20 11:58:44 UTC (rev 129119)
+++ trunk/LayoutTests/platform/qt-5.0-wk2/fast/forms/mailto/advanced-put-expected.txt 2012-09-20 12:05:56 UTC (rev 129120)
@@ -1,4 +0,0 @@
-Policy delegate: attempt to load mailto:?to=to1%40site.com%2Cto2%40site.com%2Cto3%40site.com&cc=cc1%40site.com%2Ccc2%40site.com%2Ccc3%40site.com&bcc=bcc1%40site.com%2Cbcc2%40site.com%2Cbcc3%40site.com&subject=m%26m%3B%3F%3D&body=line1%0D%0Aline2%0D%0Aline3%0D%0Aline4 with navigation type 'form submitted'
-Press Compose button and check that the created e-mail has correct headers and body.
-
-
Modified: trunk/LayoutTests/platform/qt-mac/Skipped (129119 => 129120)
--- trunk/LayoutTests/platform/qt-mac/Skipped 2012-09-20 11:58:44 UTC (rev 129119)
+++ trunk/LayoutTests/platform/qt-mac/Skipped 2012-09-20 12:05:56 UTC (rev 129120)
@@ -1808,8 +1808,6 @@
fast/forms/textarea-placeholder-set-value.html
fast/forms/textfield-outline.html
fast/forms/textfield-overflow.html
-fast/forms/mailto/advanced-get.html
-fast/forms/mailto/advanced-put.html
fast/forms/range/range-thumb-height-percentage.html
fast/forms/range/thumbslider-crash.html
fast/forms/range/thumbslider-no-parent-slider.html
