Title: [129141] trunk
- Revision
- 129141
- Author
- [email protected]
- Date
- 2012-09-20 10:56:00 -0700 (Thu, 20 Sep 2012)
Log Message
[GTK] ControlsPanel string is not localized in LocalizedStringsGtk
https://bugs.webkit.org/show_bug.cgi?id=96502
Patch by Joanmarie Diggs <[email protected]> on 2012-09-20
Reviewed by Chris Fleizach.
Source/WebCore:
Adds the ControlsPanel string to the strings localized in LocalizedStringsGtk.
Test: platform/gtk/accessibility/media-controls-panel-title.html
* platform/gtk/LocalizedStringsGtk.cpp:
(WebCore::localizedMediaControlElementString):
LayoutTests:
Added a new test to verify that the accessible object associated with the
MediaControlsPanel has the expected accessible name.
* platform/gtk/accessibility/media-controls-panel-title-expected.txt: Added.
* platform/gtk/accessibility/media-controls-panel-title.html: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (129140 => 129141)
--- trunk/LayoutTests/ChangeLog 2012-09-20 17:49:31 UTC (rev 129140)
+++ trunk/LayoutTests/ChangeLog 2012-09-20 17:56:00 UTC (rev 129141)
@@ -1,3 +1,16 @@
+2012-09-20 Joanmarie Diggs <[email protected]>
+
+ [GTK] ControlsPanel string is not localized in LocalizedStringsGtk
+ https://bugs.webkit.org/show_bug.cgi?id=96502
+
+ Reviewed by Chris Fleizach.
+
+ Added a new test to verify that the accessible object associated with the
+ MediaControlsPanel has the expected accessible name.
+
+ * platform/gtk/accessibility/media-controls-panel-title-expected.txt: Added.
+ * platform/gtk/accessibility/media-controls-panel-title.html: Added.
+
2012-09-17 Jon Lee <[email protected]>
Safari 6 notifications' onclick handlers can't call window.open()
Added: trunk/LayoutTests/platform/gtk/accessibility/media-controls-panel-title-expected.txt (0 => 129141)
--- trunk/LayoutTests/platform/gtk/accessibility/media-controls-panel-title-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/gtk/accessibility/media-controls-panel-title-expected.txt 2012-09-20 17:56:00 UTC (rev 129141)
@@ -0,0 +1,13 @@
+This tests that the media controls panel has the correct name and role
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS element.role is 'AXRole: panel'
+PASS element.title is 'AXTitle: '
+PASS element.role is 'AXRole: tool bar'
+PASS element.title is 'AXTitle: media controls'
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/platform/gtk/accessibility/media-controls-panel-title.html (0 => 129141)
--- trunk/LayoutTests/platform/gtk/accessibility/media-controls-panel-title.html (rev 0)
+++ trunk/LayoutTests/platform/gtk/accessibility/media-controls-panel-title.html 2012-09-20 17:56:00 UTC (rev 129141)
@@ -0,0 +1,26 @@
+<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
+<html>
+<head>
+<script src=""
+</head>
+<body id="body">
+<video controls="" autoplay="" name="media" src=""
+<p id="description"></p>
+<div id="console"></div>
+<script>
+description("This tests that the media controls panel has the correct name and role");
+if (window.accessibilityController) {
+ document.getElementById("body").focus();
+ var webArea = accessibilityController.focusedElement;
+ var element = webArea.childAtIndex(0);
+ shouldBe("element.role", "'AXRole: panel'");
+ shouldBe("element.title", "'AXTitle: '");
+ element = element.childAtIndex(0);
+ shouldBe("element.role", "'AXRole: tool bar'");
+ shouldBe("element.title", "'AXTitle: media controls'");
+}
+
+</script>
+<script src=""
+</body>
+</html>
Modified: trunk/Source/WebCore/ChangeLog (129140 => 129141)
--- trunk/Source/WebCore/ChangeLog 2012-09-20 17:49:31 UTC (rev 129140)
+++ trunk/Source/WebCore/ChangeLog 2012-09-20 17:56:00 UTC (rev 129141)
@@ -1,3 +1,17 @@
+2012-09-20 Joanmarie Diggs <[email protected]>
+
+ [GTK] ControlsPanel string is not localized in LocalizedStringsGtk
+ https://bugs.webkit.org/show_bug.cgi?id=96502
+
+ Reviewed by Chris Fleizach.
+
+ Adds the ControlsPanel string to the strings localized in LocalizedStringsGtk.
+
+ Test: platform/gtk/accessibility/media-controls-panel-title.html
+
+ * platform/gtk/LocalizedStringsGtk.cpp:
+ (WebCore::localizedMediaControlElementString):
+
2012-09-20 Julien Chaffraix <[email protected]>
Remove isStartColumn in the border collapsing code
Modified: trunk/Source/WebCore/platform/gtk/LocalizedStringsGtk.cpp (129140 => 129141)
--- trunk/Source/WebCore/platform/gtk/LocalizedStringsGtk.cpp 2012-09-20 17:49:31 UTC (rev 129140)
+++ trunk/Source/WebCore/platform/gtk/LocalizedStringsGtk.cpp 2012-09-20 17:56:00 UTC (rev 129141)
@@ -558,6 +558,8 @@
return String::fromUTF8(_("show closed captions"));
if (name == "HideClosedCaptionsButton")
return String::fromUTF8(_("hide closed captions"));
+ if (name == "ControlsPanel")
+ return String::fromUTF8(_("media controls"));
ASSERT_NOT_REACHED();
return String();
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
