Skip to site navigation (Press enter)

[webkit-changes] [129161] trunk/PerformanceTests

rniwa Thu, 20 Sep 2012 13:34:23 -0700

Title: [129161] trunk/PerformanceTests

Revision: 129161
Author: [email protected]
Date: 2012-09-20 13:35:28 -0700 (Thu, 20 Sep 2012)

Log Message

Results page should show indivisual value
https://bugs.webkit.org/show_bug.cgi?id=97178


Reviewed by Tony Chang.

Show indivisual values instead of statistics (min, max, stdev).

* resources/results-template.html:

Modified Paths

trunk/PerformanceTests/ChangeLog
trunk/PerformanceTests/resources/results-template.html

Diff

Modified: trunk/PerformanceTests/ChangeLog (129160 => 129161)


--- trunk/PerformanceTests/ChangeLog	2012-09-20 20:34:34 UTC (rev 129160)
+++ trunk/PerformanceTests/ChangeLog	2012-09-20 20:35:28 UTC (rev 129161)
@@ -1,5 +1,16 @@
 2012-09-20  Ryosuke Niwa  <[email protected]>
 
+        Results page should show indivisual value
+        https://bugs.webkit.org/show_bug.cgi?id=97178
+
+        Reviewed by Tony Chang.
+
+        Show indivisual values instead of statistics (min, max, stdev).
+
+        * resources/results-template.html:
+
+2012-09-20  Ryosuke Niwa  <[email protected]>
+
         run-perf-tests should record individual value instead of statistics
         https://bugs.webkit.org/show_bug.cgi?id=97155

Modified: trunk/PerformanceTests/resources/results-template.html (129160 => 129161)


--- trunk/PerformanceTests/resources/results-template.html	2012-09-20 20:34:34 UTC (rev 129160)
+++ trunk/PerformanceTests/resources/results-template.html	2012-09-20 20:35:28 UTC (rev 129161)
@@ -146,6 +146,7 @@
 function TestResult(associatedTest, result, associatedRun) {
     this.unit = function () { return result.unit; }
     this.test = function () { return associatedTest; }
+    this.values = function () { return result.values ? result.values.map(function (value) { return associatedTest.scalingFactor() * value; }) : undefined; }
     this.unscaledMean = function () { return result.avg; }
     this.mean = function () { return associatedTest.scalingFactor() * result.avg; }
     this.min = function () { return associatedTest.scalingFactor() * result.min; }
@@ -278,14 +279,24 @@
 function attachPlot(test, plotContainer, minIsZero) {
     var results = test.results();
 
-    function makeSubpoints(id, callback) { return $.extend(true, {}, subpointsPlotOptions, {id: id, data: results.map(callback)}); }
-    var plotData = [
-        makeSubpoints('min', function (result, index) { return [index, result.min()]; }),
+    var values = results.reduce(function (values, result, index) {
+        var newValues = result.values();
+        return newValues ? values.concat(newValues.map(function (value) { return [index, value]; })) : values;
+    }, []);
+
+    var plotData = [];
+    if (values.length)
+        plotData = [$.extend(true, {}, subpointsPlotOptions, {data: values})];
+    else {
+        function makeSubpoints(id, callback) { return $.extend(true, {}, subpointsPlotOptions, {id: id, data: results.map(callback)}); }
+        plotData = [makeSubpoints('min', function (result, index) { return [index, result.min()]; }),
         makeSubpoints('max', function (result, index) { return [index, result.max()]; }),
         makeSubpoints('-&#963;', function (result, index) { return [index, result.mean() - result.stdev()]; }),
-        makeSubpoints('+&#963;', function (result, index) { return [index, result.mean() + result.stdev()]; }),
-        {data: results.map(function (result, index) { return [index, result.mean()]; }), color: plotColor}];
+        makeSubpoints('+&#963;', function (result, index) { return [index, result.mean() + result.stdev()]; })];
+    }
 
+    plotData.push({id: '&mu;', data: results.map(function (result, index) { return [index, result.mean()]; }), color: plotColor});
+
     var currentPlotOptions = $.extend(true, {}, mainPlotOptions, {yaxis: {
         min: minIsZero ? 0 : Math.min.apply(Math, results.map(function (result, index) { return result.min(); })) * 0.98,
         max: Math.max.apply(Math, results.map(function (result, index) { return result.max(); })) * (minIsZero ? 1.1 : 1.01)}});
@@ -343,8 +354,12 @@
             secondCell = '</td><td class="' + className + '">' + comparison;
         }
 
+        var statistics = '&sigma;=' + toFixedWidthPrecision(result.stdev()) + ', min=' + toFixedWidthPrecision(result.min())
+            + ', max=' + toFixedWidthPrecision(result.max());
+
         // Tablesorter doesn't know about the second cell so put the comparison in the invisible element.
-        return '<td class="result">' + toFixedWidthPrecision(result.mean()) + hiddenValue + '</td><td class="stdev">&plusmn; '
+        return '<td class="result" title="' + statistics + '">' + toFixedWidthPrecision(result.mean()) + hiddenValue
+            + '</td><td class="stdev" title="' + statistics + '">&plusmn; '
             + formatPercentage(result.stdevRatio()) + secondCell + '</td>';
     }).reduce(function (markup, cell) { return markup + cell; }, ''));

_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes