- Revision
- 129178
- Author
- [email protected]
- Date
- 2012-09-20 16:38:21 -0700 (Thu, 20 Sep 2012)
Log Message
[chromium] Enable more clang warnings
https://bugs.webkit.org/show_bug.cgi?id=97257
Reviewed by James Robinson.
Source/WebCore:
Add -Wunused-parameter to WebCore targets. Apple's Mac compile already
warns on this and it's a common source of error for Chromium patches.
No new tests, should compile cleanly.
* WebCore.gyp/WebCore.gyp:
Source/WebKit/chromium:
* WebKit.gyp: Add -Wglobal-constructors. Don't add -Wunused-parameter because many of our API interfaces have named parameters with empty implementations.
* WebKitUnitTests.gyp: Add -Wglobal-constructors and -Wunused-parameter.
Tools:
* DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Add -Wunused-parameter. Don't add -Wglobal-constructors because
there are lots of violations in these files.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (129177 => 129178)
--- trunk/Source/WebCore/ChangeLog 2012-09-20 23:31:41 UTC (rev 129177)
+++ trunk/Source/WebCore/ChangeLog 2012-09-20 23:38:21 UTC (rev 129178)
@@ -1,3 +1,17 @@
+2012-09-20 Tony Chang <[email protected]>
+
+ [chromium] Enable more clang warnings
+ https://bugs.webkit.org/show_bug.cgi?id=97257
+
+ Reviewed by James Robinson.
+
+ Add -Wunused-parameter to WebCore targets. Apple's Mac compile already
+ warns on this and it's a common source of error for Chromium patches.
+
+ No new tests, should compile cleanly.
+
+ * WebCore.gyp/WebCore.gyp:
+
2012-09-20 Dan Bernstein <[email protected]>
Kerning never occurs between a space and the following glyph
Modified: trunk/Source/WebCore/WebCore.gyp/WebCore.gyp (129177 => 129178)
--- trunk/Source/WebCore/WebCore.gyp/WebCore.gyp 2012-09-20 23:31:41 UTC (rev 129177)
+++ trunk/Source/WebCore/WebCore.gyp/WebCore.gyp 2012-09-20 23:38:21 UTC (rev 129178)
@@ -359,9 +359,9 @@
}], # condition OS == "mac"
['clang==1', {
'target_defaults': {
- 'cflags': ['-Wglobal-constructors'],
+ 'cflags': ['-Wglobal-constructors', '-Wunused-parameter'],
'xcode_settings': {
- 'WARNING_CFLAGS': ['-Wglobal-constructors'],
+ 'WARNING_CFLAGS': ['-Wglobal-constructors', '-Wunused-parameter'],
},
},
}],
Modified: trunk/Source/WebKit/chromium/ChangeLog (129177 => 129178)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-09-20 23:31:41 UTC (rev 129177)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-09-20 23:38:21 UTC (rev 129178)
@@ -1,3 +1,13 @@
+2012-09-20 Tony Chang <[email protected]>
+
+ [chromium] Enable more clang warnings
+ https://bugs.webkit.org/show_bug.cgi?id=97257
+
+ Reviewed by James Robinson.
+
+ * WebKit.gyp: Add -Wglobal-constructors. Don't add -Wunused-parameter because many of our API interfaces have named parameters with empty implementations.
+ * WebKitUnitTests.gyp: Add -Wglobal-constructors and -Wunused-parameter.
+
2012-09-20 David Grogan <[email protected]>
Fix IndexedDB unit tests
Modified: trunk/Source/WebKit/chromium/WebKit.gyp (129177 => 129178)
--- trunk/Source/WebKit/chromium/WebKit.gyp 2012-09-20 23:31:41 UTC (rev 129177)
+++ trunk/Source/WebKit/chromium/WebKit.gyp 2012-09-20 23:38:21 UTC (rev 129178)
@@ -1313,5 +1313,13 @@
},
],
}],
+ ['clang==1', {
+ 'target_defaults': {
+ 'cflags': ['-Wglobal-constructors'],
+ 'xcode_settings': {
+ 'WARNING_CFLAGS': ['-Wglobal-constructors'],
+ },
+ },
+ }],
], # conditions
}
Modified: trunk/Source/WebKit/chromium/WebKitUnitTests.gyp (129177 => 129178)
--- trunk/Source/WebKit/chromium/WebKitUnitTests.gyp 2012-09-20 23:31:41 UTC (rev 129177)
+++ trunk/Source/WebKit/chromium/WebKitUnitTests.gyp 2012-09-20 23:38:21 UTC (rev 129178)
@@ -218,5 +218,13 @@
],
}],
}],
+ ['clang==1', {
+ 'target_defaults': {
+ 'cflags': ['-Wglobal-constructors', '-Wunused-parameter'],
+ 'xcode_settings': {
+ 'WARNING_CFLAGS': ['-Wglobal-constructors', '-Wunused-parameter'],
+ },
+ },
+ }],
],
}
Modified: trunk/Tools/ChangeLog (129177 => 129178)
--- trunk/Tools/ChangeLog 2012-09-20 23:31:41 UTC (rev 129177)
+++ trunk/Tools/ChangeLog 2012-09-20 23:38:21 UTC (rev 129178)
@@ -1,3 +1,13 @@
+2012-09-20 Tony Chang <[email protected]>
+
+ [chromium] Enable more clang warnings
+ https://bugs.webkit.org/show_bug.cgi?id=97257
+
+ Reviewed by James Robinson.
+
+ * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Add -Wunused-parameter. Don't add -Wglobal-constructors because
+ there are lots of violations in these files.
+
2012-09-19 Ryosuke Niwa <[email protected]>
run-perf-tests should record individual value instead of statistics
Modified: trunk/Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp (129177 => 129178)
--- trunk/Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp 2012-09-20 23:31:41 UTC (rev 129177)
+++ trunk/Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp 2012-09-20 23:38:21 UTC (rev 129178)
@@ -528,5 +528,14 @@
}],
}],
}],
+ ['clang==1', {
+ 'target_defaults': {
+ # FIXME: Add -Wglobal-constructors after fixing existing bugs.
+ 'cflags': ['-Wunused-parameter'],
+ 'xcode_settings': {
+ 'WARNING_CFLAGS': ['-Wunused-parameter'],
+ },
+ },
+ }],
], # conditions
}
