Title: [129208] trunk/Source/WebCore
- Revision
- 129208
- Author
- [email protected]
- Date
- 2012-09-21 03:13:13 -0700 (Fri, 21 Sep 2012)
Log Message
Remove unused functions of LocalizedDate.h
https://bugs.webkit.org/show_bug.cgi?id=97311
Reviewed by Kentaro Hara.
WebCore::localizedTimeFormatText, WebCore::localizedShortTimeFormatText,
and WebCore::timeAMPMLabels are not used any more because we switched to
the corresponding functions of Localizer.
No new tests because of no behavior changes.
* platform/text/Localizer.h:
(Localizer): Moved comments from LocalizedDate.h.
* platform/text/LocalizedDate.h:
(WebCore): Removed localizedTimeFormatText,
localizedShortTimeFormatText, and timeAMPMLabels.
* platform/text/LocalizedDateICU.cpp:
(WebCore): ditto.
* platform/text/LocalizedDateWin.cpp:
(WebCore): ditto.
* platform/text/mac/LocalizedDateMac.cpp:
(WebCore): ditto.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (129207 => 129208)
--- trunk/Source/WebCore/ChangeLog 2012-09-21 10:08:31 UTC (rev 129207)
+++ trunk/Source/WebCore/ChangeLog 2012-09-21 10:13:13 UTC (rev 129208)
@@ -1,3 +1,28 @@
+2012-09-21 Kent Tamura <[email protected]>
+
+ Remove unused functions of LocalizedDate.h
+ https://bugs.webkit.org/show_bug.cgi?id=97311
+
+ Reviewed by Kentaro Hara.
+
+ WebCore::localizedTimeFormatText, WebCore::localizedShortTimeFormatText,
+ and WebCore::timeAMPMLabels are not used any more because we switched to
+ the corresponding functions of Localizer.
+
+ No new tests because of no behavior changes.
+
+ * platform/text/Localizer.h:
+ (Localizer): Moved comments from LocalizedDate.h.
+ * platform/text/LocalizedDate.h:
+ (WebCore): Removed localizedTimeFormatText,
+ localizedShortTimeFormatText, and timeAMPMLabels.
+ * platform/text/LocalizedDateICU.cpp:
+ (WebCore): ditto.
+ * platform/text/LocalizedDateWin.cpp:
+ (WebCore): ditto.
+ * platform/text/mac/LocalizedDateMac.cpp:
+ (WebCore): ditto.
+
2012-09-21 Keishi Hattori <[email protected]>
Add datalist suggestions into DateTimeChooserParameters
Modified: trunk/Source/WebCore/platform/text/LocalizedDate.h (129207 => 129208)
--- trunk/Source/WebCore/platform/text/LocalizedDate.h 2012-09-21 10:08:31 UTC (rev 129207)
+++ trunk/Source/WebCore/platform/text/LocalizedDate.h 2012-09-21 10:13:13 UTC (rev 129208)
@@ -62,20 +62,6 @@
unsigned firstDayOfWeek();
#endif
-#if ENABLE(INPUT_TYPE_TIME_MULTIPLE_FIELDS)
-// Returns time format in Unicode TR35 LDML[1] containing hour, minute, and
-// second with optional period(AM/PM), e.g. "h:mm:ss a"
-// [1] LDML http://unicode.org/reports/tr35/tr35-6.html#Date_Format_Patterns
-String localizedTimeFormatText();
-
-// Returns time format in Unicode TR35 LDML containing hour, and minute
-// with optional period(AM/PM), e.g. "h:mm a"
-// Note: Some platforms return same value as localizedTimeFormatText().
-String localizedShortTimeFormatText();
-
-// Returns localized period field(AM/PM) strings.
-const Vector<String>& timeAMPMLabels();
-#endif
} // namespace WebCore
#endif // LocalizedDate_h
Modified: trunk/Source/WebCore/platform/text/LocalizedDateICU.cpp (129207 => 129208)
--- trunk/Source/WebCore/platform/text/LocalizedDateICU.cpp 2012-09-21 10:08:31 UTC (rev 129207)
+++ trunk/Source/WebCore/platform/text/LocalizedDateICU.cpp 2012-09-21 10:13:13 UTC (rev 129208)
@@ -92,21 +92,4 @@
}
#endif
-#if ENABLE(INPUT_TYPE_TIME_MULTIPLE_FIELDS)
-String localizedTimeFormatText()
-{
- return LocaleICU::currentLocale()->timeFormat();
}
-
-String localizedShortTimeFormatText()
-{
- return LocaleICU::currentLocale()->shortTimeFormat();
-}
-
-const Vector<String>& timeAMPMLabels()
-{
- return LocaleICU::currentLocale()->timeAMPMLabels();
-}
-#endif
-
-}
Modified: trunk/Source/WebCore/platform/text/LocalizedDateWin.cpp (129207 => 129208)
--- trunk/Source/WebCore/platform/text/LocalizedDateWin.cpp 2012-09-21 10:08:31 UTC (rev 129207)
+++ trunk/Source/WebCore/platform/text/LocalizedDateWin.cpp 2012-09-21 10:13:13 UTC (rev 129208)
@@ -92,21 +92,4 @@
}
#endif
-#if ENABLE(INPUT_TYPE_TIME_MULTIPLE_FIELDS)
-String localizedTimeFormatText()
-{
- return LocaleWin::currentLocale()->timeFormat();
}
-
-String localizedShortTimeFormatText()
-{
- return LocaleWin::currentLocale()->shortTimeFormat();
-}
-
-const Vector<String>& timeAMPMLabels()
-{
- return LocaleWin::currentLocale()->timeAMPMLabels();
-}
-#endif
-
-}
Modified: trunk/Source/WebCore/platform/text/Localizer.h (129207 => 129208)
--- trunk/Source/WebCore/platform/text/Localizer.h 2012-09-21 10:08:31 UTC (rev 129207)
+++ trunk/Source/WebCore/platform/text/Localizer.h 2012-09-21 10:13:13 UTC (rev 129208)
@@ -37,8 +37,18 @@
String convertFromLocalizedNumber(const String&);
#if ENABLE(INPUT_TYPE_TIME_MULTIPLE_FIELDS)
String localizedDecimalSeparator();
+
+ // Returns time format in Unicode TR35 LDML[1] containing hour, minute, and
+ // second with optional period(AM/PM), e.g. "h:mm:ss a"
+ // [1] LDML http://unicode.org/reports/tr35/tr35-6.html#Date_Format_Patterns
virtual String timeFormat();
+
+ // Returns time format in Unicode TR35 LDML containing hour, and minute
+ // with optional period(AM/PM), e.g. "h:mm a"
+ // Note: Some platforms return same value as timeFormat().
virtual String shortTimeFormat();
+
+ // Returns localized period field(AM/PM) strings.
virtual const Vector<String>& timeAMPMLabels();
#endif
virtual ~Localizer();
Modified: trunk/Source/WebCore/platform/text/mac/LocalizedDateMac.cpp (129207 => 129208)
--- trunk/Source/WebCore/platform/text/mac/LocalizedDateMac.cpp 2012-09-21 10:08:31 UTC (rev 129207)
+++ trunk/Source/WebCore/platform/text/mac/LocalizedDateMac.cpp 2012-09-21 10:13:13 UTC (rev 129208)
@@ -92,21 +92,4 @@
}
#endif
-#if ENABLE(INPUT_TYPE_TIME_MULTIPLE_FIELDS)
-String localizedTimeFormatText()
-{
- return LocaleMac::currentLocale()->timeFormat();
}
-
-String localizedShortTimeFormatText()
-{
- return LocaleMac::currentLocale()->shortTimeFormat();
-}
-
-const Vector<String>& timeAMPMLabels()
-{
- return LocaleMac::currentLocale()->timeAMPMLabels();
-}
-#endif
-
-}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
