Title: [129247] trunk
- Revision
- 129247
- Author
- [email protected]
- Date
- 2012-09-21 13:03:57 -0700 (Fri, 21 Sep 2012)
Log Message
REGRESSION (r127882): accessibility/spinbutton-value.html failing on GTK
https://bugs.webkit.org/show_bug.cgi?id=96196
Patch by Joanmarie Diggs <[email protected]> on 2012-09-21
Reviewed by Martin Robinson.
The "regression" is that a new test was added but the support was missing
in the Gtk port for spin buttons.
Source/WebCore:
No new tests. Instead the new test which had been skipped was unskipped
as part of this fix.
* accessibility/gtk/WebKitAccessibleWrapperAtk.cpp:
(atkRole): Map SpinButtonRole to ATK_ROLE_SPIN_BUTTON
(getInterfaceMaskFromObject): Add SpinButtonRole to the roles implementing
the AtkValue interface.
Tools:
* DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
(AccessibilityUIElement::valueDescription): Updated the FIXME comment to
indicate that this cannot be implemented until it is implemented in ATK.
URL of the newly-filed ATK bug included for reference.
LayoutTests:
* platform/gtk/TestExpectations: Unskip the new test.
* platform/gtk/accessibility/spinbutton-value-expected.txt: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (129246 => 129247)
--- trunk/LayoutTests/ChangeLog 2012-09-21 19:40:19 UTC (rev 129246)
+++ trunk/LayoutTests/ChangeLog 2012-09-21 20:03:57 UTC (rev 129247)
@@ -1,5 +1,18 @@
2012-09-21 Joanmarie Diggs <[email protected]>
+ REGRESSION (r127882): accessibility/spinbutton-value.html failing on GTK
+ https://bugs.webkit.org/show_bug.cgi?id=96196
+
+ Reviewed by Martin Robinson.
+
+ The "regression" is that a new test was added but the support was missing
+ in the Gtk port for spin buttons.
+
+ * platform/gtk/TestExpectations: Unskip the new test.
+ * platform/gtk/accessibility/spinbutton-value-expected.txt: Added.
+
+2012-09-21 Joanmarie Diggs <[email protected]>
+
[GTK] [Stable] Infinite recursion in WebCore::AXObjectCache::getOrCreate
https://bugs.webkit.org/show_bug.cgi?id=96932
Modified: trunk/LayoutTests/platform/gtk/TestExpectations (129246 => 129247)
--- trunk/LayoutTests/platform/gtk/TestExpectations 2012-09-21 19:40:19 UTC (rev 129246)
+++ trunk/LayoutTests/platform/gtk/TestExpectations 2012-09-21 20:03:57 UTC (rev 129247)
@@ -1354,8 +1354,6 @@
webkit.org/b/88238 editing/pasteboard/paste-global-selection.html [ Failure ]
-webkit.org/b/96196 accessibility/spinbutton-value.html [ Failure ]
-
webkit.org/b/73003 [ Debug ] editing/spelling/spellcheck-async.html [ Failure ]
webkit.org/b/73003 [ Debug ] editing/spelling/spellcheck-paste.html [ Pass ]
webkit.org/b/50740 [ Debug ] editing/spelling/spellcheck-queue.html [ Failure ]
Added: trunk/LayoutTests/platform/gtk/accessibility/spinbutton-value-expected.txt (0 => 129247)
--- trunk/LayoutTests/platform/gtk/accessibility/spinbutton-value-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/gtk/accessibility/spinbutton-value-expected.txt 2012-09-21 20:03:57 UTC (rev 129247)
@@ -0,0 +1,16 @@
+
+42
+This tests that a spin button supports range value attributes.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS endsWith(axSpin.intValue, '5') is true
+PASS endsWith(axSpin.minValue, '1') is true
+PASS endsWith(axSpin.maxValue, '9') is true
+FAIL endsWith(axSpin.valueDescription, '5 of 9') should be true. Was false.
+PASS axSpin.title is axUntitled.title
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Modified: trunk/Source/WebCore/ChangeLog (129246 => 129247)
--- trunk/Source/WebCore/ChangeLog 2012-09-21 19:40:19 UTC (rev 129246)
+++ trunk/Source/WebCore/ChangeLog 2012-09-21 20:03:57 UTC (rev 129247)
@@ -1,5 +1,23 @@
2012-09-21 Joanmarie Diggs <[email protected]>
+ REGRESSION (r127882): accessibility/spinbutton-value.html failing on GTK
+ https://bugs.webkit.org/show_bug.cgi?id=96196
+
+ Reviewed by Martin Robinson.
+
+ The "regression" is that a new test was added but the support was missing
+ in the Gtk port for spin buttons.
+
+ No new tests. Instead the new test which had been skipped was unskipped
+ as part of this fix.
+
+ * accessibility/gtk/WebKitAccessibleWrapperAtk.cpp:
+ (atkRole): Map SpinButtonRole to ATK_ROLE_SPIN_BUTTON
+ (getInterfaceMaskFromObject): Add SpinButtonRole to the roles implementing
+ the AtkValue interface.
+
+2012-09-21 Joanmarie Diggs <[email protected]>
+
[GTK] [Stable] Infinite recursion in WebCore::AXObjectCache::getOrCreate
https://bugs.webkit.org/show_bug.cgi?id=96932
Modified: trunk/Source/WebCore/accessibility/gtk/WebKitAccessibleWrapperAtk.cpp (129246 => 129247)
--- trunk/Source/WebCore/accessibility/gtk/WebKitAccessibleWrapperAtk.cpp 2012-09-21 19:40:19 UTC (rev 129246)
+++ trunk/Source/WebCore/accessibility/gtk/WebKitAccessibleWrapperAtk.cpp 2012-09-21 20:03:57 UTC (rev 129247)
@@ -555,6 +555,8 @@
return ATK_ROLE_CANVAS;
case HorizontalRuleRole:
return ATK_ROLE_SEPARATOR;
+ case SpinButtonRole:
+ return ATK_ROLE_SPIN_BUTTON;
default:
return ATK_ROLE_UNKNOWN;
}
@@ -923,7 +925,7 @@
interfaceMask |= 1 << WAI_DOCUMENT;
// Value
- if (role == SliderRole)
+ if (role == SliderRole || role == SpinButtonRole)
interfaceMask |= 1 << WAI_VALUE;
return interfaceMask;
Modified: trunk/Tools/ChangeLog (129246 => 129247)
--- trunk/Tools/ChangeLog 2012-09-21 19:40:19 UTC (rev 129246)
+++ trunk/Tools/ChangeLog 2012-09-21 20:03:57 UTC (rev 129247)
@@ -1,3 +1,18 @@
+2012-09-21 Joanmarie Diggs <[email protected]>
+
+ REGRESSION (r127882): accessibility/spinbutton-value.html failing on GTK
+ https://bugs.webkit.org/show_bug.cgi?id=96196
+
+ Reviewed by Martin Robinson.
+
+ The "regression" is that a new test was added but the support was missing
+ in the Gtk port for spin buttons.
+
+ * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
+ (AccessibilityUIElement::valueDescription): Updated the FIXME comment to
+ indicate that this cannot be implemented until it is implemented in ATK.
+ URL of the newly-filed ATK bug included for reference.
+
2012-09-21 Dirk Pranke <[email protected]>
Fix test_skip_and_wontfix failure
Modified: trunk/Tools/DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp (129246 => 129247)
--- trunk/Tools/DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp 2012-09-21 19:40:19 UTC (rev 129246)
+++ trunk/Tools/DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp 2012-09-21 20:03:57 UTC (rev 129247)
@@ -409,7 +409,8 @@
JSStringRef AccessibilityUIElement::valueDescription()
{
- // FIXME: implement
+ // FIXME: implement after it has been implemented in ATK.
+ // See: https://bugzilla.gnome.org/show_bug.cgi?id=684576
return JSStringCreateWithCharacters(0, 0);
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
