Title: [129264] trunk/Tools
- Revision
- 129264
- Author
- [email protected]
- Date
- 2012-09-21 15:33:10 -0700 (Fri, 21 Sep 2012)
Log Message
Improve WTR unresponsiveness output a little
https://bugs.webkit.org/show_bug.cgi?id=97370
Reviewed by Timothy Horton.
Distinguish between conditions that already set the errorMessage,
and unresponsiveness due to slow about:blank loads when WTR
reports unresponsiveness.
* WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::invoke):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (129263 => 129264)
--- trunk/Tools/ChangeLog 2012-09-21 22:30:54 UTC (rev 129263)
+++ trunk/Tools/ChangeLog 2012-09-21 22:33:10 UTC (rev 129264)
@@ -1,3 +1,17 @@
+2012-09-21 Simon Fraser <[email protected]>
+
+ Improve WTR unresponsiveness output a little
+ https://bugs.webkit.org/show_bug.cgi?id=97370
+
+ Reviewed by Timothy Horton.
+
+ Distinguish between conditions that already set the errorMessage,
+ and unresponsiveness due to slow about:blank loads when WTR
+ reports unresponsiveness.
+
+ * WebKitTestRunner/TestInvocation.cpp:
+ (WTR::TestInvocation::invoke):
+
2012-09-21 Chris Rogers <[email protected]>
Add Web Audio support for deprecated/legacy APIs
Modified: trunk/Tools/WebKitTestRunner/TestInvocation.cpp (129263 => 129264)
--- trunk/Tools/WebKitTestRunner/TestInvocation.cpp 2012-09-21 22:30:54 UTC (rev 129263)
+++ trunk/Tools/WebKitTestRunner/TestInvocation.cpp 2012-09-21 22:33:10 UTC (rev 129264)
@@ -198,8 +198,10 @@
WKInspectorClose(WKPageGetInspector(TestController::shared().mainWebView()->page()));
#endif // ENABLE(INSPECTOR)
- if (errorMessage || !TestController::shared().resetStateToConsistentValues())
+ if (errorMessage)
dumpWebProcessUnresponsiveness(errorMessage);
+ else if (!TestController::shared().resetStateToConsistentValues())
+ dumpWebProcessUnresponsiveness("Timed out loading about:blank before the next test");
}
void TestInvocation::dumpWebProcessUnresponsiveness(const char* textToStdout)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
