Title: [129289] trunk/Source/_javascript_Core
Revision
129289
Author
[email protected]
Date
2012-09-21 18:34:25 -0700 (Fri, 21 Sep 2012)

Log Message

Pedantic test in Mozilla's _javascript_ test suite fails. function-001.js function-001-n.js
https://bugs.webkit.org/show_bug.cgi?id=27219

Reviewed by Sam Weinig.

These tests are just wrong.
See ECMA 262 A.5, FunctionDelcaration does not require a semicolon.

* tests/mozilla/expected.html:
* tests/mozilla/js1_2/function/function-001-n.js:
* tests/mozilla/js1_3/Script/function-001-n.js:
* tests/mozilla/js1_3/regress/function-001-n.js:

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (129288 => 129289)


--- trunk/Source/_javascript_Core/ChangeLog	2012-09-22 01:27:52 UTC (rev 129288)
+++ trunk/Source/_javascript_Core/ChangeLog	2012-09-22 01:34:25 UTC (rev 129289)
@@ -1,5 +1,20 @@
 2012-09-21  Gavin Barraclough  <[email protected]>
 
+        Pedantic test in Mozilla's _javascript_ test suite fails. function-001.js function-001-n.js
+        https://bugs.webkit.org/show_bug.cgi?id=27219
+
+        Reviewed by Sam Weinig.
+
+        These tests are just wrong.
+        See ECMA 262 A.5, FunctionDelcaration does not require a semicolon.
+
+        * tests/mozilla/expected.html:
+        * tests/mozilla/js1_2/function/function-001-n.js:
+        * tests/mozilla/js1_3/Script/function-001-n.js:
+        * tests/mozilla/js1_3/regress/function-001-n.js:
+
+2012-09-21  Gavin Barraclough  <[email protected]>
+
         Remove redundant argument to op_instanceof
         https://bugs.webkit.org/show_bug.cgi?id=97382
 

Modified: trunk/Source/_javascript_Core/tests/mozilla/expected.html (129288 => 129289)


--- trunk/Source/_javascript_Core/tests/mozilla/expected.html	2012-09-22 01:27:52 UTC (rev 129288)
+++ trunk/Source/_javascript_Core/tests/mozilla/expected.html	2012-09-22 01:34:25 UTC (rev 129289)
@@ -9,9 +9,9 @@
 Skip List: ecma/Date/15.9.2.1.js, ecma/Date/15.9.2.2-1.js, ecma/Date/15.9.2.2-2.js, ecma/Date/15.9.2.2-3.js, ecma/Date/15.9.2.2-4.js, ecma/Date/15.9.2.2-5.js, ecma/Date/15.9.2.2-6.js, ecma_3/Date/15.9.5.7.js, ecma/Date/15.9.5.14.js, ecma/Date/15.9.5.31-1.js, ecma/Date/15.9.5.34-1.js<br>
 1124 test(s) selected, 1116 test(s) completed, 44 failures reported (3.94% failed)<br>
 Engine command line: "/Volumes/Data/Saxony/OpenSource/WebKitBuild/Debug/jsc" <br>
-OS type: Darwin Bearclaw-Kaliber.local 12.0.0 Darwin Kernel Version 12.0.0: Sun Jun 24 23:00:16 PDT 2012; root:xnu-2050.7.9~1/RELEASE_X86_64 x86_64<br>
-Testcase execution time: 52 seconds.<br>
-Tests completed on Thu Sep  6 15:11:19 2012.<br><br>
+OS type: Darwin Bearclaw-Kaliber.local 12.0.0 Darwin Kernel Version 12.0.0: Fri Jun 22 20:01:10 PDT 2012; root:xnu-2050.7.7~1/RELEASE_X86_64 x86_64<br>
+Testcase execution time: 54 seconds.<br>
+Tests completed on Fri Sep 21 18:29:47 2012.<br><br>
 [ <a href=''>Failure Details</a> | <a href=''>Retest List</a> | <a href=''>Test Selection Page</a> ]<br>
 <hr>
 <a name='fail_detail'></a>
@@ -80,7 +80,7 @@
 Testcase terminated with signal 0<br>
 Complete testcase output was:<br>
 function-001.js functions not separated by semicolons are errors in version 120 and higher<br>
-eval("function f(){}function g(){}") = undefined FAILED! expected: error<br>
+eval("function f(){}function g(){}") = undefined PASSED!<br>
 </tt><br>
 <a name='failure9'></a><dd><b>Testcase <a target='other_window' href=''>js1_2/function/regexparg-1.js</a> failed</b> <br>
  [ <a href=''>Previous Failure</a> | <a href=''>Next Failure</a> | <a href=''>Top of Page</a> ]<br>
@@ -163,7 +163,7 @@
 Complete testcase output was:<br>
 BUGNUMBER: 10278<br>
 function-001.js functions not separated by semicolons are errors in version 120 and higher<br>
-eval("function f(){}function g(){}") = undefined FAILED! expected: error<br>
+eval("function f(){}function g(){}") = undefined PASSED!<br>
 </tt><br>
 <a name='failure19'></a><dd><b>Testcase <a target='other_window' href=''>js1_3/Script/script-001.js</a> failed</b> <br>
  [ <a href=''>Previous Failure</a> | <a href=''>Next Failure</a> | <a href=''>Top of Page</a> ]<br>
@@ -181,7 +181,7 @@
 Complete testcase output was:<br>
 BUGNUMBER: 10278<br>
 function-001.js functions not separated by semicolons are errors in version 120 and higher<br>
-eval("function f(){}function g(){}") = undefined FAILED! expected: error<br>
+eval("function f(){}function g(){}") = undefined PASSED!<br>
 </tt><br>
 <a name='failure21'></a><dd><b>Testcase <a target='other_window' href=''>js1_5/Exceptions/catchguard-001.js</a> failed</b> <br>
  [ <a href=''>Previous Failure</a> | <a href=''>Next Failure</a> | <a href=''>Top of Page</a> ]<br>
@@ -437,7 +437,7 @@
 <pre>
 <a name='retest_list'></a>
 <h2>Retest List</h2><br>
-# Retest List, squirrelfish, generated Thu Sep  6 15:11:19 2012.
+# Retest List, squirrelfish, generated Fri Sep 21 18:29:47 2012.
 # Original test base was: All tests.
 # 1116 of 1124 test(s) were completed, 44 failures reported.
 ecma_2/Exceptions/function-001.js

Modified: trunk/Source/_javascript_Core/tests/mozilla/js1_2/function/function-001-n.js (129288 => 129289)


--- trunk/Source/_javascript_Core/tests/mozilla/js1_2/function/function-001-n.js	2012-09-22 01:27:52 UTC (rev 129288)
+++ trunk/Source/_javascript_Core/tests/mozilla/js1_2/function/function-001-n.js	2012-09-22 01:34:25 UTC (rev 129289)
@@ -53,7 +53,7 @@
     testcases[tc++] = new TestCase(
         SECTION,
         "eval(\"function f(){}function g(){}\")",
-        "error",
+        undefined,
         eval("function f(){}function g(){}") );
 
     test();

Modified: trunk/Source/_javascript_Core/tests/mozilla/js1_3/Script/function-001-n.js (129288 => 129289)


--- trunk/Source/_javascript_Core/tests/mozilla/js1_3/Script/function-001-n.js	2012-09-22 01:27:52 UTC (rev 129288)
+++ trunk/Source/_javascript_Core/tests/mozilla/js1_3/Script/function-001-n.js	2012-09-22 01:34:25 UTC (rev 129289)
@@ -53,7 +53,7 @@
     testcases[tc++] = new TestCase(
         SECTION,
         "eval(\"function f(){}function g(){}\")",
-        "error",
+        undefined,
         eval("function f(){}function g(){}") );
 
     test();

Modified: trunk/Source/_javascript_Core/tests/mozilla/js1_3/regress/function-001-n.js (129288 => 129289)


--- trunk/Source/_javascript_Core/tests/mozilla/js1_3/regress/function-001-n.js	2012-09-22 01:27:52 UTC (rev 129288)
+++ trunk/Source/_javascript_Core/tests/mozilla/js1_3/regress/function-001-n.js	2012-09-22 01:34:25 UTC (rev 129289)
@@ -53,7 +53,7 @@
     testcases[tc++] = new TestCase(
         SECTION,
         "eval(\"function f(){}function g(){}\")",
-        "error",
+        undefined,
         eval("function f(){}function g(){}") );
 
     test();
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to