Title: [129327] trunk/Source/WebKit2
- Revision
- 129327
- Author
- [email protected]
- Date
- 2012-09-23 23:27:49 -0700 (Sun, 23 Sep 2012)
Log Message
[EFL][WK2] Add setting to toggle developer extensions
https://bugs.webkit.org/show_bug.cgi?id=96974
Patch by Seokju Kwon <[email protected]> on 2012-09-23
Reviewed by Kenneth Rohde Christiansen.
This is required to allow the user to inspect pages. (Web inspector)
* UIProcess/API/efl/ewk_settings.cpp:
(ewk_settings_developer_extras_enabled_set):
(ewk_settings_developer_extras_enabled_get):
* UIProcess/API/efl/ewk_settings.h:
* UIProcess/API/efl/tests/test_ewk2_settings.cpp:
(TEST_F):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (129326 => 129327)
--- trunk/Source/WebKit2/ChangeLog 2012-09-24 04:39:09 UTC (rev 129326)
+++ trunk/Source/WebKit2/ChangeLog 2012-09-24 06:27:49 UTC (rev 129327)
@@ -1,3 +1,19 @@
+2012-09-23 Seokju Kwon <[email protected]>
+
+ [EFL][WK2] Add setting to toggle developer extensions
+ https://bugs.webkit.org/show_bug.cgi?id=96974
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ This is required to allow the user to inspect pages. (Web inspector)
+
+ * UIProcess/API/efl/ewk_settings.cpp:
+ (ewk_settings_developer_extras_enabled_set):
+ (ewk_settings_developer_extras_enabled_get):
+ * UIProcess/API/efl/ewk_settings.h:
+ * UIProcess/API/efl/tests/test_ewk2_settings.cpp:
+ (TEST_F):
+
2012-09-23 Byungwoo Lee <[email protected]>
Fix build warnings : -Wunused-parameter, -Wparentheses, -Wuninitialized.
Modified: trunk/Source/WebKit2/UIProcess/API/efl/ewk_settings.cpp (129326 => 129327)
--- trunk/Source/WebKit2/UIProcess/API/efl/ewk_settings.cpp 2012-09-24 04:39:09 UTC (rev 129326)
+++ trunk/Source/WebKit2/UIProcess/API/efl/ewk_settings.cpp 2012-09-24 06:27:49 UTC (rev 129327)
@@ -83,3 +83,19 @@
return WKPreferencesGetLoadsImagesAutomatically(settings->preferences.get());
}
+
+Eina_Bool ewk_settings_developer_extras_enabled_set(Ewk_Settings* settings, Eina_Bool enable)
+{
+ EINA_SAFETY_ON_NULL_RETURN_VAL(settings, false);
+
+ WKPreferencesSetDeveloperExtrasEnabled(settings->preferences.get(), enable);
+
+ return true;
+}
+
+Eina_Bool ewk_settings_developer_extras_enabled_get(const Ewk_Settings* settings)
+{
+ EINA_SAFETY_ON_NULL_RETURN_VAL(settings, false);
+
+ return WKPreferencesGetDeveloperExtrasEnabled(settings->preferences.get());
+}
Modified: trunk/Source/WebKit2/UIProcess/API/efl/ewk_settings.h (129326 => 129327)
--- trunk/Source/WebKit2/UIProcess/API/efl/ewk_settings.h 2012-09-24 04:39:09 UTC (rev 129326)
+++ trunk/Source/WebKit2/UIProcess/API/efl/ewk_settings.h 2012-09-24 06:27:49 UTC (rev 129327)
@@ -110,6 +110,30 @@
*/
EAPI Eina_Bool ewk_settings_loads_images_automatically_get(const Ewk_Settings *settings);
+/**
+ * Enables/disables developer extensions.
+ *
+ * By default, the developer extensions are disabled.
+ *
+ * @param settings settings object to set developer extensions
+ * @param enable @c EINA_TRUE to enable developer extensions, @c EINA_FALSE to disable
+ *
+ * @return @c EINA_TRUE on success or @EINA_FALSE on failure
+ */
+EAPI Eina_Bool ewk_settings_developer_extras_enabled_set(Ewk_Settings *settings, Eina_Bool enable);
+
+/**
+ * Queries if developer extensions are enabled.
+ *
+ * By default, the developer extensions are disabled.
+ *
+ * @param settings settings object to set developer extensions
+ *
+ * @return @c EINA_TRUE if developer extensions are enabled
+ @c EINA_FALSE if not or on failure
+ */
+EAPI Eina_Bool ewk_settings_developer_extras_enabled_get(const Ewk_Settings *settings);
+
#ifdef __cplusplus
}
#endif
Modified: trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_settings.cpp (129326 => 129327)
--- trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_settings.cpp 2012-09-24 04:39:09 UTC (rev 129326)
+++ trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_settings.cpp 2012-09-24 06:27:49 UTC (rev 129327)
@@ -81,3 +81,17 @@
ASSERT_TRUE(ewk_settings_loads_images_automatically_set(settings, EINA_FALSE));
ASSERT_FALSE(ewk_settings_loads_images_automatically_get(settings));
}
+
+TEST_F(EWK2UnitTestBase, ewk_settings_developer_extras_enabled)
+{
+ Ewk_Settings* settings = ewk_view_settings_get(webView());
+
+ ASSERT_TRUE(ewk_settings_developer_extras_enabled_set(settings, EINA_TRUE));
+ ASSERT_TRUE(ewk_settings_developer_extras_enabled_get(settings));
+
+ ASSERT_TRUE(ewk_settings_developer_extras_enabled_set(settings, 2));
+ ASSERT_TRUE(ewk_settings_developer_extras_enabled_get(settings));
+
+ ASSERT_TRUE(ewk_settings_developer_extras_enabled_set(settings, EINA_FALSE));
+ ASSERT_FALSE(ewk_settings_developer_extras_enabled_get(settings));
+}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
