Title: [129339] trunk/Source/WebCore
Revision
129339
Author
[email protected]
Date
2012-09-24 02:39:31 -0700 (Mon, 24 Sep 2012)

Log Message

Web Inspector: [TextEditor] Line numbers out of sync after closing breakpoint condition editor
https://bugs.webkit.org/show_bug.cgi?id=96510

Patch by Andrey Adaikin <[email protected]> on 2012-09-24
Reviewed by Vsevolod Vlasov.

Sync line heights on adding/removing decorations.

* inspector/front-end/DefaultTextEditor.js:
(WebInspector.TextEditorGutterChunk):
(WebInspector.TextEditorGutterChunk.prototype.addDecoration):
(WebInspector.TextEditorGutterChunk.prototype.removeDecoration):
(WebInspector.TextEditorGutterChunk.prototype.set expanded):
(WebInspector.TextEditorGutterChunk.prototype.get height):
(WebInspector.TextEditorGutterChunk.prototype._createRow):
(WebInspector.TextEditorMainChunk.prototype.addDecoration):
(WebInspector.TextEditorMainChunk.prototype.removeDecoration):
(WebInspector.TextEditorMainChunk.prototype.removeAllDecorations):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (129338 => 129339)


--- trunk/Source/WebCore/ChangeLog	2012-09-24 09:38:20 UTC (rev 129338)
+++ trunk/Source/WebCore/ChangeLog	2012-09-24 09:39:31 UTC (rev 129339)
@@ -1,3 +1,23 @@
+2012-09-24  Andrey Adaikin  <[email protected]>
+
+        Web Inspector: [TextEditor] Line numbers out of sync after closing breakpoint condition editor
+        https://bugs.webkit.org/show_bug.cgi?id=96510
+
+        Reviewed by Vsevolod Vlasov.
+
+        Sync line heights on adding/removing decorations.
+
+        * inspector/front-end/DefaultTextEditor.js:
+        (WebInspector.TextEditorGutterChunk):
+        (WebInspector.TextEditorGutterChunk.prototype.addDecoration):
+        (WebInspector.TextEditorGutterChunk.prototype.removeDecoration):
+        (WebInspector.TextEditorGutterChunk.prototype.set expanded):
+        (WebInspector.TextEditorGutterChunk.prototype.get height):
+        (WebInspector.TextEditorGutterChunk.prototype._createRow):
+        (WebInspector.TextEditorMainChunk.prototype.addDecoration):
+        (WebInspector.TextEditorMainChunk.prototype.removeDecoration):
+        (WebInspector.TextEditorMainChunk.prototype.removeAllDecorations):
+
 2012-09-21  Andrey Kosyakov  <[email protected]>
 
         Web Inspector: support saving HAR with resources content

Modified: trunk/Source/WebCore/inspector/front-end/DefaultTextEditor.js (129338 => 129339)


--- trunk/Source/WebCore/inspector/front-end/DefaultTextEditor.js	2012-09-24 09:38:20 UTC (rev 129338)
+++ trunk/Source/WebCore/inspector/front-end/DefaultTextEditor.js	2012-09-24 09:39:31 UTC (rev 129339)
@@ -204,6 +204,7 @@
     {
         this._mainPanel.addDecoration(lineNumber, element);
         this._gutterPanel.addDecoration(lineNumber, element);
+        this._syncDecorationsForLine(lineNumber);
     },
 
     /**
@@ -214,6 +215,7 @@
     {
         this._mainPanel.removeDecoration(lineNumber, element);
         this._gutterPanel.removeDecoration(lineNumber, element);
+        this._syncDecorationsForLine(lineNumber);
     },
 
     /**
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to