Title: [129391] trunk
Revision
129391
Author
[email protected]
Date
2012-09-24 11:32:04 -0700 (Mon, 24 Sep 2012)

Log Message

[Gtk] Unskip the Shadow DOM layout tests
https://bugs.webkit.org/show_bug.cgi?id=90776

Reviewed by Ryosuke Niwa.

Source/WebKit/gtk: 

Add a method for enabling the Shadow DOM through RuntimeEnabledFeatures.
The method is called from DumpRenderTree when resetting state.

* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::setShadowDOMEnabled):
* WebCoreSupport/DumpRenderTreeSupportGtk.h:
(DumpRenderTreeSupportGtk):

Tools: 

Enable Shadow DOM through DumpRenderTreeSupport when resetting defaults in between tests.

* DumpRenderTree/gtk/DumpRenderTree.cpp:
(resetDefaultsToConsistentValues):

LayoutTests: 

Unskip Shadow DOM layout tests, adding two required baselines and failure
expectations for tests that still fail.

* platform/gtk/TestExpectations:
* platform/gtk/fast/dom/shadow/form-in-shadow-expected.txt: Added.
* platform/gtk/fast/dom/shadow/tab-order-iframe-and-shadow-expected.txt: Added.

Modified Paths

Added Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (129390 => 129391)


--- trunk/LayoutTests/ChangeLog	2012-09-24 18:29:02 UTC (rev 129390)
+++ trunk/LayoutTests/ChangeLog	2012-09-24 18:32:04 UTC (rev 129391)
@@ -1,3 +1,17 @@
+2012-09-24  Zan Dobersek  <[email protected]>
+
+        [Gtk] Unskip the Shadow DOM layout tests
+        https://bugs.webkit.org/show_bug.cgi?id=90776
+
+        Reviewed by Ryosuke Niwa.
+
+        Unskip Shadow DOM layout tests, adding two required baselines and failure
+        expectations for tests that still fail.
+
+        * platform/gtk/TestExpectations:
+        * platform/gtk/fast/dom/shadow/form-in-shadow-expected.txt: Added.
+        * platform/gtk/fast/dom/shadow/tab-order-iframe-and-shadow-expected.txt: Added.
+
 2012-09-24  Joshua Bell  <[email protected]>
 
         [Chromium] Unreviewed gardening - re-enable IDB test that's now passing.

Modified: trunk/LayoutTests/platform/gtk/TestExpectations (129390 => 129391)


--- trunk/LayoutTests/platform/gtk/TestExpectations	2012-09-24 18:29:02 UTC (rev 129390)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2012-09-24 18:32:04 UTC (rev 129391)
@@ -308,10 +308,6 @@
 Bug(GTK) fast/regions/style-scoped-in-flow-override-region-styling.html [ ImageOnlyFailure ]
 Bug(GTK) fast/regions/style-scoped-in-flow.html [ ImageOnlyFailure ]
 
-# ENABLE(SHADOW_DOM) is disabled.
-Bug(GTK) fast/dom/shadow [ Skip ]
-Bug(GTK) editing/shadow [ Skip ]
-
 # CSS Filters is disabled
 Bug(GTK) css3/filters [ Skip ]
 
@@ -1367,6 +1363,21 @@
 webkit.org/b/97188 fast/text/word-space-with-kerning.html [ ImageOnlyFailure ]
 webkit.org/b/97188 fast/text/word-space-with-kerning-2.html [ ImageOnlyFailure ]
 
+webkit.org/b/90775 fast/dom/shadow/focus-navigation.html [ Failure ]
+webkit.org/b/97468 fast/dom/shadow/shadowdom-for-textarea-complex-shadow.html [ ImageOnlyFailure ]
+webkit.org/b/97468 fast/dom/shadow/shadowdom-for-textarea-with-placeholder.html [ ImageOnlyFailure ]
+webkit.org/b/97468 fast/dom/shadow/shadowdom-for-textarea-without-shadow.html [ ImageOnlyFailure ]
+webkit.org/b/97469 fast/dom/shadow/shadowdom-dynamic-styling.html [ Failure ]
+
+webkit.org/b/90860 fast/dom/shadow/shadowdom-for-object-complex-shadow.html [ ImageOnlyFailure ]
+webkit.org/b/90860 fast/dom/shadow/shadowdom-for-object-only-shadow.html [ ImageOnlyFailure ]
+webkit.org/b/90860 fast/dom/shadow/shadowdom-for-object-without-shadow.html [ ImageOnlyFailure ]
+webkit.org/b/91487 fast/dom/shadow/shadowdom-for-select-complex-shadow.html [ ImageOnlyFailure ]
+webkit.org/b/91487 fast/dom/shadow/shadowdom-for-select-without-shadow.html [ ImageOnlyFailure ]
+webkit.org/b/91488 fast/dom/shadow/shadowdom-for-output-only-shadow.html [ ImageOnlyFailure ]
+webkit.org/b/91489 fast/dom/shadow/shadowdom-for-fieldset-complex-shadow.html [ ImageOnlyFailure ]
+webkit.org/b/91489 fast/dom/shadow/shadowdom-for-fieldset-only-shadow.html [ ImageOnlyFailure ]
+
 #////////////////////////////////////////////////////////////////////////////////////////
 # End of Tests failing
 #////////////////////////////////////////////////////////////////////////////////////////

Added: trunk/LayoutTests/platform/gtk/fast/dom/shadow/form-in-shadow-expected.txt (0 => 129391)


--- trunk/LayoutTests/platform/gtk/fast/dom/shadow/form-in-shadow-expected.txt	                        (rev 0)
+++ trunk/LayoutTests/platform/gtk/fast/dom/shadow/form-in-shadow-expected.txt	2012-09-24 18:32:04 UTC (rev 129391)
@@ -0,0 +1,10 @@
+PASS obj.hidden is 'hidden'
+PASS obj.text is 'text'
+PASS obj.checkbox1 is 'on'
+PASS obj.checkbox2 is undefined.
+PASS obj.range is '50'
+PASS obj.textarea is 'textarea'
+PASS successfullyParsed is true
+
+TEST COMPLETE
+

Added: trunk/LayoutTests/platform/gtk/fast/dom/shadow/tab-order-iframe-and-shadow-expected.txt (0 => 129391)


--- trunk/LayoutTests/platform/gtk/fast/dom/shadow/tab-order-iframe-and-shadow-expected.txt	                        (rev 0)
+++ trunk/LayoutTests/platform/gtk/fast/dom/shadow/tab-order-iframe-and-shadow-expected.txt	2012-09-24 18:32:04 UTC (rev 129391)
@@ -0,0 +1,57 @@
+CONSOLE MESSAGE: line 104: ReferenceError: Can't find variable: log
+This tests that pressing Tab key should traverse into iframe and shadow tree, and pressing Shift-Tab should reverse the order.
+
+Should move from input-01 to input-13 in forward
+PASS
+Should move from input-13 to input-15 in forward
+PASS
+Should move from input-15 to input-02 in forward
+PASS
+Should move from input-02 to host-01/input-03 in forward
+PASS
+Should move from host-01/input-03 to input-04 in forward
+PASS
+Should move from input-04 to iframe/input-06 in forward
+PASS
+Should move from iframe/input-06 to iframe/host-02 in forward
+PASS
+Should move from iframe/host-02 to iframe/host-02/input-09 in forward
+PASS
+Should move from iframe/host-02/input-09 to iframe/host-02/input-08 in forward
+PASS
+Should move from iframe/host-02/input-08 to iframe/input-12 in forward
+PASS
+Should move from iframe/input-12 to iframe/input-11 in forward
+PASS
+Should move from iframe/input-11 to iframe/input-05 in forward
+PASS
+Should move from iframe/input-05 to input-14 in forward
+PASS
+Should move from input-14 to iframe/input-05 in backward
+PASS
+Should move from iframe/input-05 to iframe/input-11 in backward
+PASS
+Should move from iframe/input-11 to iframe/input-12 in backward
+PASS
+Should move from iframe/input-12 to iframe/host-02/input-08 in backward
+PASS
+Should move from iframe/host-02/input-08 to iframe/host-02/input-09 in backward
+PASS
+Should move from iframe/host-02/input-09 to iframe/host-02 in backward
+PASS
+Should move from iframe/host-02 to iframe/input-06 in backward
+PASS
+Should move from iframe/input-06 to input-04 in backward
+PASS
+Should move from input-04 to host-01/input-03 in backward
+PASS
+Should move from host-01/input-03 to input-02 in backward
+PASS
+Should move from input-02 to input-15 in backward
+PASS
+Should move from input-15 to input-13 in backward
+PASS
+Should move from input-13 to input-01 in backward
+PASS
+
+

Modified: trunk/Source/WebKit/gtk/ChangeLog (129390 => 129391)


--- trunk/Source/WebKit/gtk/ChangeLog	2012-09-24 18:29:02 UTC (rev 129390)
+++ trunk/Source/WebKit/gtk/ChangeLog	2012-09-24 18:32:04 UTC (rev 129391)
@@ -1,3 +1,18 @@
+2012-09-24  Zan Dobersek  <[email protected]>
+
+        [Gtk] Unskip the Shadow DOM layout tests
+        https://bugs.webkit.org/show_bug.cgi?id=90776
+
+        Reviewed by Ryosuke Niwa.
+
+        Add a method for enabling the Shadow DOM through RuntimeEnabledFeatures.
+        The method is called from DumpRenderTree when resetting state.
+
+        * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
+        (DumpRenderTreeSupportGtk::setShadowDOMEnabled):
+        * WebCoreSupport/DumpRenderTreeSupportGtk.h:
+        (DumpRenderTreeSupportGtk):
+
 2012-09-24  Joone Hur  <[email protected]>
 
         [GTK] Implement GraphicsLayer using Clutter

Modified: trunk/Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp (129390 => 129391)


--- trunk/Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp	2012-09-24 18:29:02 UTC (rev 129390)
+++ trunk/Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp	2012-09-24 18:32:04 UTC (rev 129391)
@@ -60,6 +60,7 @@
 #include "RenderTreeAsText.h"
 #include "RenderView.h"
 #include "ResourceLoadScheduler.h"
+#include "RuntimeEnabledFeatures.h"
 #include "SchemeRegistry.h"
 #include "SecurityOrigin.h"
 #include "SecurityPolicy.h"
@@ -701,6 +702,11 @@
     core(webView)->settings()->setCSSRegionsEnabled(enabled);
 }
 
+void DumpRenderTreeSupportGtk::setShadowDOMEnabled(bool enabled)
+{
+    RuntimeEnabledFeatures::setShadowDOMEnabled(enabled);
+}
+
 bool DumpRenderTreeSupportGtk::elementDoesAutoCompleteForElementWithId(WebKitWebFrame* frame, JSStringRef id)
 {
     Frame* coreFrame = core(frame);

Modified: trunk/Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.h (129390 => 129391)


--- trunk/Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.h	2012-09-24 18:29:02 UTC (rev 129390)
+++ trunk/Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.h	2012-09-24 18:32:04 UTC (rev 129391)
@@ -117,6 +117,7 @@
     static void setPageCacheSupportsPlugins(WebKitWebView*, bool enabled);
     static void setCSSGridLayoutEnabled(WebKitWebView*, bool enabled);
     static void setCSSRegionsEnabled(WebKitWebView*, bool enabled);
+    static void setShadowDOMEnabled(bool enabled);
 
     static void deliverAllMutationsIfNecessary();
     static void setDomainRelaxationForbiddenForURLScheme(bool forbidden, const char* urlScheme);

Modified: trunk/Tools/ChangeLog (129390 => 129391)


--- trunk/Tools/ChangeLog	2012-09-24 18:29:02 UTC (rev 129390)
+++ trunk/Tools/ChangeLog	2012-09-24 18:32:04 UTC (rev 129391)
@@ -1,5 +1,17 @@
 2012-09-24  Zan Dobersek  <[email protected]>
 
+        [Gtk] Unskip the Shadow DOM layout tests
+        https://bugs.webkit.org/show_bug.cgi?id=90776
+
+        Reviewed by Ryosuke Niwa.
+
+        Enable Shadow DOM through DumpRenderTreeSupport when resetting defaults in between tests.
+
+        * DumpRenderTree/gtk/DumpRenderTree.cpp:
+        (resetDefaultsToConsistentValues):
+
+2012-09-24  Zan Dobersek  <[email protected]>
+
         REGRESSION (r129211-r129218): http/tests/loading/redirect-with-no-location-crash.html failing on GTK Linux 64-bit Release WK2 (Tests)
         https://bugs.webkit.org/show_bug.cgi?id=97404
 

Modified: trunk/Tools/DumpRenderTree/gtk/DumpRenderTree.cpp (129390 => 129391)


--- trunk/Tools/DumpRenderTree/gtk/DumpRenderTree.cpp	2012-09-24 18:29:02 UTC (rev 129390)
+++ trunk/Tools/DumpRenderTree/gtk/DumpRenderTree.cpp	2012-09-24 18:32:04 UTC (rev 129391)
@@ -516,6 +516,7 @@
 
     DumpRenderTreeSupportGtk::setCSSGridLayoutEnabled(webView, false);
     DumpRenderTreeSupportGtk::setCSSRegionsEnabled(webView, true);
+    DumpRenderTreeSupportGtk::setShadowDOMEnabled(true);
 }
 
 static bool useLongRunningServerMode(int argc, char *argv[])
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to