Diff
Modified: trunk/LayoutTests/ChangeLog (129396 => 129397)
--- trunk/LayoutTests/ChangeLog 2012-09-24 18:52:21 UTC (rev 129396)
+++ trunk/LayoutTests/ChangeLog 2012-09-24 18:56:19 UTC (rev 129397)
@@ -1,3 +1,15 @@
+2012-09-24 Tommy Widenflycht <[email protected]>
+
+ MediaStream API: Fix the incorrectly spelled RTCPeerConnection::onnegotiationneeded callback
+ https://bugs.webkit.org/show_bug.cgi?id=97456
+
+ Reviewed by Adam Barth.
+
+ Renamed onnegotationneeded to onnegotiationneeded.
+
+ * fast/mediastream/RTCPeerConnection-onnegotiationneeded-expected.txt:
+ * fast/mediastream/RTCPeerConnection-onnegotiationneeded.html:
+
2012-09-24 Dominik Röttsches <[email protected]>
[EFL][DRT] Enable Regions support
Modified: trunk/LayoutTests/fast/mediastream/RTCPeerConnection-onnegotiationneeded-expected.txt (129396 => 129397)
--- trunk/LayoutTests/fast/mediastream/RTCPeerConnection-onnegotiationneeded-expected.txt 2012-09-24 18:52:21 UTC (rev 129396)
+++ trunk/LayoutTests/fast/mediastream/RTCPeerConnection-onnegotiationneeded-expected.txt 2012-09-24 18:56:19 UTC (rev 129397)
@@ -4,7 +4,7 @@
PASS Got a stream.
-PASS onNegotationNeeded was called.
+PASS onNegotiationNeeded was called.
PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/LayoutTests/fast/mediastream/RTCPeerConnection-onnegotiationneeded.html (129396 => 129397)
--- trunk/LayoutTests/fast/mediastream/RTCPeerConnection-onnegotiationneeded.html 2012-09-24 18:52:21 UTC (rev 129396)
+++ trunk/LayoutTests/fast/mediastream/RTCPeerConnection-onnegotiationneeded.html 2012-09-24 18:56:19 UTC (rev 129397)
@@ -24,8 +24,8 @@
}
}
-function onNegotationNeeded(event) {
- testPassed('onNegotationNeeded was called.');
+function onNegotiationNeeded(event) {
+ testPassed('onNegotiationNeeded was called.');
finishJSTest();
}
@@ -35,7 +35,7 @@
stream = s;
pc = new webkitRTCPeerConnection(null, null);
- pc._onnegotationneeded_ = onNegotationNeeded;
+ pc._onnegotiationneeded_ = onNegotiationNeeded;
pc.addStream(stream);
}
Modified: trunk/Source/WebCore/ChangeLog (129396 => 129397)
--- trunk/Source/WebCore/ChangeLog 2012-09-24 18:52:21 UTC (rev 129396)
+++ trunk/Source/WebCore/ChangeLog 2012-09-24 18:56:19 UTC (rev 129397)
@@ -1,3 +1,22 @@
+2012-09-24 Tommy Widenflycht <[email protected]>
+
+ MediaStream API: Fix the incorrectly spelled RTCPeerConnection::onnegotiationneeded callback
+ https://bugs.webkit.org/show_bug.cgi?id=97456
+
+ Reviewed by Adam Barth.
+
+ Renamed onnegotationneeded to onnegotiationneeded.
+
+ Existing test updated.
+
+ * Modules/mediastream/RTCPeerConnection.cpp:
+ (WebCore::RTCPeerConnection::negotiationNeeded):
+ * Modules/mediastream/RTCPeerConnection.h:
+ (RTCPeerConnection):
+ * Modules/mediastream/RTCPeerConnection.idl:
+ * dom/EventNames.h:
+ (WebCore):
+
2012-09-24 Peter Beverloo <[email protected]>
Android's mock scrollbars shows up as a difference in layout test results
Modified: trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp (129396 => 129397)
--- trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp 2012-09-24 18:52:21 UTC (rev 129396)
+++ trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp 2012-09-24 18:56:19 UTC (rev 129397)
@@ -393,7 +393,7 @@
void RTCPeerConnection::negotiationNeeded()
{
- dispatchEvent(Event::create(eventNames().negotationneededEvent, false, false));
+ dispatchEvent(Event::create(eventNames().negotiationneededEvent, false, false));
}
void RTCPeerConnection::didGenerateIceCandidate(PassRefPtr<RTCIceCandidateDescriptor> iceCandidateDescriptor)
Modified: trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.h (129396 => 129397)
--- trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.h 2012-09-24 18:52:21 UTC (rev 129396)
+++ trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.h 2012-09-24 18:56:19 UTC (rev 129397)
@@ -86,7 +86,7 @@
void close(ExceptionCode&);
- DEFINE_ATTRIBUTE_EVENT_LISTENER(negotationneeded);
+ DEFINE_ATTRIBUTE_EVENT_LISTENER(negotiationneeded);
DEFINE_ATTRIBUTE_EVENT_LISTENER(icecandidate);
DEFINE_ATTRIBUTE_EVENT_LISTENER(open);
DEFINE_ATTRIBUTE_EVENT_LISTENER(statechange);
Modified: trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.idl (129396 => 129397)
--- trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.idl 2012-09-24 18:52:21 UTC (rev 129396)
+++ trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.idl 2012-09-24 18:56:19 UTC (rev 129397)
@@ -75,7 +75,7 @@
void close()
raises(DOMException);
- attribute EventListener onnegotationneeded;
+ attribute EventListener onnegotiationneeded;
attribute EventListener onicecandidate;
attribute EventListener onopen;
attribute EventListener onstatechange;
Modified: trunk/Source/WebCore/dom/EventNames.h (129396 => 129397)
--- trunk/Source/WebCore/dom/EventNames.h 2012-09-24 18:52:21 UTC (rev 129396)
+++ trunk/Source/WebCore/dom/EventNames.h 2012-09-24 18:56:19 UTC (rev 129397)
@@ -229,7 +229,7 @@
macro(unmute) \
macro(icechange) \
macro(icecandidate) \
- macro(negotationneeded) \
+ macro(negotiationneeded) \
\
macro(show) \
\
