Title: [129533] trunk/Source/WebKit2
- Revision
- 129533
- Author
- [email protected]
- Date
- 2012-09-25 11:33:50 -0700 (Tue, 25 Sep 2012)
Log Message
[GTK] Don't kill automatically the web process when the ui process finishes
https://bugs.webkit.org/show_bug.cgi?id=97580
Reviewed by Martin Robinson.
We use prctl(PR_SET_PDEATHSIG, SIGKILL); in linux to make sure the
web process is killed when the UI process finishes. This is not
needed any more since now the web process stops the main loop when
the connection with the UI process is closed in
WebProcess::didClose(). This approach is better because it works
for any platform and makes the web process finish normally from
main().
* UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:
(WebKit::childSetupFunction): Don't call prctl(PR_SET_PDEATHSIG,
SIGKILL) in the child process.
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (129532 => 129533)
--- trunk/Source/WebKit2/ChangeLog 2012-09-25 18:30:34 UTC (rev 129532)
+++ trunk/Source/WebKit2/ChangeLog 2012-09-25 18:33:50 UTC (rev 129533)
@@ -1,3 +1,22 @@
+2012-09-25 Carlos Garcia Campos <[email protected]>
+
+ [GTK] Don't kill automatically the web process when the ui process finishes
+ https://bugs.webkit.org/show_bug.cgi?id=97580
+
+ Reviewed by Martin Robinson.
+
+ We use prctl(PR_SET_PDEATHSIG, SIGKILL); in linux to make sure the
+ web process is killed when the UI process finishes. This is not
+ needed any more since now the web process stops the main loop when
+ the connection with the UI process is closed in
+ WebProcess::didClose(). This approach is better because it works
+ for any platform and makes the web process finish normally from
+ main().
+
+ * UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:
+ (WebKit::childSetupFunction): Don't call prctl(PR_SET_PDEATHSIG,
+ SIGKILL) in the child process.
+
2012-09-25 Benjamin Poulain <[email protected]>
Build fix, GeolocationClientMock should not be included by WebProcess InjectedBundle
Modified: trunk/Source/WebKit2/UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp (129532 => 129533)
--- trunk/Source/WebKit2/UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp 2012-09-25 18:30:34 UTC (rev 129532)
+++ trunk/Source/WebKit2/UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp 2012-09-25 18:33:50 UTC (rev 129533)
@@ -60,11 +60,6 @@
// Make child process inherit parent's locale.
g_setenv("LC_ALL", setlocale(LC_ALL, 0), TRUE);
-
-#if OS(LINUX)
- // Kill child process when parent dies.
- prctl(PR_SET_PDEATHSIG, SIGKILL);
-#endif
}
static void childFinishedFunction(GPid, gint status, gpointer userData)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
