Title: [129587] trunk/Source/WebKit/blackberry
- Revision
- 129587
- Author
- [email protected]
- Date
- 2012-09-25 19:55:05 -0700 (Tue, 25 Sep 2012)
Log Message
Fat Fingers doesn't work on non-scrollable pages.
PR #209609
https://bugs.webkit.org/show_bug.cgi?id=97607
Patch by Genevieve Mak <[email protected]> on 2012-09-25
Reviewed by Antonio Gomes.
Only bypass Fat Fingers and use the actual touch point if its specifically
requested and the page has a mouse move listener or if using the Touch Event
Mode meta-tag.
* WebKitSupport/TouchEventHandler.cpp:
(BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
Modified Paths
Diff
Modified: trunk/Source/WebKit/blackberry/ChangeLog (129586 => 129587)
--- trunk/Source/WebKit/blackberry/ChangeLog 2012-09-26 02:27:54 UTC (rev 129586)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2012-09-26 02:55:05 UTC (rev 129587)
@@ -1,3 +1,18 @@
+2012-09-25 Genevieve Mak <[email protected]>
+
+ Fat Fingers doesn't work on non-scrollable pages.
+ PR #209609
+ https://bugs.webkit.org/show_bug.cgi?id=97607
+
+ Reviewed by Antonio Gomes.
+
+ Only bypass Fat Fingers and use the actual touch point if its specifically
+ requested and the page has a mouse move listener or if using the Touch Event
+ Mode meta-tag.
+
+ * WebKitSupport/TouchEventHandler.cpp:
+ (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
+
2012-09-25 Rob Buis <[email protected]>
[BlackBerry] Make COMPUTED_GOTO part of the HAVE section
Modified: trunk/Source/WebKit/blackberry/WebKitSupport/TouchEventHandler.cpp (129586 => 129587)
--- trunk/Source/WebKit/blackberry/WebKitSupport/TouchEventHandler.cpp 2012-09-26 02:27:54 UTC (rev 129586)
+++ trunk/Source/WebKit/blackberry/WebKitSupport/TouchEventHandler.cpp 2012-09-26 02:55:05 UTC (rev 129587)
@@ -257,7 +257,9 @@
m_webPage->m_inputHandler->notifyClientOfKeyboardVisibilityChange(true);
IntPoint adjustedPoint;
- if (m_convertTouchToMouse || !useFatFingers) {
+ // always use the true touch point if using the meta-tag, otherwise only use it if we sent mouse moves
+ // to the page and its requested.
+ if (pureWithMouseConversion || (m_convertTouchToMouse && !useFatFingers)) {
adjustedPoint = point.m_pos;
m_convertTouchToMouse = pureWithMouseConversion;
} else // Fat finger point in viewport coordinates.
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
