Title: [129591] trunk/Source/WebCore
- Revision
- 129591
- Author
- [email protected]
- Date
- 2012-09-25 21:03:16 -0700 (Tue, 25 Sep 2012)
Log Message
[Forms] We should disconnect DateTimeEditElement and DateTimeFieldElement on layout()
https://bugs.webkit.org/show_bug.cgi?id=97438
Reviewed by Kent Tamura.
This patch is for code cleanup. It is better to disconnect DateTimeFieldElement
from DateTimeEditElement when DateTimeEditElement doesn't have
pointers to DateTimeFieldElement.
No new tests. This patch doesn't change behavior.
* html/shadow/DateTimeEditElement.cpp:
(WebCore::DateTimeEditElement::resetFields): Changed to call DateTimeFieldElement::removeEventHandler()
for existing fields to disconnect DateTimeEditElement and DateTimeFieldElement.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (129590 => 129591)
--- trunk/Source/WebCore/ChangeLog 2012-09-26 03:38:54 UTC (rev 129590)
+++ trunk/Source/WebCore/ChangeLog 2012-09-26 04:03:16 UTC (rev 129591)
@@ -1,3 +1,20 @@
+2012-09-25 Yoshifumi Inoue <[email protected]>
+
+ [Forms] We should disconnect DateTimeEditElement and DateTimeFieldElement on layout()
+ https://bugs.webkit.org/show_bug.cgi?id=97438
+
+ Reviewed by Kent Tamura.
+
+ This patch is for code cleanup. It is better to disconnect DateTimeFieldElement
+ from DateTimeEditElement when DateTimeEditElement doesn't have
+ pointers to DateTimeFieldElement.
+
+ No new tests. This patch doesn't change behavior.
+
+ * html/shadow/DateTimeEditElement.cpp:
+ (WebCore::DateTimeEditElement::resetFields): Changed to call DateTimeFieldElement::removeEventHandler()
+ for existing fields to disconnect DateTimeEditElement and DateTimeFieldElement.
+
2012-09-25 Bear Travis <[email protected]>
[CSS Exclusions] shape-inside line segment layout should be based on line position and height
Modified: trunk/Source/WebCore/html/shadow/DateTimeEditElement.cpp (129590 => 129591)
--- trunk/Source/WebCore/html/shadow/DateTimeEditElement.cpp 2012-09-26 03:38:54 UTC (rev 129590)
+++ trunk/Source/WebCore/html/shadow/DateTimeEditElement.cpp 2012-09-26 04:03:16 UTC (rev 129591)
@@ -374,6 +374,8 @@
void DateTimeEditElement::resetFields()
{
+ for (size_t fieldIndex = 0; fieldIndex < m_fields.size(); ++fieldIndex)
+ m_fields[fieldIndex]->removeEventHandler();
m_fields.shrink(0);
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
