Title: [129634] trunk/Tools
- Revision
- 129634
- Author
- [email protected]
- Date
- 2012-09-26 07:07:42 -0700 (Wed, 26 Sep 2012)
Log Message
[BlackBerry] [DRT] eventSender.keyDown() doesn't support Ctrl key modifier
https://bugs.webkit.org/show_bug.cgi?id=97665
Patch by Xiaobo Wang <[email protected]> on 2012-09-26
Reviewed by Rob Buis.
This patch fixes test fast/forms/input-text-option-delete.html.
* DumpRenderTree/blackberry/EventSender.cpp:
(keyDownCallback):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (129633 => 129634)
--- trunk/Tools/ChangeLog 2012-09-26 14:05:51 UTC (rev 129633)
+++ trunk/Tools/ChangeLog 2012-09-26 14:07:42 UTC (rev 129634)
@@ -1,3 +1,15 @@
+2012-09-26 Xiaobo Wang <[email protected]>
+
+ [BlackBerry] [DRT] eventSender.keyDown() doesn't support Ctrl key modifier
+ https://bugs.webkit.org/show_bug.cgi?id=97665
+
+ Reviewed by Rob Buis.
+
+ This patch fixes test fast/forms/input-text-option-delete.html.
+
+ * DumpRenderTree/blackberry/EventSender.cpp:
+ (keyDownCallback):
+
2012-09-26 Dinu Jacob <[email protected]>
Unreviewed. Adding myself as a committer.
Modified: trunk/Tools/DumpRenderTree/blackberry/EventSender.cpp (129633 => 129634)
--- trunk/Tools/DumpRenderTree/blackberry/EventSender.cpp 2012-09-26 14:05:51 UTC (rev 129633)
+++ trunk/Tools/DumpRenderTree/blackberry/EventSender.cpp 2012-09-26 14:07:42 UTC (rev 129634)
@@ -151,6 +151,7 @@
static const JSStringRef lengthProperty = JSStringCreateWithUTF8CString("length");
bool needsAltKeyModifier = false;
+ bool needsCtrlKeyModifier = false;
if (argumentCount > 1) {
if (JSObjectRef modifiersArray = JSValueToObject(context, arguments[1], 0)) {
int modifiersCount = JSValueToNumber(context, JSObjectGetProperty(context, modifiersArray, lengthProperty, 0), 0);
@@ -160,6 +161,8 @@
needsShiftKeyModifier = true;
else if (JSStringIsEqualToUTF8CString(string, "altKey"))
needsAltKeyModifier = true;
+ else if (JSStringIsEqualToUTF8CString(string, "ctrlKey"))
+ needsCtrlKeyModifier = true;
JSStringRelease(string);
}
}
@@ -172,6 +175,8 @@
modifiers |= KEYMOD_SHIFT;
if (needsAltKeyModifier)
modifiers |= KEYMOD_ALT;
+ if (needsCtrlKeyModifier)
+ modifiers |= KEYMOD_CTRL;
page->keyEvent(BlackBerry::Platform::KeyboardEvent(charCode, BlackBerry::Platform::KeyboardEvent::KeyChar, modifiers));
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
