Title: [129754] trunk/Source/WebCore
- Revision
- 129754
- Author
- [email protected]
- Date
- 2012-09-27 04:46:03 -0700 (Thu, 27 Sep 2012)
Log Message
[EFL] Remove duplicated CSS between mediaControlsEfl.css and mediaControlsEflFullscreen.css
https://bugs.webkit.org/show_bug.cgi?id=97770
Patch by Christophe Dumez <[email protected]> on 2012-09-27
Reviewed by Kenneth Rohde Christiansen.
Some CSS rules were duplicated between mediaControlsEfl.css and mediaControlsEflFullscreen.css
for no reason. This is an issue because it is easy to update mediaControlsEfl.css and forget
to make the same update to mediaControlsEflFullscreen.css. As a matter of fact, the timeline
display in fullscreen is currently off by a few pixels because its fullscreen CSS is not in
sync with what is in mediaControlsEfl.css.
We need to include in mediaControlsEflFullscreen.css only the CSS rules that are specific to
fullscreen mode, that is to say, the hiding of some controls.
No new tests, no behavior change for layout tests.
* css/mediaControlsEflFullscreen.css:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (129753 => 129754)
--- trunk/Source/WebCore/ChangeLog 2012-09-27 11:39:58 UTC (rev 129753)
+++ trunk/Source/WebCore/ChangeLog 2012-09-27 11:46:03 UTC (rev 129754)
@@ -1,3 +1,23 @@
+2012-09-27 Christophe Dumez <[email protected]>
+
+ [EFL] Remove duplicated CSS between mediaControlsEfl.css and mediaControlsEflFullscreen.css
+ https://bugs.webkit.org/show_bug.cgi?id=97770
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ Some CSS rules were duplicated between mediaControlsEfl.css and mediaControlsEflFullscreen.css
+ for no reason. This is an issue because it is easy to update mediaControlsEfl.css and forget
+ to make the same update to mediaControlsEflFullscreen.css. As a matter of fact, the timeline
+ display in fullscreen is currently off by a few pixels because its fullscreen CSS is not in
+ sync with what is in mediaControlsEfl.css.
+
+ We need to include in mediaControlsEflFullscreen.css only the CSS rules that are specific to
+ fullscreen mode, that is to say, the hiding of some controls.
+
+ No new tests, no behavior change for layout tests.
+
+ * css/mediaControlsEflFullscreen.css:
+
2012-09-27 Vsevolod Vlasov <[email protected]>
Web Inspector: Open resource dialog should assume implicit wildcard in the beginning of the query.
Modified: trunk/Source/WebCore/css/mediaControlsEflFullscreen.css (129753 => 129754)
--- trunk/Source/WebCore/css/mediaControlsEflFullscreen.css 2012-09-27 11:39:58 UTC (rev 129753)
+++ trunk/Source/WebCore/css/mediaControlsEflFullscreen.css 2012-09-27 11:46:03 UTC (rev 129754)
@@ -24,20 +24,6 @@
/* EFLWebKit media controls for fullscreen. */
-video:-webkit-full-screen::-webkit-media-controls-panel {
- display: -webkit-box;
- -webkit-box-orient: horizontal;
- -webkit-box-align: center;
- -webkit-user-select: none;
- position: relative;
- bottom: 0;
- width: 100%;
- z-index: 0;
- overflow: hidden;
- height: 20px;
- text-align: right;
-}
-
video:-webkit-full-screen:-webkit-full-page-media::-webkit-media-controls-panel {
display: none;
}
@@ -46,53 +32,10 @@
display: none;
}
-video:-webkit-full-screen::-webkit-media-controls-play-button {
- -webkit-appearance: media-play-button;
- display: -webkit-box;
- width: 20px;
- height: 20px;
- background-color: initial;
- border: initial;
- color: inherit;
-}
-
-video:-webkit-full-screen::-webkit-media-controls-timeline-container {
- -webkit-appearance: media-controls-background;
- display: -webkit-box;
- -webkit-box-orient: horizontal;
- -webkit-box-align: center;
- -webkit-box-pack: end;
- -webkit-box-flex: 1;
- -webkit-user-select: none;
- height: 20px;
-}
-
-video:-webkit-full-screen::-webkit-media-controls-current-time-display {
- -webkit-appearance: media-current-time-display;
- -webkit-user-select: none;
- display: inline-block;
- height: 20px;
- padding: 4px;
- text-align: center;
- font-size: 10px;
-}
-
video:-webkit-full-screen::-webkit-media-controls-time-remaining-display {
display: none;
}
-video:-webkit-full-screen::-webkit-media-controls-timeline {
- -webkit-appearance: media-slider;
- display: -webkit-box;
- -webkit-box-flex: 1;
- height: 20px;
- padding: 0px 2px;
- background-color: initial;
- border: initial;
- color: inherit;
- margin: initial;
-}
-
video:-webkit-full-screen::-webkit-media-controls-volume-slider-container {
-webkit-appearance: media-volume-slider-container;
display: none;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
