Title: [129861] trunk/Source/WebCore
- Revision
- 129861
- Author
- morr...@google.com
- Date
- 2012-09-28 01:41:22 -0700 (Fri, 28 Sep 2012)
Log Message
Move Shadow DOM inspection feature out from experiments
https://bugs.webkit.org/show_bug.cgi?id=94274
Reviewed by Pavel Feldman.
This chagne turns the showShadowDOM experiments into a settings,
adding aSettingsScreen entry for that.
* English.lproj/localizedStrings.js:
* inspector/front-end/DOMAgent.js:
* inspector/front-end/Settings.js:
(WebInspector.ExperimentsSettings):
* inspector/front-end/SettingsScreen.js:
(WebInspector.GenericSettingsTab):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (129860 => 129861)
--- trunk/Source/WebCore/ChangeLog 2012-09-28 08:29:33 UTC (rev 129860)
+++ trunk/Source/WebCore/ChangeLog 2012-09-28 08:41:22 UTC (rev 129861)
@@ -1,3 +1,20 @@
+2012-09-28 MORITA Hajime <morr...@google.com>
+
+ Move Shadow DOM inspection feature out from experiments
+ https://bugs.webkit.org/show_bug.cgi?id=94274
+
+ Reviewed by Pavel Feldman.
+
+ This chagne turns the showShadowDOM experiments into a settings,
+ adding aSettingsScreen entry for that.
+
+ * English.lproj/localizedStrings.js:
+ * inspector/front-end/DOMAgent.js:
+ * inspector/front-end/Settings.js:
+ (WebInspector.ExperimentsSettings):
+ * inspector/front-end/SettingsScreen.js:
+ (WebInspector.GenericSettingsTab):
+
2012-09-27 Kent Tamura <tk...@chromium.org>
Use Localizer in PagePopupController
Modified: trunk/Source/WebCore/English.lproj/localizedStrings.js (129860 => 129861)
--- trunk/Source/WebCore/English.lproj/localizedStrings.js 2012-09-28 08:29:33 UTC (rev 129860)
+++ trunk/Source/WebCore/English.lproj/localizedStrings.js 2012-09-28 08:41:22 UTC (rev 129861)
@@ -389,6 +389,7 @@
localizedStrings["Show counts and sizes as percentages."] = "Show counts and sizes as percentages.";
localizedStrings["Show function definition"] = "Show function definition";
localizedStrings["Show inherited"] = "Show inherited";
+localizedStrings["Show Shadow DOM"] = "Show Shadow DOM";
localizedStrings["Show the records that are shorter than %s"] = "Show the records that are shorter than %s";
localizedStrings["Show times as percentages."] = "Show times as percentages.";
localizedStrings["Show total and self times as percentages."] = "Show total and self times as percentages.";
Modified: trunk/Source/WebCore/inspector/front-end/DOMAgent.js (129860 => 129861)
--- trunk/Source/WebCore/inspector/front-end/DOMAgent.js 2012-09-28 08:29:33 UTC (rev 129860)
+++ trunk/Source/WebCore/inspector/front-end/DOMAgent.js 2012-09-28 08:41:22 UTC (rev 129861)
@@ -76,7 +76,7 @@
this._renumber();
}
- if (payload.shadowRoots && WebInspector.experimentsSettings.showShadowDOM.isEnabled()) {
+ if (payload.shadowRoots && WebInspector.settings.showShadowDOM.get()) {
for (var i = 0; i < payload.shadowRoots.length; ++i) {
var root = payload.shadowRoots[i];
var node = new WebInspector.DOMNode(this._domAgent, this.ownerDocument, true, root);
Modified: trunk/Source/WebCore/inspector/front-end/Settings.js (129860 => 129861)
--- trunk/Source/WebCore/inspector/front-end/Settings.js 2012-09-28 08:29:33 UTC (rev 129860)
+++ trunk/Source/WebCore/inspector/front-end/Settings.js 2012-09-28 08:41:22 UTC (rev 129861)
@@ -95,6 +95,7 @@
this.dockToRight = this.createSetting("dockToRight", false);
this.emulateTouchEvents = this.createSetting("emulateTouchEvents", false);
this.showPaintRects = this.createSetting("showPaintRects", false);
+ this.showShadowDOM = this.createSetting("showShadowDOM", false);
this.zoomLevel = this.createSetting("zoomLevel", 0);
this.savedURLs = this.createSetting("savedURLs", {});
this._javascript_Disabled = this.createSetting("_javascript_Disabled", false);
@@ -186,7 +187,6 @@
this._enabledForTest = {};
// Add currently running experiments here.
- this.showShadowDOM = this._createExperiment("showShadowDOM", "Show shadow DOM");
this.snippetsSupport = this._createExperiment("snippetsSupport", "Snippets support");
this.nativeMemorySnapshots = this._createExperiment("nativeMemorySnapshots", "Native memory profiling");
this.liveNativeMemoryChart = this._createExperiment("liveNativeMemoryChart", "Live native memory chart");
Modified: trunk/Source/WebCore/inspector/front-end/SettingsScreen.js (129860 => 129861)
--- trunk/Source/WebCore/inspector/front-end/SettingsScreen.js 2012-09-28 08:29:33 UTC (rev 129860)
+++ trunk/Source/WebCore/inspector/front-end/SettingsScreen.js 2012-09-28 08:41:22 UTC (rev 129861)
@@ -268,6 +268,7 @@
[ WebInspector.Color.Format.HSL, "HSL: hsl(300, 80%, 90%)" ] ], WebInspector.settings.colorFormat));
p.appendChild(this._createCheckboxSetting(WebInspector.UIString("Show user agent styles"), WebInspector.settings.showUserAgentStyles));
p.appendChild(this._createCheckboxSetting(WebInspector.UIString("Word wrap"), WebInspector.settings.domWordWrap));
+ p.appendChild(this._createCheckboxSetting(WebInspector.UIString("Show Shadow DOM"), WebInspector.settings.showShadowDOM));
p = this._appendSection(WebInspector.UIString("Rendering"));
p.appendChild(this._createCheckboxSetting(WebInspector.UIString("Show paint rectangles"), WebInspector.settings.showPaintRects));
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
