Title: [129874] trunk
Revision
129874
Author
[email protected]
Date
2012-09-28 04:15:01 -0700 (Fri, 28 Sep 2012)

Log Message

[EFL][DRT] EFL DRT should disable visited links tracking by default
https://bugs.webkit.org/show_bug.cgi?id=97881

Patch by Mikhail Pozdnyakov <[email protected]> on 2012-09-28
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit/efl:

Added aux DumpRenderTreeSupportEfl::setShouldTrackVisitedLinks() function.

* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::setShouldTrackVisitedLinks):
* WebCoreSupport/DumpRenderTreeSupportEfl.h:

Tools:

Visited links tracking is disabled by default for each test.

* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::resetDefaultsToConsistentValues):

LayoutTests:

Rebased fast/block/float/float-in-float-hit-testing.html and unskipped it for EFL WK2.

* platform/efl-wk2/TestExpectations:
* platform/efl/fast/block/float/float-in-float-hit-testing-expected.png:
* platform/efl/fast/block/float/float-in-float-hit-testing-expected.txt:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (129873 => 129874)


--- trunk/LayoutTests/ChangeLog	2012-09-28 10:59:32 UTC (rev 129873)
+++ trunk/LayoutTests/ChangeLog	2012-09-28 11:15:01 UTC (rev 129874)
@@ -1,3 +1,16 @@
+2012-09-28  Mikhail Pozdnyakov  <[email protected]>
+
+        [EFL][DRT] EFL DRT should disable visited links tracking by default
+        https://bugs.webkit.org/show_bug.cgi?id=97881
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        Rebased fast/block/float/float-in-float-hit-testing.html and unskipped it for EFL WK2.
+
+        * platform/efl-wk2/TestExpectations:
+        * platform/efl/fast/block/float/float-in-float-hit-testing-expected.png:
+        * platform/efl/fast/block/float/float-in-float-hit-testing-expected.txt:
+
 2012-09-28  Zan Dobersek  <[email protected]>
 
         Unreviewed GTK gardening.

Modified: trunk/LayoutTests/platform/efl/fast/block/float/float-in-float-hit-testing-expected.png


(Binary files differ)

Modified: trunk/LayoutTests/platform/efl/fast/block/float/float-in-float-hit-testing-expected.txt (129873 => 129874)


--- trunk/LayoutTests/platform/efl/fast/block/float/float-in-float-hit-testing-expected.txt	2012-09-28 10:59:32 UTC (rev 129873)
+++ trunk/LayoutTests/platform/efl/fast/block/float/float-in-float-hit-testing-expected.txt	2012-09-28 11:15:01 UTC (rev 129874)
@@ -19,7 +19,7 @@
             text run at (100,85) width 4: " "
           RenderBR {BR} at (0,0) size 0x0
           RenderBlock (floating) {H1} at (0,170) size 245x115
-            RenderInline {A} at (0,0) size 245x112 [color=#551A8B]
+            RenderInline {A} at (0,0) size 245x112 [color=#0000EE]
               RenderText {#text} at (0,1) size 245x112
                 text run at (0,1) width 245: "PASS"
           RenderText {#text} at (0,0) size 0x0

Modified: trunk/LayoutTests/platform/efl-wk2/TestExpectations (129873 => 129874)


--- trunk/LayoutTests/platform/efl-wk2/TestExpectations	2012-09-28 10:59:32 UTC (rev 129873)
+++ trunk/LayoutTests/platform/efl-wk2/TestExpectations	2012-09-28 11:15:01 UTC (rev 129874)
@@ -1,5 +1,8 @@
 # We divide the EFL WK2 test expectations into several categories:
-# 1. TESTS EXPECTED TO FAIL
+# 1. PASSING TESTS
+#    Test cases that pass for EFL WK2 but are skipped in a top-level TestExpectations file.
+
+# 2. TESTS EXPECTED TO FAIL
 #    Test cases related to features that we don't expect to be activated for EFL WK2 since
 #    the feature implementation in WebKit2 is missing or not complete yet.
 #    If test cases related to a feature cannot be activated since e.g.
@@ -10,11 +13,11 @@
 #    If in doubt, please discuss on webkit-efl mailing list whether a set of test cases
 #    should be moved here.
 
-# 2. CRASHES
+# 3. CRASHES
 
-# 3. FLAKY TESTS
+# 4. FLAKY TESTS
 
-# 4. FAILING TESTS
+# 5. FAILING TESTS
 #    * Interim failures that are moved here for further investigation as a result of daily
 #      gardening. They should be analysed quickly and either resolved or moved to 1).
 #    * Remaining failures that are moved here until further investigation after
@@ -23,6 +26,12 @@
 #      a relevant compile time feature can be enabled for EFL.
 
 #////////////////////////////////////////////////////////////////////////////////////////
+# PASSING TESTS
+#////////////////////////////////////////////////////////////////////////////////////////
+
+fast/history/multiple-classes-visited.html [ Pass ]
+
+#////////////////////////////////////////////////////////////////////////////////////////
 # TESTS EXPECTED TO FAIL
 #////////////////////////////////////////////////////////////////////////////////////////
 
@@ -154,6 +163,9 @@
 # Affects multiple platforms.
 webkit.org/b/90980 fast/forms/textarea/textarea-state-restore.html [ Failure Pass ]
 
+# Flaky, probably because the result is sometimes taken before data about visited link have passed through IPC.
+webkit.org/b/81797 fast/history/visited-link-background-color.html [ Failure  Pass ]
+
 #////////////////////////////////////////////////////////////////////////////////////////
 # FAILING TESTS
 #////////////////////////////////////////////////////////////////////////////////////////
@@ -189,12 +201,7 @@
 # WebKitTestRunner needs an implementation for testRunner.setStorageDatabaseIdleInterval
 webkit.org/b/93982 storage/domstorage/storage-close-database-on-idle.html [ Failure ]
 
-# Visited link color is incorrect
-Bug(EFL) fast/block/float/float-in-float-hit-testing.html [ Failure ]
-webkit.org/b/81797 fast/history/visited-link-background-color.html [ Failure ]
-
 # Unclassified failures
-Bug(EFL) fast/block/float/float-in-float-hit-testing.html [ Failure ]
 Bug(EFL) fast/dom/Window/mozilla-focus-blur.html [ Failure ]
 Bug(EFL) fast/replaced/no-focus-ring-embed.html [ Failure ]
 Bug(EFL) fast/replaced/no-focus-ring-object.html [ Failure ]

Modified: trunk/Source/WebKit/efl/ChangeLog (129873 => 129874)


--- trunk/Source/WebKit/efl/ChangeLog	2012-09-28 10:59:32 UTC (rev 129873)
+++ trunk/Source/WebKit/efl/ChangeLog	2012-09-28 11:15:01 UTC (rev 129874)
@@ -1,3 +1,16 @@
+2012-09-28  Mikhail Pozdnyakov  <[email protected]>
+
+        [EFL][DRT] EFL DRT should disable visited links tracking by default
+        https://bugs.webkit.org/show_bug.cgi?id=97881
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        Added aux DumpRenderTreeSupportEfl::setShouldTrackVisitedLinks() function.
+
+        * WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
+        (DumpRenderTreeSupportEfl::setShouldTrackVisitedLinks):
+        * WebCoreSupport/DumpRenderTreeSupportEfl.h:
+
 2012-09-27  Christophe Dumez  <[email protected]>
 
         [EFL] No way to exit video fullscreen mode once entered

Modified: trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp (129873 => 129874)


--- trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp	2012-09-28 10:59:32 UTC (rev 129873)
+++ trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp	2012-09-28 11:15:01 UTC (rev 129874)
@@ -568,6 +568,11 @@
     WebCore::resourceLoadScheduler()->setSerialLoadingEnabled(enabled);
 }
 
+void DumpRenderTreeSupportEfl::setShouldTrackVisitedLinks(bool shouldTrack)
+{
+    WebCore::PageGroup::setShouldTrackVisitedLinks(shouldTrack);
+}
+
 void DumpRenderTreeSupportEfl::sendWebIntentResponse(Ewk_Intent_Request* request, JSStringRef response)
 {
 #if ENABLE(WEB_INTENTS)

Modified: trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.h (129873 => 129874)


--- trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.h	2012-09-28 10:59:32 UTC (rev 129873)
+++ trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.h	2012-09-28 11:15:01 UTC (rev 129874)
@@ -107,6 +107,7 @@
     static void setAuthorAndUserStylesEnabled(Evas_Object* ewkView, bool);
     static void setDomainRelaxationForbiddenForURLScheme(bool forbidden, const String& scheme);
     static void setSerializeHTTPLoads(bool);
+    static void setShouldTrackVisitedLinks(bool);
     
     // Web Intents
     static void sendWebIntentResponse(Ewk_Intent_Request*, JSStringRef response);

Modified: trunk/Tools/ChangeLog (129873 => 129874)


--- trunk/Tools/ChangeLog	2012-09-28 10:59:32 UTC (rev 129873)
+++ trunk/Tools/ChangeLog	2012-09-28 11:15:01 UTC (rev 129874)
@@ -1,3 +1,15 @@
+2012-09-28  Mikhail Pozdnyakov  <[email protected]>
+
+        [EFL][DRT] EFL DRT should disable visited links tracking by default
+        https://bugs.webkit.org/show_bug.cgi?id=97881
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        Visited links tracking is disabled by default for each test.
+
+        * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
+        (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
+
 2012-09-28  Gyuyoung Kim  <[email protected]>
 
         Unreviewed, rolling out r129863.

Modified: trunk/Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp (129873 => 129874)


--- trunk/Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp	2012-09-28 10:59:32 UTC (rev 129873)
+++ trunk/Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp	2012-09-28 11:15:01 UTC (rev 129874)
@@ -318,6 +318,7 @@
     DumpRenderTreeSupportEfl::setSerializeHTTPLoads(false);
     DumpRenderTreeSupportEfl::setMinimumLogicalFontSize(mainView(), 9);
     DumpRenderTreeSupportEfl::setCSSRegionsEnabled(mainView(), true);
+    DumpRenderTreeSupportEfl::setShouldTrackVisitedLinks(false);
 
     // Reset capacities for the memory cache for dead objects.
     static const unsigned cacheTotalCapacity =  8192 * 1024;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to