Title: [129881] trunk
- Revision
- 129881
- Author
- [email protected]
- Date
- 2012-09-28 05:56:55 -0700 (Fri, 28 Sep 2012)
Log Message
editing/pasteboard/paste-removing-iframe.html crashes on EFL bots
https://bugs.webkit.org/show_bug.cgi?id=97892
Patch by Sudarsana Nagineni <[email protected]> on 2012-09-28
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
Added missing null check to avoid a crash if the document inside
iframe is removed during the editing operation.
Test: editing/pasteboard/paste-removing-iframe.html
* editing/Editor.cpp:
(WebCore::Editor::changeSelectionAfterCommand):
LayoutTests:
Unskip editing/pasteboard/paste-removing-iframe.html
* platform/efl/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (129880 => 129881)
--- trunk/LayoutTests/ChangeLog 2012-09-28 12:48:25 UTC (rev 129880)
+++ trunk/LayoutTests/ChangeLog 2012-09-28 12:56:55 UTC (rev 129881)
@@ -1,3 +1,14 @@
+2012-09-28 Sudarsana Nagineni <[email protected]>
+
+ editing/pasteboard/paste-removing-iframe.html crashes on EFL bots
+ https://bugs.webkit.org/show_bug.cgi?id=97892
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ Unskip editing/pasteboard/paste-removing-iframe.html
+
+ * platform/efl/TestExpectations:
+
2012-09-28 Stephen Chenney <[email protected]>
Unreviewed Chromium TestExpectation addition
Modified: trunk/LayoutTests/platform/efl/TestExpectations (129880 => 129881)
--- trunk/LayoutTests/platform/efl/TestExpectations 2012-09-28 12:48:25 UTC (rev 129880)
+++ trunk/LayoutTests/platform/efl/TestExpectations 2012-09-28 12:56:55 UTC (rev 129881)
@@ -874,7 +874,6 @@
webkit.org/b/84338 editing/pasteboard/paste-placeholder-input.html [ Failure ]
webkit.org/b/84338 editing/pasteboard/paste-plaintext-user-select-none.html [ Failure ]
webkit.org/b/84338 editing/pasteboard/paste-pre-001.html [ Failure ]
-webkit.org/b/84338 editing/pasteboard/paste-removing-iframe.html [ Failure ]
webkit.org/b/84338 editing/pasteboard/paste-sanitize-crash-1.html [ Failure ]
webkit.org/b/84338 editing/pasteboard/paste-sanitize-crash-2.html [ Failure ]
webkit.org/b/84338 editing/style/apply-through-end-of-document.html [ Failure ]
Modified: trunk/Source/WebCore/ChangeLog (129880 => 129881)
--- trunk/Source/WebCore/ChangeLog 2012-09-28 12:48:25 UTC (rev 129880)
+++ trunk/Source/WebCore/ChangeLog 2012-09-28 12:56:55 UTC (rev 129881)
@@ -1,3 +1,18 @@
+2012-09-28 Sudarsana Nagineni <[email protected]>
+
+ editing/pasteboard/paste-removing-iframe.html crashes on EFL bots
+ https://bugs.webkit.org/show_bug.cgi?id=97892
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ Added missing null check to avoid a crash if the document inside
+ iframe is removed during the editing operation.
+
+ Test: editing/pasteboard/paste-removing-iframe.html
+
+ * editing/Editor.cpp:
+ (WebCore::Editor::changeSelectionAfterCommand):
+
2012-09-28 Arvid Nilsson <[email protected]>
[BlackBerry] Destroy thread-specific data for Platform::Graphics::Buffer on the right thread
Modified: trunk/Source/WebCore/editing/Editor.cpp (129880 => 129881)
--- trunk/Source/WebCore/editing/Editor.cpp 2012-09-28 12:48:25 UTC (rev 129880)
+++ trunk/Source/WebCore/editing/Editor.cpp 2012-09-28 12:56:55 UTC (rev 129881)
@@ -2490,7 +2490,7 @@
// change the caret's DOM position (["hello", 0]). In these situations the above FrameSelection::setSelection call
// does not call EditorClient::respondToChangedSelection(), which, on the Mac, sends selection change notifications and
// starts a new kill ring sequence, but we want to do these things (matches AppKit).
- if (selectionDidNotChangeDOMPosition)
+ if (selectionDidNotChangeDOMPosition && client())
client()->respondToChangedSelection(m_frame);
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
