Title: [129888] trunk
- Revision
- 129888
- Author
- [email protected]
- Date
- 2012-09-28 06:49:46 -0700 (Fri, 28 Sep 2012)
Log Message
[GTK] Enable CSS Shaders layout LayoutTests on GTK+
https://bugs.webkit.org/show_bug.cgi?id=97821
Patch by Huang Dongsung <[email protected]> on 2012-09-28
Reviewed by Martin Robinson.
Source/WebKit/gtk:
* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::setCSSCustomFilterEnabled): Pass through to Settings object.
* WebCoreSupport/DumpRenderTreeSupportGtk.h:
(DumpRenderTreeSupportGtk):
Tools:
This feature is disabled via Settings by default, but for testing,
we enable it using layoutTestController.overridePreferences. Add the
necessary plumbing for DRT.
WTR already works because support was added for Apple Mac earlier.
* DumpRenderTree/gtk/DumpRenderTree.cpp:
(resetDefaultsToConsistentValues): Feature is off by default.
* DumpRenderTree/gtk/TestRunnerGtk.cpp:
(TestRunner::overridePreference): Add handling of WebKitCSSCustomFilterEnabled.
Modified Paths
Diff
Modified: trunk/Source/WebKit/gtk/ChangeLog (129887 => 129888)
--- trunk/Source/WebKit/gtk/ChangeLog 2012-09-28 13:47:24 UTC (rev 129887)
+++ trunk/Source/WebKit/gtk/ChangeLog 2012-09-28 13:49:46 UTC (rev 129888)
@@ -1,3 +1,15 @@
+2012-09-28 Huang Dongsung <[email protected]>
+
+ [GTK] Enable CSS Shaders layout LayoutTests on GTK+
+ https://bugs.webkit.org/show_bug.cgi?id=97821
+
+ Reviewed by Martin Robinson.
+
+ * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
+ (DumpRenderTreeSupportGtk::setCSSCustomFilterEnabled): Pass through to Settings object.
+ * WebCoreSupport/DumpRenderTreeSupportGtk.h:
+ (DumpRenderTreeSupportGtk):
+
2012-09-27 Allan Sandfeld Jensen <[email protected]>
Unify event handling of middle mouse button.
Modified: trunk/Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp (129887 => 129888)
--- trunk/Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp 2012-09-28 13:47:24 UTC (rev 129887)
+++ trunk/Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp 2012-09-28 13:49:46 UTC (rev 129888)
@@ -691,6 +691,13 @@
core(webView)->settings()->setCSSRegionsEnabled(enabled);
}
+void DumpRenderTreeSupportGtk::setCSSCustomFilterEnabled(WebKitWebView* webView, bool enabled)
+{
+#if ENABLE(CSS_SHADERS)
+ core(webView)->settings()->setCSSCustomFilterEnabled(enabled);
+#endif
+}
+
void DumpRenderTreeSupportGtk::setShadowDOMEnabled(bool enabled)
{
#if ENABLE(SHADOW_DOM)
Modified: trunk/Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.h (129887 => 129888)
--- trunk/Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.h 2012-09-28 13:47:24 UTC (rev 129887)
+++ trunk/Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.h 2012-09-28 13:49:46 UTC (rev 129888)
@@ -118,6 +118,7 @@
static void setPageCacheSupportsPlugins(WebKitWebView*, bool enabled);
static void setCSSGridLayoutEnabled(WebKitWebView*, bool enabled);
static void setCSSRegionsEnabled(WebKitWebView*, bool enabled);
+ static void setCSSCustomFilterEnabled(WebKitWebView*, bool enabled);
static void setShadowDOMEnabled(bool);
static void setStyleScopedEnabled(bool);
Modified: trunk/Tools/ChangeLog (129887 => 129888)
--- trunk/Tools/ChangeLog 2012-09-28 13:47:24 UTC (rev 129887)
+++ trunk/Tools/ChangeLog 2012-09-28 13:49:46 UTC (rev 129888)
@@ -1,3 +1,21 @@
+2012-09-28 Huang Dongsung <[email protected]>
+
+ [GTK] Enable CSS Shaders layout LayoutTests on GTK+
+ https://bugs.webkit.org/show_bug.cgi?id=97821
+
+ Reviewed by Martin Robinson.
+
+ This feature is disabled via Settings by default, but for testing,
+ we enable it using layoutTestController.overridePreferences. Add the
+ necessary plumbing for DRT.
+
+ WTR already works because support was added for Apple Mac earlier.
+
+ * DumpRenderTree/gtk/DumpRenderTree.cpp:
+ (resetDefaultsToConsistentValues): Feature is off by default.
+ * DumpRenderTree/gtk/TestRunnerGtk.cpp:
+ (TestRunner::overridePreference): Add handling of WebKitCSSCustomFilterEnabled.
+
2012-09-28 Csaba Osztrogonác <[email protected]>
[Qt] Make NRWT use wk2/TestExpectations file
Modified: trunk/Tools/DumpRenderTree/gtk/DumpRenderTree.cpp (129887 => 129888)
--- trunk/Tools/DumpRenderTree/gtk/DumpRenderTree.cpp 2012-09-28 13:47:24 UTC (rev 129887)
+++ trunk/Tools/DumpRenderTree/gtk/DumpRenderTree.cpp 2012-09-28 13:49:46 UTC (rev 129888)
@@ -516,6 +516,7 @@
DumpRenderTreeSupportGtk::setCSSGridLayoutEnabled(webView, false);
DumpRenderTreeSupportGtk::setCSSRegionsEnabled(webView, true);
+ DumpRenderTreeSupportGtk::setCSSCustomFilterEnabled(webView, false);
DumpRenderTreeSupportGtk::setShadowDOMEnabled(true);
DumpRenderTreeSupportGtk::setStyleScopedEnabled(true);
}
Modified: trunk/Tools/DumpRenderTree/gtk/TestRunnerGtk.cpp (129887 => 129888)
--- trunk/Tools/DumpRenderTree/gtk/TestRunnerGtk.cpp 2012-09-28 13:47:24 UTC (rev 129887)
+++ trunk/Tools/DumpRenderTree/gtk/TestRunnerGtk.cpp 2012-09-28 13:49:46 UTC (rev 129888)
@@ -790,6 +790,9 @@
} else if (g_str_equal(originalName.get(), "WebKitCSSRegionsEnabled")) {
DumpRenderTreeSupportGtk::setCSSRegionsEnabled(webkit_web_frame_get_web_view(mainFrame), booleanFromValue(valueAsString.get()));
return;
+ } else if (g_str_equal(originalName.get(), "WebKitCSSCustomFilterEnabled")) {
+ DumpRenderTreeSupportGtk::setCSSCustomFilterEnabled(webkit_web_frame_get_web_view(mainFrame), booleanFromValue(valueAsString.get()));
+ return;
} else {
fprintf(stderr, "TestRunner::overridePreference tried to override "
"unknown preference '%s'.\n", originalName.get());
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
