Title: [129901] trunk/Source/WebKit/blackberry
- Revision
- 129901
- Author
- [email protected]
- Date
- 2012-09-28 08:45:20 -0700 (Fri, 28 Sep 2012)
Log Message
[BLACKBERRY] Add isVisible method to WebTapHighlight
https://bugs.webkit.org/show_bug.cgi?id=97915
Patch by Genevieve Mak <[email protected]> on 2012-09-28
Reviewed by Rob Buis.
Reviewed Internally By Andrew Lo
The isVisible() method lets us avoid dispatching to the webkit thread
if the tap highlight isn't visible.
Always clear tap highlight on Touch up when converting Touch Events
to Mouse Events.
* Api/WebTapHighlight.h:
* WebKitSupport/DefaultTapHighlight.h:
(BlackBerry::WebKit::DefaultTapHighlight::isVisible):
* WebKitSupport/TouchEventHandler.cpp:
(BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
Modified Paths
Diff
Modified: trunk/Source/WebKit/blackberry/Api/WebTapHighlight.h (129900 => 129901)
--- trunk/Source/WebKit/blackberry/Api/WebTapHighlight.h 2012-09-28 15:40:58 UTC (rev 129900)
+++ trunk/Source/WebKit/blackberry/Api/WebTapHighlight.h 2012-09-28 15:45:20 UTC (rev 129901)
@@ -33,6 +33,7 @@
virtual void draw(const Platform::IntRectRegion&, int red, int green, int blue, int alpha, bool hideAfterScroll) = 0;
virtual void hide() = 0;
+ virtual bool isVisible() const = 0;
virtual bool shouldHideAfterScroll() const = 0;
};
Modified: trunk/Source/WebKit/blackberry/ChangeLog (129900 => 129901)
--- trunk/Source/WebKit/blackberry/ChangeLog 2012-09-28 15:40:58 UTC (rev 129900)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2012-09-28 15:45:20 UTC (rev 129901)
@@ -1,3 +1,22 @@
+2012-09-28 Genevieve Mak <[email protected]>
+
+ [BLACKBERRY] Add isVisible method to WebTapHighlight
+ https://bugs.webkit.org/show_bug.cgi?id=97915
+
+ Reviewed by Rob Buis.
+
+ Reviewed Internally By Andrew Lo
+ The isVisible() method lets us avoid dispatching to the webkit thread
+ if the tap highlight isn't visible.
+ Always clear tap highlight on Touch up when converting Touch Events
+ to Mouse Events.
+
+ * Api/WebTapHighlight.h:
+ * WebKitSupport/DefaultTapHighlight.h:
+ (BlackBerry::WebKit::DefaultTapHighlight::isVisible):
+ * WebKitSupport/TouchEventHandler.cpp:
+ (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
+
2012-09-28 Andrew Lo <[email protected]>
[BlackBerry] Should suspend page's scripted animations when WebPage is invisible
Modified: trunk/Source/WebKit/blackberry/WebKitSupport/DefaultTapHighlight.h (129900 => 129901)
--- trunk/Source/WebKit/blackberry/WebKitSupport/DefaultTapHighlight.h 2012-09-28 15:40:58 UTC (rev 129900)
+++ trunk/Source/WebKit/blackberry/WebKitSupport/DefaultTapHighlight.h 2012-09-28 15:45:20 UTC (rev 129901)
@@ -50,6 +50,7 @@
virtual void draw(const Platform::IntRectRegion&, int red, int green, int blue, int alpha, bool hideAfterScroll);
virtual void hide();
+ virtual bool isVisible() const { return m_visible; }
virtual bool shouldHideAfterScroll() const { return m_shouldHideAfterScroll; }
// GraphicsLayerClient
Modified: trunk/Source/WebKit/blackberry/WebKitSupport/TouchEventHandler.cpp (129900 => 129901)
--- trunk/Source/WebKit/blackberry/WebKitSupport/TouchEventHandler.cpp 2012-09-28 15:40:58 UTC (rev 129900)
+++ trunk/Source/WebKit/blackberry/WebKitSupport/TouchEventHandler.cpp 2012-09-28 15:45:20 UTC (rev 129901)
@@ -256,6 +256,8 @@
if (m_webPage->m_inputHandler->isInputMode())
m_webPage->m_inputHandler->notifyClientOfKeyboardVisibilityChange(true);
+ m_webPage->m_tapHighlight->hide();
+
IntPoint adjustedPoint;
// always use the true touch point if using the meta-tag, otherwise only use it if we sent mouse moves
// to the page and its requested.
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
