Title: [129920] trunk/Source/WebKit/blackberry
- Revision
- 129920
- Author
- [email protected]
- Date
- 2012-09-28 10:53:33 -0700 (Fri, 28 Sep 2012)
Log Message
[BlackBerry] Hard to tap on x to clear a text field
https://bugs.webkit.org/show_bug.cgi?id=97923
Reviewed by Antonio Gomes.
PR97923
Allow the shadow element for 'X' to be clickable and do not prefer
shadow content-editable div's over the 'X'.
* WebKitSupport/FatFingers.cpp:
(BlackBerry::WebKit::FatFingers::isElementClickable):
Modified Paths
Diff
Modified: trunk/Source/WebKit/blackberry/ChangeLog (129919 => 129920)
--- trunk/Source/WebKit/blackberry/ChangeLog 2012-09-28 17:47:46 UTC (rev 129919)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2012-09-28 17:53:33 UTC (rev 129920)
@@ -1,3 +1,16 @@
+2012-09-28 Rob Buis <[email protected]>
+
+ [BlackBerry] Hard to tap on x to clear a text field
+ https://bugs.webkit.org/show_bug.cgi?id=97923
+
+ Reviewed by Antonio Gomes.
+
+ Allow the shadow element for 'X' to be clickable and do not prefer
+ shadow content-editable div's over the 'X'.
+
+ * WebKitSupport/FatFingers.cpp:
+ (BlackBerry::WebKit::FatFingers::isElementClickable):
+
2012-09-28 Antonio Gomes <[email protected]>
[BlackBerry] Extend composited in-region scrolling to iframes/frames
Modified: trunk/Source/WebKit/blackberry/WebKitSupport/FatFingers.cpp (129919 => 129920)
--- trunk/Source/WebKit/blackberry/WebKitSupport/FatFingers.cpp 2012-09-28 17:47:46 UTC (rev 129919)
+++ trunk/Source/WebKit/blackberry/WebKitSupport/FatFingers.cpp 2012-09-28 17:53:33 UTC (rev 129920)
@@ -93,7 +93,8 @@
ExceptionCode ec = 0;
return element->webkitMatchesSelector("a[href],*:link,*:visited,*[role=button],button,input,select,label[for],area[href],textarea,embed,object", ec)
|| element->isMediaControlElement()
- || element->isContentEditable();
+ || (element->isContentEditable() && !element->isInShadowTree())
+ || element->shadowPseudoId() == "-webkit-search-cancel-button";
}
case MadeClickableByTheWebpage:
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
