Title: [129963] trunk/Source/WebCore
- Revision
- 129963
- Author
- [email protected]
- Date
- 2012-09-28 17:04:33 -0700 (Fri, 28 Sep 2012)
Log Message
Remove unused parameter in SelectorChecker::checkScrollbarPseudoClass.
https://bugs.webkit.org/show_bug.cgi?id=97941
Reviewed by Kentaro Hara.
The last parameter in checkScrollbarPseudoClass was unused, so I removed it.
No change in behavior, just refactoring.
* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOneSelector): Changed the callsite to accommodate the change.
(WebCore::SelectorChecker::checkScrollbarPseudoClass): Removed last param.
* css/SelectorChecker.h: Ditto.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (129962 => 129963)
--- trunk/Source/WebCore/ChangeLog 2012-09-28 23:58:22 UTC (rev 129962)
+++ trunk/Source/WebCore/ChangeLog 2012-09-29 00:04:33 UTC (rev 129963)
@@ -1,3 +1,19 @@
+2012-09-28 Dimitri Glazkov <[email protected]>
+
+ Remove unused parameter in SelectorChecker::checkScrollbarPseudoClass.
+ https://bugs.webkit.org/show_bug.cgi?id=97941
+
+ Reviewed by Kentaro Hara.
+
+ The last parameter in checkScrollbarPseudoClass was unused, so I removed it.
+
+ No change in behavior, just refactoring.
+
+ * css/SelectorChecker.cpp:
+ (WebCore::SelectorChecker::checkOneSelector): Changed the callsite to accommodate the change.
+ (WebCore::SelectorChecker::checkScrollbarPseudoClass): Removed last param.
+ * css/SelectorChecker.h: Ditto.
+
2012-09-27 Alpha Lam <[email protected]>
REGRESSION(r122215) - CachedImage::likelyToBeUsedSoon crashes on accessing a deleted CachedImageClient
Modified: trunk/Source/WebCore/css/SelectorChecker.cpp (129962 => 129963)
--- trunk/Source/WebCore/css/SelectorChecker.cpp 2012-09-28 23:58:22 UTC (rev 129962)
+++ trunk/Source/WebCore/css/SelectorChecker.cpp 2012-09-29 00:04:33 UTC (rev 129963)
@@ -759,7 +759,7 @@
} else if (dynamicPseudo != NOPSEUDO && (RenderScrollbar::scrollbarForStyleResolve() || dynamicPseudo == SCROLLBAR_CORNER || dynamicPseudo == RESIZER)) {
// CSS scrollbars match a specific subset of pseudo classes, and they have specialized rules for each
// (since there are no elements involved).
- return checkScrollbarPseudoClass(selector, dynamicPseudo);
+ return checkScrollbarPseudoClass(selector);
} else if (dynamicPseudo == SELECTION) {
if (selector->pseudoType() == CSSSelector::PseudoWindowInactive)
return !m_document->page()->focusController()->isActive();
@@ -1198,7 +1198,7 @@
return true;
}
-bool SelectorChecker::checkScrollbarPseudoClass(CSSSelector* sel, PseudoId&) const
+bool SelectorChecker::checkScrollbarPseudoClass(CSSSelector* sel) const
{
RenderScrollbar* scrollbar = RenderScrollbar::scrollbarForStyleResolve();
ScrollbarPart part = RenderScrollbar::partForStyleResolve();
Modified: trunk/Source/WebCore/css/SelectorChecker.h (129962 => 129963)
--- trunk/Source/WebCore/css/SelectorChecker.h 2012-09-28 23:58:22 UTC (rev 129962)
+++ trunk/Source/WebCore/css/SelectorChecker.h 2012-09-29 00:04:33 UTC (rev 129963)
@@ -118,7 +118,7 @@
private:
bool checkOneSelector(const SelectorCheckingContext&, PseudoId&, bool& hasUnknownPseudoElements) const;
- bool checkScrollbarPseudoClass(CSSSelector*, PseudoId& dynamicPseudo) const;
+ bool checkScrollbarPseudoClass(CSSSelector*) const;
static bool isFrameFocused(const Element*);
bool fastCheckRightmostSelector(const CSSSelector*, const Element*, VisitedMatchType) const;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
