Title: [130248] trunk/Source/WebKit2
- Revision
- 130248
- Author
- wei...@apple.com
- Date
- 2012-10-02 22:12:10 -0700 (Tue, 02 Oct 2012)
Log Message
Fix a typo and add some \n's to make Mark happy.
Rubber-stamped by Mark "logging must be fast" Rowe.
* WebProcess/InjectedBundle/mac/InjectedBundleMac.mm:
(WebKit::InjectedBundle::load):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (130247 => 130248)
--- trunk/Source/WebKit2/ChangeLog 2012-10-03 04:54:42 UTC (rev 130247)
+++ trunk/Source/WebKit2/ChangeLog 2012-10-03 05:12:10 UTC (rev 130248)
@@ -1,5 +1,14 @@
2012-10-02 Sam Weinig <s...@webkit.org>
+ Fix a typo and add some \n's to make Mark happy.
+
+ Rubber-stamped by Mark "logging must be fast" Rowe.
+
+ * WebProcess/InjectedBundle/mac/InjectedBundleMac.mm:
+ (WebKit::InjectedBundle::load):
+
+2012-10-02 Sam Weinig <s...@webkit.org>
+
Add Objective-C API for the InjectedBundle
https://bugs.webkit.org/show_bug.cgi?id=98222
Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/mac/InjectedBundleMac.mm (130247 => 130248)
--- trunk/Source/WebKit2/WebProcess/InjectedBundle/mac/InjectedBundleMac.mm 2012-10-03 04:54:42 UTC (rev 130247)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/mac/InjectedBundleMac.mm 2012-10-03 05:12:10 UTC (rev 130248)
@@ -63,18 +63,18 @@
RetainPtr<CFURLRef> bundleURL(AdoptCF, CFURLCreateWithFileSystemPath(0, injectedBundlePathStr.get(), kCFURLPOSIXPathStyle, false));
if (!bundleURL) {
- WTFLogAlways("InjectedBundle::load failed - Could not create the url from the path string.");
+ WTFLogAlways("InjectedBundle::load failed - Could not create the url from the path string.\n");
return false;
}
m_platformBundle = [[NSBundle alloc] initWithURL:(NSURL *)bundleURL.get()];
if (!m_platformBundle) {
- WTFLogAlways("InjectedBundle::load failed - Could not create the bundle.");
+ WTFLogAlways("InjectedBundle::load failed - Could not create the bundle.\n");
return false;
}
if (![m_platformBundle load]) {
- WTFLogAlways("InjectedBundle::load failed - Could not load the executable from the bundle.");
+ WTFLogAlways("InjectedBundle::load failed - Could not load the executable from the bundle.\n");
return false;
}
@@ -88,18 +88,18 @@
// Otherwise, look to see if the bundle has a principal class
Class principalClass = [m_platformBundle principalClass];
if (!principalClass) {
- WTFLogAlways("InjectedBundle::load failed - No initialize function or principal class found in the bundle executable.");
+ WTFLogAlways("InjectedBundle::load failed - No initialize function or principal class found in the bundle executable.\n");
return false;
}
if (![principalClass conformsToProtocol:@protocol(WKWebProcessPlugIn)]) {
- WTFLogAlways("InjectedBundle::load failed - Principal class does not conform to the WKWebProcessPlugIn protocol.");
+ WTFLogAlways("InjectedBundle::load failed - Principal class does not conform to the WKWebProcessPlugIn protocol.\n");
return false;
}
id<WKWebProcessPlugIn> instance = (id<WKWebProcessPlugIn>)[[principalClass alloc] init];
if (!instance) {
- WTFLogAlways("InjectedBundle::load failed - Could initialize an instance of the principal class.");
+ WTFLogAlways("InjectedBundle::load failed - Could not initialize an instance of the principal class.\n");
return false;
}
@@ -108,6 +108,7 @@
if ([instance respondsToSelector:@selector(webProcessPlugInInitialize:)])
[instance webProcessPlugInInitialize:[WKWebProcessPlugInController _shared]];
+
return true;
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
