Title: [130312] trunk/Tools
- Revision
- 130312
- Author
- ander...@apple.com
- Date
- 2012-10-03 12:33:49 -0700 (Wed, 03 Oct 2012)
Log Message
Exception thrown when running accessibility/container-node-delete-causes-crash.html test
https://bugs.webkit.org/show_bug.cgi?id=98291
Reviewed by Andreas Kling.
The accessibility/container-node-delete-causes-crash.html test will cause a full accessibility tree
to be created by trying to look up an element with a non-existent ID. This caused an exception to be thrown
when trying to access the children of an element that didn't have any children. Fix this by adding
BEGIN_AX_OBJC_EXCEPTIONS/END_AX_OBJC_EXCEPTIONS around the call to get the children.
* DumpRenderTree/mac/AccessibilityControllerMac.mm:
(findAccessibleObjectById):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (130311 => 130312)
--- trunk/Tools/ChangeLog 2012-10-03 19:17:18 UTC (rev 130311)
+++ trunk/Tools/ChangeLog 2012-10-03 19:33:49 UTC (rev 130312)
@@ -1,3 +1,18 @@
+2012-10-03 Anders Carlsson <ander...@apple.com>
+
+ Exception thrown when running accessibility/container-node-delete-causes-crash.html test
+ https://bugs.webkit.org/show_bug.cgi?id=98291
+
+ Reviewed by Andreas Kling.
+
+ The accessibility/container-node-delete-causes-crash.html test will cause a full accessibility tree
+ to be created by trying to look up an element with a non-existent ID. This caused an exception to be thrown
+ when trying to access the children of an element that didn't have any children. Fix this by adding
+ BEGIN_AX_OBJC_EXCEPTIONS/END_AX_OBJC_EXCEPTIONS around the call to get the children.
+
+ * DumpRenderTree/mac/AccessibilityControllerMac.mm:
+ (findAccessibleObjectById):
+
2012-10-03 Ojan Vafai <o...@chromium.org>
Make partytime work when loading garden-o-matic from trac.webkit.org
Modified: trunk/Tools/DumpRenderTree/mac/AccessibilityControllerMac.mm (130311 => 130312)
--- trunk/Tools/DumpRenderTree/mac/AccessibilityControllerMac.mm 2012-10-03 19:17:18 UTC (rev 130311)
+++ trunk/Tools/DumpRenderTree/mac/AccessibilityControllerMac.mm 2012-10-03 19:33:49 UTC (rev 130312)
@@ -79,6 +79,7 @@
return obj;
END_AX_OBJC_EXCEPTIONS
+ BEGIN_AX_OBJC_EXCEPTIONS
NSArray *children = [obj accessibilityAttributeValue:NSAccessibilityChildrenAttribute];
NSUInteger childrenCount = [children count];
for (NSUInteger i = 0; i < childrenCount; ++i) {
@@ -86,6 +87,7 @@
if (result)
return result;
}
+ END_AX_OBJC_EXCEPTIONS
return 0;
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
