Title: [130374] trunk/Source/WebKit/efl
- Revision
- 130374
- Author
- [email protected]
- Date
- 2012-10-04 01:58:24 -0700 (Thu, 04 Oct 2012)
Log Message
[EFL] webintents/web-intents-failure.html is failing
https://bugs.webkit.org/show_bug.cgi?id=98349
Patch by Christophe Dumez <[email protected]> on 2012-10-04
Reviewed by Gyuyoung Kim.
After r130344, OpaqueJSString().string() returns
an empty string instead of a null one. Therefore,
we need to update the check in
DumpRenderTreeSupportEfl::sendWebIntentResponse().
* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::sendWebIntentResponse):
Modified Paths
Diff
Modified: trunk/Source/WebKit/efl/ChangeLog (130373 => 130374)
--- trunk/Source/WebKit/efl/ChangeLog 2012-10-04 08:50:14 UTC (rev 130373)
+++ trunk/Source/WebKit/efl/ChangeLog 2012-10-04 08:58:24 UTC (rev 130374)
@@ -1,5 +1,20 @@
2012-10-04 Christophe Dumez <[email protected]>
+ [EFL] webintents/web-intents-failure.html is failing
+ https://bugs.webkit.org/show_bug.cgi?id=98349
+
+ Reviewed by Gyuyoung Kim.
+
+ After r130344, OpaqueJSString().string() returns
+ an empty string instead of a null one. Therefore,
+ we need to update the check in
+ DumpRenderTreeSupportEfl::sendWebIntentResponse().
+
+ * WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
+ (DumpRenderTreeSupportEfl::sendWebIntentResponse):
+
+2012-10-04 Christophe Dumez <[email protected]>
+
Regression(r130363): Broke unit tests
https://bugs.webkit.org/show_bug.cgi?id=98341
Modified: trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp (130373 => 130374)
--- trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp 2012-10-04 08:50:14 UTC (rev 130373)
+++ trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp 2012-10-04 08:58:24 UTC (rev 130374)
@@ -577,7 +577,7 @@
{
#if ENABLE(WEB_INTENTS)
String responseString = response->string();
- if (responseString.isNull())
+ if (responseString.isEmpty())
ewk_intent_request_failure_post(request, WebCore::SerializedScriptValue::create(String::fromUTF8("ERROR")));
else
ewk_intent_request_result_post(request, WebCore::SerializedScriptValue::create(String(responseString.impl())));
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
