Title: [130409] trunk/Source/WebCore
- Revision
- 130409
- Author
- [email protected]
- Date
- 2012-10-04 10:46:43 -0700 (Thu, 04 Oct 2012)
Log Message
Fix <input type="month"> tests
https://bugs.webkit.org/show_bug.cgi?id=98426
Reviewed by Ojan Vafai.
The month picker uses flexbox and assumes that it will be aligned with
the last line box. This looks visually correct. I will follow up on
www-style to see what the expected behavior is.
Tests: fast/forms/month-multiple-fields tests cover this.
* rendering/RenderFlexibleBox.cpp:
* rendering/RenderFlexibleBox.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (130408 => 130409)
--- trunk/Source/WebCore/ChangeLog 2012-10-04 17:29:56 UTC (rev 130408)
+++ trunk/Source/WebCore/ChangeLog 2012-10-04 17:46:43 UTC (rev 130409)
@@ -1,3 +1,19 @@
+2012-10-04 Tony Chang <[email protected]>
+
+ Fix <input type="month"> tests
+ https://bugs.webkit.org/show_bug.cgi?id=98426
+
+ Reviewed by Ojan Vafai.
+
+ The month picker uses flexbox and assumes that it will be aligned with
+ the last line box. This looks visually correct. I will follow up on
+ www-style to see what the expected behavior is.
+
+ Tests: fast/forms/month-multiple-fields tests cover this.
+
+ * rendering/RenderFlexibleBox.cpp:
+ * rendering/RenderFlexibleBox.h:
+
2012-10-04 Sheriff Bot <[email protected]>
Unreviewed, rolling out r130396.
Modified: trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp (130408 => 130409)
--- trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp 2012-10-04 17:29:56 UTC (rev 130408)
+++ trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp 2012-10-04 17:46:43 UTC (rev 130409)
@@ -246,12 +246,6 @@
return RenderBox::baselinePosition(baselineType, firstLine, direction, linePositionMode);
}
-LayoutUnit RenderFlexibleBox::lastLineBoxBaseline() const
-{
- // Similar to tables, if we're in an inline-block, align with the bottom of our box.
- return -1;
-}
-
LayoutUnit RenderFlexibleBox::firstLineBoxBaseline() const
{
ASSERT(m_orderIterator);
Modified: trunk/Source/WebCore/rendering/RenderFlexibleBox.h (130408 => 130409)
--- trunk/Source/WebCore/rendering/RenderFlexibleBox.h 2012-10-04 17:29:56 UTC (rev 130408)
+++ trunk/Source/WebCore/rendering/RenderFlexibleBox.h 2012-10-04 17:46:43 UTC (rev 130409)
@@ -51,7 +51,6 @@
virtual LayoutUnit baselinePosition(FontBaseline, bool firstLine, LineDirectionMode, LinePositionMode = PositionOnContainingLine) const OVERRIDE;
virtual LayoutUnit firstLineBoxBaseline() const OVERRIDE;
- virtual LayoutUnit lastLineBoxBaseline() const OVERRIDE;
virtual void paintChildren(PaintInfo& forSelf, const LayoutPoint&, PaintInfo& forChild, bool usePrintRect) OVERRIDE;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
