[webkit-changes] [130562] trunk/Tools

Fri, 05 Oct 2012 15:29:19 -0700

Title: [130562] trunk/Tools
Revision
130562
Author
[email protected]
Date
2012-10-05 15:30:27 -0700 (Fri, 05 Oct 2012)

Log Message

TestResultsServer does not display sync_integration_tests results
https://bugs.webkit.org/show_bug.cgi?id=98551

Patch by Richard Larocque <[email protected]> on 2012-10-05
Reviewed by Ojan Vafai.

Allow builders whose name contains "Sync" to pass through the
isChromiumWebkitDepsTestRunner filter.

The test expectations in flakiness_dashboard_unittests.js have been
updated to match the new behaviour.

* TestResultServer/static-dashboards/builders.js:
(isChromiumDepsGTestRunner):

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (130561 => 130562)


--- trunk/Tools/ChangeLog	2012-10-05 22:13:36 UTC (rev 130561)
+++ trunk/Tools/ChangeLog	2012-10-05 22:30:27 UTC (rev 130562)
@@ -1,3 +1,19 @@
+2012-10-05  Richard Larocque  <[email protected]>
+
+        TestResultsServer does not display sync_integration_tests results
+        https://bugs.webkit.org/show_bug.cgi?id=98551
+
+        Reviewed by Ojan Vafai.
+
+        Allow builders whose name contains "Sync" to pass through the
+        isChromiumWebkitDepsTestRunner filter.
+
+        The test expectations in flakiness_dashboard_unittests.js have been
+        updated to match the new behaviour.
+
+        * TestResultServer/static-dashboards/builders.js:
+        (isChromiumDepsGTestRunner):
+
 2012-10-05  Roger Fong  <[email protected]>
 
         Tests in webkitpy involving child processes are flaky.

Modified: trunk/Tools/TestResultServer/static-dashboards/builders.js (130561 => 130562)


--- trunk/Tools/TestResultServer/static-dashboards/builders.js	2012-10-05 22:13:36 UTC (rev 130561)
+++ trunk/Tools/TestResultServer/static-dashboards/builders.js	2012-10-05 22:30:27 UTC (rev 130562)
@@ -189,7 +189,7 @@
 
 function isChromiumDepsGTestRunner(builder)
 {
-    return builder.indexOf('Tests') != -1 && builder.indexOf('Chrome Frame') == -1;
+    return (builder.indexOf('Tests') != -1 || builder.indexOf('Sync') != -1) && builder.indexOf('Chrome Frame') == -1;
 }
 
 function isChromiumDepsCrosGTestRunner(builder)

Modified: trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard_unittests.js (130561 => 130562)


--- trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard_unittests.js	2012-10-05 22:13:36 UTC (rev 130561)
+++ trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard_unittests.js	2012-10-05 22:30:27 UTC (rev 130562)
@@ -537,10 +537,10 @@
         "Win Builder", "Win Builder (dbg)", "Win Builder 2010 (dbg)", "Win7 Sync", "Win7 Tests (1)", "Win7 Tests (2)", "Win7 Tests (3)", "Win7 Tests (dbg)(1)", "Win7 Tests (dbg)(2)",
         "Win7 Tests (dbg)(3)", "Win7 Tests (dbg)(4)", "Win7 Tests (dbg)(5)", "Win7 Tests (dbg)(6)", "XP Tests (1)", "XP Tests (2)", "XP Tests (3)", "XP Tests (dbg)(1)", "XP Tests (dbg)(2)",
         "XP Tests (dbg)(3)", "XP Tests (dbg)(4)", "XP Tests (dbg)(5)", "XP Tests (dbg)(6)"];
-    var expectedBuilders = [["Interactive Tests (dbg)", 2], ["Linux Tests (dbg)(1)"], ["Linux Tests (dbg)(2)"], ["Linux Tests (dbg)(shared)"], ["Linux Tests x64"],
+    var expectedBuilders = [["Interactive Tests (dbg)", 2], ["Linux Sync"], ["Linux Tests (dbg)(1)"], ["Linux Tests (dbg)(2)"], ["Linux Tests (dbg)(shared)"], ["Linux Tests x64"],
         ["Mac 10.6 Tests (dbg)(1)"], ["Mac 10.6 Tests (dbg)(2)"], ["Mac 10.6 Tests (dbg)(3)"],
-        ["Mac 10.6 Tests (dbg)(4)"], ["Mac10.6 Tests (1)"], ["Mac10.6 Tests (2)"], ["Mac10.6 Tests (3)"], ["NACL Tests"],
-        ["NACL Tests (x64)"], ["Vista Tests (1)"], ["Vista Tests (2)"], ["Vista Tests (3)"], ["Win7 Tests (1)"], ["Win7 Tests (2)"], ["Win7 Tests (3)"], ["Win7 Tests (dbg)(1)"],
+        ["Mac 10.6 Tests (dbg)(4)"], ["Mac10.6 Sync"], ["Mac10.6 Tests (1)"], ["Mac10.6 Tests (2)"], ["Mac10.6 Tests (3)"], ["NACL Tests"],
+        ["NACL Tests (x64)"], ["Vista Tests (1)"], ["Vista Tests (2)"], ["Vista Tests (3)"], ["Win7 Sync"], ["Win7 Tests (1)"], ["Win7 Tests (2)"], ["Win7 Tests (3)"], ["Win7 Tests (dbg)(1)"],
         ["Win7 Tests (dbg)(2)"], ["Win7 Tests (dbg)(3)"], ["Win7 Tests (dbg)(4)"], ["Win7 Tests (dbg)(5)"], ["Win7 Tests (dbg)(6)"], ["XP Tests (1)"], ["XP Tests (2)"], ["XP Tests (3)"],
         ["XP Tests (dbg)(1)"], ["XP Tests (dbg)(2)"], ["XP Tests (dbg)(3)"], ["XP Tests (dbg)(4)"], ["XP Tests (dbg)(5)"], ["XP Tests (dbg)(6)"]];
     deepEqual(generateBuildersFromBuilderList(builderList, isChromiumDepsGTestRunner), expectedBuilders);

_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to