Title: [130652] trunk/Tools
- Revision
- 130652
- Author
- [email protected]
- Date
- 2012-10-08 10:13:48 -0700 (Mon, 08 Oct 2012)
Log Message
[EFL] Use Ctrl+n shortcut to create a new window in MiniBrowser / EWebLauncher
https://bugs.webkit.org/show_bug.cgi?id=98655
Patch by Christophe Dumez <[email protected]> on 2012-10-08
Reviewed by Kenneth Rohde Christiansen.
Use "Ctrl+n" shortcut instead of "F9" to open a new window in
MiniBrowser and EWebLauncher. This is the shortcut that is
commonly used for this action.
* EWebLauncher/main.c:
(on_key_down):
* MiniBrowser/efl/main.c:
(on_key_down):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (130651 => 130652)
--- trunk/Tools/ChangeLog 2012-10-08 17:08:38 UTC (rev 130651)
+++ trunk/Tools/ChangeLog 2012-10-08 17:13:48 UTC (rev 130652)
@@ -1,5 +1,21 @@
2012-10-08 Christophe Dumez <[email protected]>
+ [EFL] Use Ctrl+n shortcut to create a new window in MiniBrowser / EWebLauncher
+ https://bugs.webkit.org/show_bug.cgi?id=98655
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ Use "Ctrl+n" shortcut instead of "F9" to open a new window in
+ MiniBrowser and EWebLauncher. This is the shortcut that is
+ commonly used for this action.
+
+ * EWebLauncher/main.c:
+ (on_key_down):
+ * MiniBrowser/efl/main.c:
+ (on_key_down):
+
+2012-10-08 Christophe Dumez <[email protected]>
+
[EFL][WK2] Add support for window.create in Minibrowser
https://bugs.webkit.org/show_bug.cgi?id=98649
Modified: trunk/Tools/EWebLauncher/main.c (130651 => 130652)
--- trunk/Tools/EWebLauncher/main.c 2012-10-08 17:08:38 UTC (rev 130651)
+++ trunk/Tools/EWebLauncher/main.c 2012-10-08 17:13:48 UTC (rev 130652)
@@ -576,8 +576,8 @@
info("Zoom in (F8) was pressed.\n");
if (currentZoomLevel < MAX_ZOOM_LEVEL && zoom_level_set(obj, currentZoomLevel + 1))
currentZoomLevel++;
- } else if (!strcmp(ev->key, "F9")) {
- info("Create new window (F9) was pressed.\n");
+ } else if (!strcmp(ev->key, "n") && ctrlPressed) {
+ info("Create new window (Ctrl+n) was pressed.\n");
browserCreate("http://www.google.com", app->userArgs);
} else if (!strcmp(ev->key, "g") && ctrlPressed ) {
Evas_Coord x, y, w, h;
Modified: trunk/Tools/MiniBrowser/efl/main.c (130651 => 130652)
--- trunk/Tools/MiniBrowser/efl/main.c 2012-10-08 17:08:38 UTC (rev 130651)
+++ trunk/Tools/MiniBrowser/efl/main.c 2012-10-08 17:13:48 UTC (rev 130652)
@@ -147,6 +147,8 @@
NULL
};
static int currentEncoding = -1;
+ Eina_Bool ctrlPressed = evas_key_modifier_is_set(evas_key_modifier_get(e), "Control");
+
if (!strcmp(ev->key, "F1")) {
info("Back (F1) was pressed\n");
if (!ewk_view_back(obj))
@@ -165,8 +167,8 @@
} else if (!strcmp(ev->key, "F6")) {
info("Stop (F6) was pressed, stop loading.\n");
ewk_view_stop(obj);
- } else if (!strcmp(ev->key, "F9")) {
- info("Create new window (F9) was pressed.\n");
+ } else if (!strcmp(ev->key, "n") && ctrlPressed) {
+ info("Create new window (Ctrl+n) was pressed.\n");
Browser_Window *window = window_create(DEFAULT_URL, EINA_FALSE);
windows = eina_list_append(windows, window);
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
