Title: [130664] trunk/Source/_javascript_Core
Revision
130664
Author
[email protected]
Date
2012-10-08 11:46:20 -0700 (Mon, 08 Oct 2012)

Log Message

After r130344, OpaqueJSString() creates an empty string which should be a null string
https://bugs.webkit.org/show_bug.cgi?id=98417

Reviewed by Sam Weinig.

Changed create() of a null string to return 0. This is the same behavior as before r130344.

* API/OpaqueJSString.cpp:
(OpaqueJSString::create):

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/API/OpaqueJSString.cpp (130663 => 130664)


--- trunk/Source/_javascript_Core/API/OpaqueJSString.cpp	2012-10-08 18:44:03 UTC (rev 130663)
+++ trunk/Source/_javascript_Core/API/OpaqueJSString.cpp	2012-10-08 18:46:20 UTC (rev 130664)
@@ -36,7 +36,7 @@
 {
     if (!string.isNull())
         return adoptRef(new OpaqueJSString(string));
-    return adoptRef(new OpaqueJSString());
+    return 0;
 }
 
 Identifier OpaqueJSString::identifier(JSGlobalData* globalData) const

Modified: trunk/Source/_javascript_Core/ChangeLog (130663 => 130664)


--- trunk/Source/_javascript_Core/ChangeLog	2012-10-08 18:44:03 UTC (rev 130663)
+++ trunk/Source/_javascript_Core/ChangeLog	2012-10-08 18:46:20 UTC (rev 130664)
@@ -1,3 +1,15 @@
+2012-10-08  Michael Saboff  <[email protected]>
+
+        After r130344, OpaqueJSString() creates an empty string which should be a null string
+        https://bugs.webkit.org/show_bug.cgi?id=98417
+
+        Reviewed by Sam Weinig.
+
+        Changed create() of a null string to return 0. This is the same behavior as before r130344.
+
+        * API/OpaqueJSString.cpp:
+        (OpaqueJSString::create):
+
 2012-10-07  Caio Marcelo de Oliveira Filho  <[email protected]>
 
         Rename first/second to key/value in HashMap iterators
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to