Title: [130671] trunk/Source/WebKit2
- Revision
- 130671
- Author
- [email protected]
- Date
- 2012-10-08 12:10:58 -0700 (Mon, 08 Oct 2012)
Log Message
[EFL][WK2] Avoid useless converting to WKPage
https://bugs.webkit.org/show_bug.cgi?id=98516
Patch by Jinwoo Song <[email protected]> on 2012-10-08
Reviewed by Eric Seidel.
Use priv->pageProxy->findString() and priv->pageProxy->hideFindUI()
to avoid useless converting to WK.
* UIProcess/API/efl/ewk_view.cpp:
(ewk_view_text_find):
(ewk_view_text_find_highlight_clear):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (130670 => 130671)
--- trunk/Source/WebKit2/ChangeLog 2012-10-08 19:07:33 UTC (rev 130670)
+++ trunk/Source/WebKit2/ChangeLog 2012-10-08 19:10:58 UTC (rev 130671)
@@ -1,3 +1,17 @@
+2012-10-08 Jinwoo Song <[email protected]>
+
+ [EFL][WK2] Avoid useless converting to WKPage
+ https://bugs.webkit.org/show_bug.cgi?id=98516
+
+ Reviewed by Eric Seidel.
+
+ Use priv->pageProxy->findString() and priv->pageProxy->hideFindUI()
+ to avoid useless converting to WK.
+
+ * UIProcess/API/efl/ewk_view.cpp:
+ (ewk_view_text_find):
+ (ewk_view_text_find_highlight_clear):
+
2012-10-08 Sudarsana Nagineni <[email protected]>
[WK2][WTR] WebKitTestRunner needs testRunner.dispatchPendingLoadRequests
Modified: trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp (130670 => 130671)
--- trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp 2012-10-08 19:07:33 UTC (rev 130670)
+++ trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp 2012-10-08 19:10:58 UTC (rev 130671)
@@ -1586,8 +1586,7 @@
EWK_VIEW_PRIV_GET_OR_RETURN(smartData, priv, false);
EINA_SAFETY_ON_NULL_RETURN_VAL(text, false);
- WKRetainPtr<WKStringRef> findText(AdoptWK, WKStringCreateWithUTF8CString(text));
- WKPageFindString(toAPI(priv->pageProxy.get()), findText.get(), static_cast<WKFindOptions>(options), maxMatchCount);
+ priv->pageProxy->findString(String::fromUTF8(text), static_cast<WebKit::FindOptions>(options), maxMatchCount);
return true;
}
@@ -1597,7 +1596,7 @@
EWK_VIEW_SD_GET_OR_RETURN(ewkView, smartData, false);
EWK_VIEW_PRIV_GET_OR_RETURN(smartData, priv, false);
- WKPageHideFindUI(toAPI(priv->pageProxy.get()));
+ priv->pageProxy->hideFindUI();
return true;
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
