Title: [130682] trunk
Revision
130682
Author
[email protected]
Date
2012-10-08 13:54:48 -0700 (Mon, 08 Oct 2012)

Log Message

GTK port should warn if bug modifier is missing in TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=98678

Reviewed by Dirk Pranke.

Tools:

Reimplement the warn_if_bug_missing_in_test_expectations method in
GtkPort, returning True for producing a warning in such cases.

* Scripts/webkitpy/layout_tests/port/gtk.py:
(GtkPort.warn_if_bug_missing_in_test_expectations):

LayoutTests:

Add generic Bug(GTK) modifiers for two test expectations.

* platform/gtk/TestExpectations:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (130681 => 130682)


--- trunk/LayoutTests/ChangeLog	2012-10-08 20:48:09 UTC (rev 130681)
+++ trunk/LayoutTests/ChangeLog	2012-10-08 20:54:48 UTC (rev 130682)
@@ -1,3 +1,14 @@
+2012-10-08  Zan Dobersek  <[email protected]>
+
+        GTK port should warn if bug modifier is missing in TestExpectations
+        https://bugs.webkit.org/show_bug.cgi?id=98678
+
+        Reviewed by Dirk Pranke.
+
+        Add generic Bug(GTK) modifiers for two test expectations.
+
+        * platform/gtk/TestExpectations:
+
 2012-10-08  Dirk Pranke  <[email protected]>
 
         Suppress editing/pasteboard/data-transfer-items.html failure.

Modified: trunk/LayoutTests/platform/gtk/TestExpectations (130681 => 130682)


--- trunk/LayoutTests/platform/gtk/TestExpectations	2012-10-08 20:48:09 UTC (rev 130681)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2012-10-08 20:54:48 UTC (rev 130682)
@@ -1315,7 +1315,7 @@
 
 webkit.org/b/94083 media/video-controls-fullscreen-volume.html [ Skip ]
 
-fast/forms/date-multiple-fields
+Bug(GTK) fast/forms/date-multiple-fields [ Skip ]
 webkit.org/b/97299 fast/forms/month-multiple-fields
 webkit.org/b/94186 fast/forms/time-multiple-fields
 webkit.org/b/97877 fast/forms/week-multiple-fields
@@ -1365,7 +1365,7 @@
 webkit.org/b/49142 fast/regions/style-scoped-in-flow-override-region-styling-multiple-regions.html [ ImageOnlyFailure ]
 
 # Missing support in DRT for Geolocation's Coordinate attributes.
-fast/dom/Geolocation/coordinates-interface-attributes.html [ Failure ]
+Bug(GTK) fast/dom/Geolocation/coordinates-interface-attributes.html [ Failure ]
 
 webkit.org/b/98585 fast/exclusions/shape-inside/shape-inside-rounded-rectangle-003.html [ ImageOnlyFailure ]
 

Modified: trunk/Tools/ChangeLog (130681 => 130682)


--- trunk/Tools/ChangeLog	2012-10-08 20:48:09 UTC (rev 130681)
+++ trunk/Tools/ChangeLog	2012-10-08 20:54:48 UTC (rev 130682)
@@ -1,3 +1,16 @@
+2012-10-08  Zan Dobersek  <[email protected]>
+
+        GTK port should warn if bug modifier is missing in TestExpectations
+        https://bugs.webkit.org/show_bug.cgi?id=98678
+
+        Reviewed by Dirk Pranke.
+
+        Reimplement the warn_if_bug_missing_in_test_expectations method in
+        GtkPort, returning True for producing a warning in such cases.
+
+        * Scripts/webkitpy/layout_tests/port/gtk.py:
+        (GtkPort.warn_if_bug_missing_in_test_expectations):
+
 2012-10-08  Ryuan Choi  <[email protected]>
 
         [EFL][DRT] Switch default backing store to single

Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/gtk.py (130681 => 130682)


--- trunk/Tools/Scripts/webkitpy/layout_tests/port/gtk.py	2012-10-08 20:48:09 UTC (rev 130681)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/gtk.py	2012-10-08 20:54:48 UTC (rev 130682)
@@ -41,6 +41,9 @@
     def expectations_files(self):
         return [self._filesystem.join(self._webkit_baseline_path(d), 'TestExpectations') for d in self._skipped_file_search_paths()]
 
+    def warn_if_bug_missing_in_test_expectations(self):
+        return True
+
     def _port_flag_for_scripts(self):
         return "--gtk"
 
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to