Title: [130763] trunk/Source
Revision
130763
Author
[email protected]
Date
2012-10-09 08:00:42 -0700 (Tue, 09 Oct 2012)

Log Message

Get rid of FIXED_POSITION_CREATES_STACKING_CONTEXT in favor of Settings::fixedPositionCreatesStackingContext()
https://bugs.webkit.org/show_bug.cgi?id=98756

Reviewed by Rob Buis.
Patch by Antonio Gomes <[email protected]>

Source/WebCore:

No behavior change so no new tests.

* css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList):

Source/WebKit/blackberry:

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::init):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (130762 => 130763)


--- trunk/Source/WebCore/ChangeLog	2012-10-09 14:48:49 UTC (rev 130762)
+++ trunk/Source/WebCore/ChangeLog	2012-10-09 15:00:42 UTC (rev 130763)
@@ -1,3 +1,15 @@
+2012-10-09  Antonio Gomes  <[email protected]>
+
+        Get rid of FIXED_POSITION_CREATES_STACKING_CONTEXT in favor of Settings::fixedPositionCreatesStackingContext()
+        https://bugs.webkit.org/show_bug.cgi?id=98756
+
+        Reviewed by Rob Buis.
+
+        No behavior change so no new tests.
+
+        * css/StyleResolver.cpp:
+        (WebCore::StyleResolver::collectMatchingRulesForList):
+
 2012-10-09  Simon Hausmann  <[email protected]>
 
         [Qt] Fix build with QtMultimedia

Modified: trunk/Source/WebCore/css/StyleResolver.cpp (130762 => 130763)


--- trunk/Source/WebCore/css/StyleResolver.cpp	2012-10-09 14:48:49 UTC (rev 130762)
+++ trunk/Source/WebCore/css/StyleResolver.cpp	2012-10-09 15:00:42 UTC (rev 130763)
@@ -171,11 +171,6 @@
 #include "StyleCachedImageSet.h"
 #endif
 
-#if PLATFORM(BLACKBERRY)
-#define FIXED_POSITION_CREATES_STACKING_CONTEXT 1
-#endif
-
-
 using namespace std;
 
 namespace WebCore {
@@ -1943,11 +1938,7 @@
         || style->hasFilter()
         || style->hasBlendMode()
         || style->position() == StickyPosition
-#ifdef FIXED_POSITION_CREATES_STACKING_CONTEXT
-        || style->position() == FixedPosition
-#else
         || (style->position() == FixedPosition && e && e->document()->page() && e->document()->page()->settings()->fixedPositionCreatesStackingContext())
-#endif
 #if ENABLE(ACCELERATED_OVERFLOW_SCROLLING)
         // Touch overflow scrolling creates a stacking context.
         || ((style->overflowX() != OHIDDEN || style->overflowY() != OHIDDEN) && style->useTouchOverflowScrolling())

Modified: trunk/Source/WebKit/blackberry/Api/WebPage.cpp (130762 => 130763)


--- trunk/Source/WebKit/blackberry/Api/WebPage.cpp	2012-10-09 14:48:49 UTC (rev 130762)
+++ trunk/Source/WebKit/blackberry/Api/WebPage.cpp	2012-10-09 15:00:42 UTC (rev 130763)
@@ -606,6 +606,7 @@
     m_page->settings()->setInteractiveFormValidationEnabled(true);
     m_page->settings()->setAllowUniversalAccessFromFileURLs(false);
     m_page->settings()->setAllowFileAccessFromFileURLs(false);
+    m_page->settings()->setFixedPositionCreatesStackingContext(true);
 
     m_backingStoreClient = BackingStoreClient::create(m_mainFrame, /* parent frame */ 0, m_webPage);
     // The direct access to BackingStore is left here for convenience since it

Modified: trunk/Source/WebKit/blackberry/ChangeLog (130762 => 130763)


--- trunk/Source/WebKit/blackberry/ChangeLog	2012-10-09 14:48:49 UTC (rev 130762)
+++ trunk/Source/WebKit/blackberry/ChangeLog	2012-10-09 15:00:42 UTC (rev 130763)
@@ -1,3 +1,13 @@
+2012-10-09  Antonio Gomes  <[email protected]>
+
+        Get rid of FIXED_POSITION_CREATES_STACKING_CONTEXT in favor of Settings::fixedPositionCreatesStackingContext()
+        https://bugs.webkit.org/show_bug.cgi?id=98756
+
+        Reviewed by Rob Buis.
+
+        * Api/WebPage.cpp:
+        (BlackBerry::WebKit::WebPagePrivate::init):
+
 2012-10-09  Charles Wei  <[email protected]>
 
         [BlackBerry] Need API to control the DNS Prefetching
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to