Title: [131176] trunk
Revision
131176
Author
[email protected]
Date
2012-10-12 05:11:34 -0700 (Fri, 12 Oct 2012)

Log Message

Web Inspector: [Styles] Colors should be "As authored" by default
https://bugs.webkit.org/show_bug.cgi?id=99017

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Use "original" as the default value of WebInspector.settings.colorFormat.

* inspector/front-end/Settings.js:

LayoutTests:

Test rebaselines.

* inspector/elements/elements-panel-styles-expected.txt:
* inspector/styles/inject-stylesheet-expected.txt:
* inspector/styles/lazy-computed-style-expected.txt:
* inspector/styles/styles-computed-trace-expected.txt:
* inspector/styles/styles-overriden-properties-expected.txt:
* inspector/styles/styles-update-from-js-expected.txt:
* inspector/styles/variables/css-variables-expected.txt:
* platform/chromium/inspector/styles/inject-stylesheet-expected.txt:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (131175 => 131176)


--- trunk/LayoutTests/ChangeLog	2012-10-12 12:05:25 UTC (rev 131175)
+++ trunk/LayoutTests/ChangeLog	2012-10-12 12:11:34 UTC (rev 131176)
@@ -1,3 +1,21 @@
+2012-10-12  Alexander Pavlov  <[email protected]>
+
+        Web Inspector: [Styles] Colors should be "As authored" by default
+        https://bugs.webkit.org/show_bug.cgi?id=99017
+
+        Reviewed by Vsevolod Vlasov.
+
+        Test rebaselines.
+
+        * inspector/elements/elements-panel-styles-expected.txt:
+        * inspector/styles/inject-stylesheet-expected.txt:
+        * inspector/styles/lazy-computed-style-expected.txt:
+        * inspector/styles/styles-computed-trace-expected.txt:
+        * inspector/styles/styles-overriden-properties-expected.txt:
+        * inspector/styles/styles-update-from-js-expected.txt:
+        * inspector/styles/variables/css-variables-expected.txt:
+        * platform/chromium/inspector/styles/inject-stylesheet-expected.txt:
+
 2012-10-12  Vsevolod Vlasov  <[email protected]>
 
         Web Inspector: Extract domain specific editing handling logic from UISourceCode descendants (step 1).

Modified: trunk/LayoutTests/inspector/elements/elements-panel-styles-expected.txt (131175 => 131176)


--- trunk/LayoutTests/inspector/elements/elements-panel-styles-expected.txt	2012-10-12 12:05:25 UTC (rev 131175)
+++ trunk/LayoutTests/inspector/elements/elements-panel-styles-expected.txt	2012-10-12 12:11:34 UTC (rev 131176)
@@ -12,7 +12,7 @@
     .foo - 5px elements-panel-styles.css:14
 border-top-right-radius: 5px;
     .foo - 5px elements-panel-styles.css:14
-color: blue;
+color: rgb(0, 0, 255);
     .foo, .foo::before - blue elements-panel-styles.css:22
     /-- overloaded --/ .foo - black elements-panel-styles.css:14
 display: block;

Modified: trunk/LayoutTests/inspector/styles/inject-stylesheet-expected.txt (131175 => 131176)


--- trunk/LayoutTests/inspector/styles/inject-stylesheet-expected.txt	2012-10-12 12:05:25 UTC (rev 131175)
+++ trunk/LayoutTests/inspector/styles/inject-stylesheet-expected.txt	2012-10-12 12:11:34 UTC (rev 131176)
@@ -13,7 +13,7 @@
     #main - initial inject-stylesheet.html:5
 background-clip: border-box;
     #main - initial inject-stylesheet.html:5
-background-color: blue;
+background-color: rgb(0, 0, 255);
     #main - blue inject-stylesheet.html:5
 background-image: none;
     #main - initial inject-stylesheet.html:5
@@ -21,7 +21,7 @@
     #main - initial inject-stylesheet.html:5
 background-size: auto;
     #main - initial inject-stylesheet.html:5
-color: red;
+color: rgb(255, 0, 0);
     #main - red user stylesheet
 display: block;
     div - block user agent stylesheet
@@ -66,7 +66,7 @@
 background-clip: border-box;
     body - initial inject-stylesheet-iframe-data.html:4
     /-- overloaded --/ #iframebody - initial user stylesheet
-background-color: green;
+background-color: rgb(0, 128, 0);
     body - green inject-stylesheet-iframe-data.html:4
     /-- overloaded --/ #iframebody - red user stylesheet
 background-image: none;

Modified: trunk/LayoutTests/inspector/styles/lazy-computed-style-expected.txt (131175 => 131176)


--- trunk/LayoutTests/inspector/styles/lazy-computed-style-expected.txt	2012-10-12 12:05:25 UTC (rev 131175)
+++ trunk/LayoutTests/inspector/styles/lazy-computed-style-expected.txt	2012-10-12 12:11:34 UTC (rev 131176)
@@ -45,7 +45,7 @@
     #inspected - initial lazy-computed-style.html:15
 background-clip: border-box;
     #inspected - initial lazy-computed-style.html:15
-background-color: gray;
+background-color: rgb(128, 128, 128);
     #inspected - gray lazy-computed-style.html:15
     /-- overloaded --/ #inspected - black lazy-computed-style.html:10
     /-- overloaded --/ #inspected - green lazy-computed-style.html:5

Modified: trunk/LayoutTests/inspector/styles/styles-computed-trace-expected.txt (131175 => 131176)


--- trunk/LayoutTests/inspector/styles/styles-computed-trace-expected.txt	2012-10-12 12:05:25 UTC (rev 131175)
+++ trunk/LayoutTests/inspector/styles/styles-computed-trace-expected.txt	2012-10-12 12:11:34 UTC (rev 131176)
@@ -9,7 +9,7 @@
     #id1 - initial styles-computed-trace.html:23
 background-clip: border-box;
     #id1 - initial styles-computed-trace.html:23
-background-color: gray;
+background-color: rgb(128, 128, 128);
     #id1 - gray styles-computed-trace.html:23
     /-- overloaded --/ #id1 - black styles-computed-trace.html:18
     /-- overloaded --/ #id1 - green styles-computed-trace.html:13
@@ -34,7 +34,7 @@
 
 ==== Computed style for ID2 ====
 [expanded] 
-background-color: blue;
+background-color: rgb(0, 0, 255);
     #id2 - blue styles-computed-trace.html:27
 display: block;
     div - block user agent stylesheet

Modified: trunk/LayoutTests/inspector/styles/styles-overriden-properties-expected.txt (131175 => 131176)


--- trunk/LayoutTests/inspector/styles/styles-overriden-properties-expected.txt	2012-10-12 12:05:25 UTC (rev 131175)
+++ trunk/LayoutTests/inspector/styles/styles-overriden-properties-expected.txt	2012-10-12 12:11:34 UTC (rev 131176)
@@ -6,8 +6,8 @@
 ======== Matched CSS Rules ========
 [expanded] 
 #main  { (styles-overriden-properties.html:4)
-/-- overloaded --/ background: black;
-background: #BADA55;
+/-- overloaded --/ background: #000;
+background: #bada55;
 
 [expanded] 
 div  { (user agent stylesheet)

Modified: trunk/LayoutTests/inspector/styles/styles-update-from-js-expected.txt (131175 => 131176)


--- trunk/LayoutTests/inspector/styles/styles-update-from-js-expected.txt	2012-10-12 12:05:25 UTC (rev 131175)
+++ trunk/LayoutTests/inspector/styles/styles-update-from-js-expected.txt	2012-10-12 12:11:34 UTC (rev 131176)
@@ -7,7 +7,7 @@
 <div id="container" style="color: #daC0DE; border: 1px solid black;">…</div>
 [expanded] 
 element.style  { ()
-color: #DAC0DE;
+color: #daC0DE;
 border: 1px solid black;
     border-top-color: black;
     border-top-style: solid;
@@ -33,7 +33,7 @@
 <div id="container" style="color: rgb(192, 255, 238);">…</div>
 [expanded] 
 element.style  { ()
-color: #C0FFEE;
+color: rgb(192, 255, 238);
 
 ======== Matched CSS Rules ========
 [expanded] 
@@ -46,7 +46,7 @@
 <div id="container" style="color: rgb(192, 255, 238); border: 3px dashed green;">…</div>
 [expanded] 
 element.style  { ()
-color: #C0FFEE;
+color: rgb(192, 255, 238);
 border: 3px dashed green;
     border-top-color: green;
     border-top-style: dashed;
@@ -85,7 +85,7 @@
 ======== Inherited from div#container.red ========
 [expanded] 
 Style Attribute  { ()
-color: #C0FFEE;
+color: rgb(192, 255, 238);
 
 
 
@@ -106,7 +106,7 @@
 ======== Inherited from div#container.red ========
 [expanded] 
 Style Attribute  { ()
-color: #C0FFEE;
+color: rgb(192, 255, 238);
 
 
 

Modified: trunk/LayoutTests/inspector/styles/variables/css-variables-expected.txt (131175 => 131176)


--- trunk/LayoutTests/inspector/styles/variables/css-variables-expected.txt	2012-10-12 12:05:25 UTC (rev 131175)
+++ trunk/LayoutTests/inspector/styles/variables/css-variables-expected.txt	2012-10-12 12:11:34 UTC (rev 131176)
@@ -2,7 +2,7 @@
 
 Text
 [expanded] 
-color: green;
+color: rgb(0, 128, 0);
     #inspected - -webkit-var(a) css-variables.html:7
 display: block;
     div - block user agent stylesheet

Modified: trunk/LayoutTests/platform/chromium/inspector/styles/inject-stylesheet-expected.txt (131175 => 131176)


--- trunk/LayoutTests/platform/chromium/inspector/styles/inject-stylesheet-expected.txt	2012-10-12 12:05:25 UTC (rev 131175)
+++ trunk/LayoutTests/platform/chromium/inspector/styles/inject-stylesheet-expected.txt	2012-10-12 12:11:34 UTC (rev 131176)
@@ -13,7 +13,7 @@
     #main - initial inject-stylesheet.html:5
 background-clip: border-box;
     #main - initial inject-stylesheet.html:5
-background-color: blue;
+background-color: rgb(0, 0, 255);
     #main - blue inject-stylesheet.html:5
 background-image: none;
     #main - initial inject-stylesheet.html:5
@@ -21,7 +21,7 @@
     #main - initial inject-stylesheet.html:5
 background-size: auto;
     #main - initial inject-stylesheet.html:5
-color: red;
+color: rgb(255, 0, 0);
     #main - red user stylesheet
 display: block;
     div - block user agent stylesheet
@@ -66,7 +66,7 @@
 background-clip: border-box;
     #iframebody - initial user stylesheet
     /-- overloaded --/ body - initial inject-stylesheet-iframe-data.html:4
-background-color: red;
+background-color: rgb(255, 0, 0);
     #iframebody - red user stylesheet
     /-- overloaded --/ body - green inject-stylesheet-iframe-data.html:4
 background-image: none;

Modified: trunk/Source/WebCore/ChangeLog (131175 => 131176)


--- trunk/Source/WebCore/ChangeLog	2012-10-12 12:05:25 UTC (rev 131175)
+++ trunk/Source/WebCore/ChangeLog	2012-10-12 12:11:34 UTC (rev 131176)
@@ -1,3 +1,14 @@
+2012-10-12  Alexander Pavlov  <[email protected]>
+
+        Web Inspector: [Styles] Colors should be "As authored" by default
+        https://bugs.webkit.org/show_bug.cgi?id=99017
+
+        Reviewed by Vsevolod Vlasov.
+
+        Use "original" as the default value of WebInspector.settings.colorFormat.
+
+        * inspector/front-end/Settings.js:
+
 2012-10-12  Takashi Sakamoto  <[email protected]>
 
         [WebKit IDL] move extended attributes to left of interface, exception...

Modified: trunk/Source/WebCore/inspector/front-end/Settings.js (131175 => 131176)


--- trunk/Source/WebCore/inspector/front-end/Settings.js	2012-10-12 12:05:25 UTC (rev 131175)
+++ trunk/Source/WebCore/inspector/front-end/Settings.js	2012-10-12 12:11:34 UTC (rev 131176)
@@ -66,7 +66,7 @@
 {
     this._eventSupport = new WebInspector.Object();
 
-    this.colorFormat = this.createSetting("colorFormat", "hex");
+    this.colorFormat = this.createSetting("colorFormat", "original");
     this.consoleHistory = this.createSetting("consoleHistory", []);
     this.debuggerEnabled = this.createSetting("debuggerEnabled", false);
     this.domWordWrap = this.createSetting("domWordWrap", true);
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to